From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
arnaud.pouliquen@foss.st.com
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
peng.fan@nxp.com
Subject: [PATCH V4 1/2] remoteproc: introduce rproc features
Date: Wed, 23 Mar 2022 11:44:04 +0800 [thread overview]
Message-ID: <20220323034405.976643-2-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20220323034405.976643-1-peng.fan@oss.nxp.com>
From: Peng Fan <peng.fan@nxp.com>
remote processor may support:
- firmware recovery with help from main processor
- self recovery without help from main processor
- iommu
- etc
Introduce rproc features could simplify code to avoid adding more bool
flags
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/remoteproc/remoteproc_internal.h | 10 ++++++++++
include/linux/remoteproc.h | 7 +++++++
2 files changed, 17 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_internal.h b/drivers/remoteproc/remoteproc_internal.h
index 72d4d3d7d94d..e9ae743c5587 100644
--- a/drivers/remoteproc/remoteproc_internal.h
+++ b/drivers/remoteproc/remoteproc_internal.h
@@ -24,6 +24,16 @@ struct rproc_debug_trace {
struct rproc_mem_entry trace_mem;
};
+static inline bool rproc_has_feature(struct rproc *rproc, unsigned int feature)
+{
+ return test_bit(feature, rproc->features);
+}
+
+static inline void rproc_set_feature(struct rproc *rproc, unsigned int feature)
+{
+ set_bit(feature, rproc->features);
+}
+
/* from remoteproc_core.c */
void rproc_release(struct kref *kref);
irqreturn_t rproc_vq_interrupt(struct rproc *rproc, int vq_id);
diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
index 7c943f0a2fc4..7847c6b10a69 100644
--- a/include/linux/remoteproc.h
+++ b/include/linux/remoteproc.h
@@ -489,6 +489,11 @@ struct rproc_dump_segment {
loff_t offset;
};
+enum rproc_features {
+ RPROC_FEAT_ATTACH_RECOVERY,
+ RPROC_MAX_FEATURES,
+};
+
/**
* struct rproc - represents a physical remote processor device
* @node: list node of this rproc object
@@ -530,6 +535,7 @@ struct rproc_dump_segment {
* @elf_machine: firmware ELF machine
* @cdev: character device of the rproc
* @cdev_put_on_release: flag to indicate if remoteproc should be shutdown on @char_dev release
+ * @features: indicate remoteproc features
*/
struct rproc {
struct list_head node;
@@ -570,6 +576,7 @@ struct rproc {
u16 elf_machine;
struct cdev cdev;
bool cdev_put_on_release;
+ DECLARE_BITMAP(features, RPROC_MAX_FEATURES);
};
/**
--
2.25.1
next prev parent reply other threads:[~2022-03-23 3:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 3:44 [PATCH V4 0/2] remoteproc: support self recovery Peng Fan (OSS)
2022-03-23 3:44 ` Peng Fan (OSS) [this message]
2022-05-30 17:17 ` [PATCH V4 1/2] remoteproc: introduce rproc features Mathieu Poirier
2022-03-23 3:44 ` [PATCH V4 2/2] remoteproc: support attach recovery after rproc crash Peng Fan (OSS)
2022-05-30 17:50 ` Mathieu Poirier
2022-04-11 5:19 ` [PATCH V4 0/2] remoteproc: support self recovery Peng Fan
2022-04-27 8:36 ` Peng Fan
2022-04-27 14:36 ` Mathieu Poirier
2022-05-17 9:41 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323034405.976643-2-peng.fan@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=arnaud.pouliquen@foss.st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox