From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A019FC433EF for ; Tue, 28 Jun 2022 16:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232086AbiF1QfA (ORCPT ); Tue, 28 Jun 2022 12:35:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232021AbiF1QeU (ORCPT ); Tue, 28 Jun 2022 12:34:20 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7A02AC53 for ; Tue, 28 Jun 2022 09:31:11 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id o18so11567316plg.2 for ; Tue, 28 Jun 2022 09:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cF+v3xaxVEy+SunxyV5FbyGgHqR8srXqFsaqFoR1tTU=; b=Tb/AbhsmkTF7L1MJTGV0JTBgTb/yNK3WWoLZ7cxqxeX0H40RWvO2doFYqpmty5HW4c ahFhGrzB5cEduL5dW4ye6mnhLsns5ytFNgb5mJTII1gAaHg/bUzoYdiw1q/f2/stV8DS AnA2CQaXiTGHZoZ91WwVazQfM95SbI0OsdBROcUoo14G3RU4bMRLKbm8WGm7pVYS5y4a 09vrVF3mPTahGEch3yZc4GmUV9uUdlcMzms0cFgRGPmDRvfXvXwf2yym96KH10VNb7NY Dto0Z66BEsEsaRc6+vT+XP+yNbN0QUD5yNkMC6ft09AL7sc+M5BEhoDa8em5isayK9GU 0jpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cF+v3xaxVEy+SunxyV5FbyGgHqR8srXqFsaqFoR1tTU=; b=5XWOW1AcmiDucQOAT/rKBEcz4FgUo51e0xFhtOCytOIfxtRWYIogF69zf2UqI0GvLa 4KAc0qs1E6viNDfMuuaNuN3mz6eSoEAEWBj2X+MgZlLc3N7mBxA39hZbYyM6btNfcEZQ tKNVn3k1LbwbIgnaFeUm1/EwyMhNnIwrQQlHapaLESsirmfg/XYiWO+KN2OZTUzK9Hhx WjgmLQWTdNNjNnX/iTYlunKKI++fuH1u6n7aAwbNvIOHHmiYsj5YBWyUt+rlng92QZq4 Ph3uU0y1HVgDOWOguQnlItlVVP0cbfDv+d2t+2aUPGWrJP7PiqBdS6woywlzBXsX3sd0 eBkw== X-Gm-Message-State: AJIora8nr4nAiEVuD2PZUEZCDM8Rx+NzIA5ehBnmJvO0J6gccBtd8/SV pycypEax3MMBtKfp95FpyQF2Qg== X-Google-Smtp-Source: AGRyM1vjZ+5N/f77O5qPXoiVUX4pJGxwAQyaaZJRH8JaYvnupRlQYS0vdL1n6f3pazJlx6c2NeH+PA== X-Received: by 2002:a17:903:1c4:b0:16b:7928:95ce with SMTP id e4-20020a17090301c400b0016b792895cemr4459758plh.158.1656433870761; Tue, 28 Jun 2022 09:31:10 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id i3-20020a170902cf0300b0016a0ac06424sm9576140plg.51.2022.06.28.09.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 09:31:09 -0700 (PDT) Date: Tue, 28 Jun 2022 10:31:07 -0600 From: Mathieu Poirier To: Krzysztof Kozlowski Cc: Hangyu Hua , bjorn.andersson@linaro.org, gregkh@linuxfoundation.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] rpmsg: fix possible refcount leak in rpmsg_register_device_override() Message-ID: <20220628163107.GA1942439@p14s> References: <20220624024120.11576-1-hbh25y@gmail.com> <20220624173621.GC1736477@p14s> <47db0cd8-c940-6e74-f8dc-8e3931e13d80@linaro.org> <0bbee169-6fdc-b50e-87f7-1551dac821e2@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bbee169-6fdc-b50e-87f7-1551dac821e2@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Sat, Jun 25, 2022 at 09:40:36PM +0200, Krzysztof Kozlowski wrote: > On 24/06/2022 20:43, Mathieu Poirier wrote: > > On Fri, 24 Jun 2022 at 11:45, Krzysztof Kozlowski > > wrote: > >> > >> On 24/06/2022 19:36, Mathieu Poirier wrote: > >>> On Fri, Jun 24, 2022 at 10:41:20AM +0800, Hangyu Hua wrote: > >>>> rpmsg_register_device_override need to call put_device to free vch when > >>>> driver_set_override fails. > >>>> > >>>> Fix this by adding a put_device() to the error path. > >>>> > >>>> Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device") > >>> > >>> This is funny... Neither Bjorn nor I have reviewed this patch... > >> > >> It was a fix for commit in Greg's tree and Greg's pick it up after a > >> week or something. I am not sure if that's actually funny that Greg has > >> to pick it up without review :( > >> > > > > The patch was sent out on April 19th and committed 3 days later on > > April 22nd. Is 3 days the new patch review time standard? > > Neither 19th, nor 22nd are correct. The patch which you set you never > reviewed, so commit bb17d110cbf2 was sent on 29th of April: > https://lore.kernel.org/all/20220429195946.1061725-1-krzysztof.kozlowski@linaro.org/ > Twitchy fingers... Those dates are for commit 42cd402b8fd4, which is referenced by bb17d110cbf2. The end result is the same, that is patches related to the remoteproc/rpmsg subsystems (or any subsystem) should not be committed before their maintainers have the opportunity to review them. > And committed on 6 of May, which gives some time for review. Where did > you see the other dates? > > > Best regards, > Krzysztof