Re: [PATCH v4 03/21] soc: qcom: Add qcom_minidump_smem module

Greg KH
2023-06-28T15:47:46Z

On Wed, Jun 28, 2023 at 06:04:30PM +0530, Mukesh Ojha wrote:
> Add qcom_minidump_smem module in a preparation to remove smem
> based minidump specific code from driver/remoteproc/qcom_common.c
> and provide needed exported API, this abstract minidump specific
> data layout from qualcomm's remoteproc driver.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> drivers/soc/qcom/Kconfig | 8 ++
> drivers/soc/qcom/qcom_minidump_smem.c | 147 ++++++++++++++++++++++++++++++++++
> include/soc/qcom/qcom_minidump.h | 24 ++++++
> 3 files changed, 179 insertions(+)
> create mode 100644 drivers/soc/qcom/qcom_minidump_smem.c
> create mode 100644 include/soc/qcom/qcom_minidump.h
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index a491718f8064..982310b5a1cb 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -279,4 +279,12 @@ config QCOM_INLINE_CRYPTO_ENGINE
> tristate
> select QCOM_SCM
>
> +config QCOM_MINIDUMP_SMEM
> + tristate "QCOM Minidump SMEM (as backend) Support"
> + depends on ARCH_QCOM
> + depends on QCOM_SMEM
> + help
> + Enablement of core minidump feature is controlled from boot firmware
> + side, and this config allow linux to query minidump segments associated
> + with the remote processor and check its validity.

I can not understand this help text, sorry. Also, what is the module
name?

And why is this only with ARCH_QCOM? Why are we doing ARCH_PLATFORM
symbols still? why is that a thing for a generic cpu type?

And don't you want build coverage? Why not allow that?

thanks,

greg k-h