From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AE9A38CFE1 for ; Fri, 11 Sep 2026 12:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789130378; cv=none; b=AlGOwCaiREIZjCPZoaCZqkyz5CstxT/uRr7XzBm3oitDuc5Mn87Nj3xZ4f3bS1Lw3+voBQUHQCzc90fugDrNZ9OYSyQDQXWDvG4XBIJWBqFG7KbiJdLsiXxelUNtEzXn9cODZCMf0E6EZbZcxCEw/jOwyqzFx+SCtbV1KkxII48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789130378; c=relaxed/simple; bh=GDdmUOvL5qIET19hhzGDg8z0c0RlAlMuQVYPy1uq+Hw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Va+6oYwqOCxZL5SvspR/o7/BvSIKhRevuWoWj8+g+YA271yFm6wnotVJcBKHFLfvX1E8QyvlcFwYQKckxSEKZWr7K6ibxIoeeBtA3dmxAWgG7/Ui777bYT9h+IdFlkv0CDFCOHzm//VWZj3jBKx9vfZ9H0Zbf7eyOIqKH2NEph8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MxtqT1iy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gMfz6rRw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MxtqT1iy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gMfz6rRw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789130373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3o3AUP2GR4e8bKS56CF9rGMsnzBPpsvQ/7QSZVFmj6g=; b=MxtqT1iyLvIMbsg69wDC3iwbEuaPPQqn6okc4ie5s65UB2TMd0dGT0SNfMh/mc8yjMv/oO oV0s5uv70q2OK4rCuRoCbJjY2ApLy5PhJz7lY3//drmcc4pOhT6PPHN+oeRqDE/jyzh3R7 qFgUd9GVVjsxC7KYy6vczjR15DkHHoI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297-T0jbILT2Na-xk574CnyxlQ-1; Fri, 11 Sep 2026 08:39:32 -0400 X-MC-Unique: T0jbILT2Na-xk574CnyxlQ-1 X-Mimecast-MFC-AGG-ID: T0jbILT2Na-xk574CnyxlQ_1789130371 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49b0e6638e3so6539835e9.2 for ; Fri, 11 Sep 2026 05:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1789130371; x=1789735171; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=3o3AUP2GR4e8bKS56CF9rGMsnzBPpsvQ/7QSZVFmj6g=; b=gMfz6rRw+DBxRU4YO78zqKqIWImeitBaqF31uPDXFMaByCH8yHoXRrAj3JroA9oN84 SLx+bbW9/UPf4/8Hd9ch+NgwmlgzwlcxXVUw6FOYQ8Cz4Ru7oqR9jnshWW8zpa/zlTpn SjAP20UUp/cTbbIjE699Dh41l07Q/isXezQ5xIMAZmYuO2bVsJza6EL/xDTwujd8V2/q /onCMmHbVdYho0u2448KfoszrDucZJbicPUzxY5bteJne9p4mjgmwyd7ptzmjm/aadSS Od+VUBAbWX+Wcu5ZcsSk4YjdPMD0QKIJ5m0K4+S7Dpem5KZ+NgTRmkW2LL1a0+gzrUZ7 GUaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789130371; x=1789735171; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3o3AUP2GR4e8bKS56CF9rGMsnzBPpsvQ/7QSZVFmj6g=; b=L0XUds+qYHFyAGEQibCU/KP/LMlaNgq1jScAf0ItjnWfeHOaHioTRDL2QP9spOcJ4Z OsHh3bv2FFFMupiZc2lFtlCIiEPQJQ5DnRMDr1er1a+0KCHcj2r5d+YJD9QRJWZczDLu ml9DaxqxxuuPBeeF/fGoaEvJ2EDclEWgLSYvSAo9QxR+G83/r946zGYvOBmZDnQQql7B XlQhYqHzNQv0a87TnbojhJsgP0X12JW9fvvhwrLOJEU5qCqLZHmgvjeWHTO7yu+Vv29y rZjjoupHbHbXbgu1yGmzc9sTHsGImLXpPBcVYxTS9ARn8CkKAkGlHK9UKIbYSXAtwKVr uQJA== X-Forwarded-Encrypted: i=1; AKwUvBzeZMld6FkhorLPz84BhIitqvUTK0rbTJryPwIGIjjv0CoEHZcf1IzGruLWM+hjoxRrV/wuZjUQjDfgFLIUmEQF@vger.kernel.org X-Gm-Message-State: AFuF++kjJxk7+jc9qBnpjZ64aFeGQOjrJd08KaPLMXF5jUROTEbvCNHd pOnJrJa1keXZfDmqlHTDtk7V/S5NabZ/RVTtV4AxyEjsPH0SiYCrGenz10c4Ug/hSArZexMb3M6 TrWi/gd8LzYdaK2aZNu063S1W+cDTVcxpq/yqu1GlzjG6N4Kmwgj68gjDscgBiJAXA3ndizY= X-Gm-Gg: AYBFou2pjCTpZ7W1XWZGVpJCDE9vXlZM0/1KlsU2M8XiN8h1RoGHaJRPEaJ5p/FnzS0 OlyJFqgOH7EED/ROHTTIyYQIWKlsUeDoz4SzfuZyVYyJ2vSjwlkN1pIT84ED5JcLhWb2V7JytmW WUzNpUh6zaG31DXERey++Xv5nKVcR6ixN2Kv0OYvtJ5y9XlX0zhVvqq5BSoLvAss+OtqtUM8sKX jWf4RiLFjDkbWRgn2q2s+jYwXewG3a+W7q1OoQ/CfWR5G7eWq0r1pWO+fv9HHPJtG4CCgbpiC7i eu0VU85VfnshDQUFbuxcbKHhBCtHNOsxojVLGrIEN+3E4cyaph4650WDcjgoM1Qp/KyDfUj06iw RYt1xI6AD9I3AL1oP/5pcVtc= X-Received: by 2002:a05:600d:4452:20b0:499:b65d:124f with SMTP id 5b1f17b1804b1-49e6198c2aemr35357975e9.11.1789130370696; Fri, 11 Sep 2026 05:39:30 -0700 (PDT) X-Received: by 2002:a05:600d:4452:20b0:499:b65d:124f with SMTP id 5b1f17b1804b1-49e6198c2aemr35357705e9.11.1789130370161; Fri, 11 Sep 2026 05:39:30 -0700 (PDT) Received: from redhat.com (IGLD-80-230-79-236.inter.net.il. [80.230.79.236]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e6420de77sm22739175e9.3.2026.09.11.05.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 05:39:29 -0700 (PDT) Date: Fri, 11 Sep 2026 08:39:25 -0400 From: "Michael S. Tsirkin" To: Karl Mehltretter Cc: Jason Wang , Gerd Hoffmann , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Dmitry Torokhov , Rusty Russell , Pawel Moll , Cornelia Huck , Halil Pasic , Eric Farman , Richard Weinberger , Anton Ivanov , Johannes Berg , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , virtualization@lists.linux.dev, linux-input@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] virtio: synchronize callbacks during device reset Message-ID: <20260911083848-mutt-send-email-mst@kernel.org> References: <20260905152059.89560-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260905152059.89560-1-kmehltretter@gmail.com> On Sat, Sep 05, 2026 at 05:20:56PM +0200, Karl Mehltretter wrote: > A virtqueue callback can outlive virtio_reset_device() and race with a > driver freeing the state it uses. The reset helper documents that no > callbacks remain in progress, but that depends on the transport: > virtio-pci waits in vp_reset(), while virtio-mmio does not. > > virtio_input has a related ordering problem: it unregisters the input > device before resetting the virtio device, while an event callback may > still be using the input device. > > Patch 1 moves the callback wait into the core, using the existing > virtio_synchronize_cbs() operation. Patch 2 fixes the virtio_input teardown > order. Patch 3 adds the missing synchronize_cbs hooks for UML, TmFIFO, > remoteproc and virtio-vdpa. Remoteproc uses one SRCU domain per processor. > > The new hooks wait for callbacks already running. UML, TmFIFO and > remoteproc still allow new callbacks after reset; fixing that is separate > work. The event-virtqueue DMA mapping issue is also separate. > > Changes in v2: > - Patch 1: move the wait into the core instead of fixing only MMIO, as > Michael suggested. Remove the duplicate PCI wait, preserve its shutdown > wait, and fix CCW callback locking. Drop the MMIO polling: reset polling > for v3 and newer is already in fa8833c085b6 ("virtio-mmio: add support > for transport version 3"). > - Patch 2: keep draining completed events when ready becomes false, > instead of breaking out, so teardown does not truncate an input packet. > - Patch 3 is new, at Michael's request. > > I reran the 120-cycle unbind/rebind test in an arm64 KASAN guest with four > vCPUs and a 5 ms busy delay per event. With patch 2 alone over virtio-mmio, > reset returned with the callback still running in all 84 overlapping > cycles. With the series, it waited in all 103. Over PCI with per-queue > MSI-X, it waited in all 66, including runs with threadirqs. No KASAN or > lockdep reports. These runs predate the per-rproc change, which leaves > the tested MMIO and PCI paths unchanged. They confirmed the missing wait, > but did not reproduce a use-after-free: with evdev attached, > input_unregister_device() waits for an RCU grace period that the IRQ > callback blocks. > > That version also passed QEMU input, rebind and shutdown checks on arm64 > MMIO and x86-64 PCI, including arm64 RT, KASAN and KCSAN builds, and x86 > UP/Tiny SRCU. A legacy INTx NIC was present for an additional x86 > shutdown check. The changed objects built with W=1 without warnings on > arm64, x86-64, s390 and SMP UML. The per-rproc version built with W=1 > on arm64 KASAN and x86 Tiny SRCU, and passed six remoteproc callback and > lifetime KUnit tests on each, using mock remoteproc devices. > > Link: https://lore.kernel.org/r/20260818040433.66986-1-kmehltretter@gmail.com I posted a version of patch 1, split up, just to give direction. Feel free to take over it, or test and ack. Thanks a lot for your work!