Linux Remote Processor Subsystem development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bhargav Joshi <j.bhargav.u@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Suman Anna <s-anna@ti.com>,
	linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, goledhruva@gmail.com,
	m-chawdhry@ti.com, daniel.baluta@gmail.com, simona.toaca@nxp.com
Subject: Re: [PATCH] dt-bindings: remoteproc: ti,keystone-rproc: Convert to DT schema
Date: Mon, 26 Oct 2026 17:42:21 -0500	[thread overview]
Message-ID: <20261026224221.GA103164-robh@kernel.org> (raw)
In-Reply-To: <20261006-ti-keystone-rproc-v1-1-41f7f078b44e@gmail.com>

On Tue, Oct 06, 2026 at 12:40:26AM +0530, Bhargav Joshi wrote:
> Convert TI Keystone DSP remoteproc binding from legacy text format to DT
> schema. No functional changes are introduced during conversion.
> 
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> ---
>  .../bindings/remoteproc/ti,keystone-rproc.txt      | 182 ---------------------
>  .../bindings/remoteproc/ti,keystone-rproc.yaml     | 140 ++++++++++++++++
>  2 files changed, 140 insertions(+), 182 deletions(-)


> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.yaml
> new file mode 100644
> index 0000000000000..3117cfb2b3e07
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.yaml
> @@ -0,0 +1,140 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/ti,keystone-rproc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI Keystone DSP devices
> +
> +maintainers:
> +  - Suman Anna <s-anna@ti.com>
> +
> +description: >
> +  The TI Keystone 2 family of SoCs usually have one or more (up to 8) TI DSP
> +  Core sub-systems that are used to offload some of the processor-intensive
> +  tasks or algorithms, for achieving various system level goals.
> +
> +  These processor sub-systems usually contain additional sub-modules like L1
> +  and/or L2 caches/SRAMs, an Interrupt Controller, an external memory
> +  controller, a dedicated local power/sleep controller etc. The DSP processor
> +  core in Keystone 2 SoCs is usually a TMS320C66x CorePac processor.
> +
> +  Each DSP Core sub-system is represented as a single DT node, and should also
> +  have an alias with the stem 'rproc' defined. Each node has a number of
> +  required or optional properties that enable the OS running on the host
> +  processor (ARM CorePac) to perform the device management of the remote
> +  processor and to communicate with the remote processor.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,k2hk-dsp
> +      - ti,k2l-dsp
> +      - ti,k2e-dsp
> +      - ti,k2g-dsp
> +
> +  reg:
> +    minItems: 3
> +    maxItems: 3
> +
> +  reg-names:
> +    items:
> +      - const: l2sram
> +      - const: l1pram
> +      - const: l1dram
> +
> +  interrupts:
> +    minItems: 2
> +    maxItems: 2
> +
> +  interrupt-names:
> +    items:
> +      - const: vring
> +      - const: exception
> +
> +  ti,syscon-dev:
> +    description: Phandle and offset to syscon device
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    items:
> +      - items:
> +          - description: Phandle to Keystone Device State Control node
> +          - description: offset of the DSP boot address register
> +
> +  resets:
> +    maxItems: 1
> +    description:
> +      refer to either of the following reset bindings for the reset argument
> +      specifier as per SoC,
> +      Documentation/devicetree/bindings/reset/ti-syscon-reset.txt for
> +      66AK2HK/66AK2L/66AK2E SoCs or,
> +      Documentation/devicetree/bindings/reset/ti,sci-reset.yaml for 66AK2G SoCs

Drop. The reset provider is outside the scope of this binding.

> +
> +  kick-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO used by the virtio IPC stack to interrupt the remote processor. See
> +      Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml

Drop the 2nd sentence.

> +
> +  memory-region:
> +    maxItems: 1
> +    description:
> +      Reserved memory node can be CMA memory node, and should be defined as per
> +      Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt

Don't add references to .txt bindings. Drop.

> +
> +  clocks:
> +    maxItems: 1
> +    description:
> +      Input clock (66AK2HK/66AK2L/66AK2E only), see
> +      Documentation/devicetree/bindings/clock/ti,keystone,psc-clock.yaml

Drop.

> +
> +  power-domains:
> +    maxItems: 1
> +    description:
> +      PM domain provider phandle and DSP device id (66AK2G only), see
> +      Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml

Drop

> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - interrupts
> +  - interrupt-names
> +  - ti,syscon-dev
> +  - resets
> +  - kick-gpios
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ti,k2g-dsp
> +    then:
> +      properties:
> +        clocks: false
> +      required:
> +        - power-domains
> +    else:
> +      properties:
> +        power-domains: false
> +      required:
> +        - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dsp@10800000 {
> +      compatible = "ti,k2g-dsp";
> +      reg = <0x10800000 0x00100000>,
> +            <0x10e00000 0x00008000>,
> +            <0x10f00000 0x00008000>;
> +      reg-names = "l2sram", "l1pram", "l1dram";
> +      power-domains = <&k2g_pds 0x0046>;
> +      ti,syscon-dev = <&devctrl 0x844>;
> +      resets = <&k2g_reset 0x0046 0x1>;
> +      interrupts = <0>, <8>;
> +      interrupt-names = "vring", "exception";
> +      kick-gpios = <&dspgpio0 27 0>;
> +      memory-region = <&dsp_common_memory>;
> +    };
> 
> ---
> base-commit: 67f0943b394d920b6c142aad8c6af94340342ae7
> change-id: 20261006-ti-keystone-rproc-4e3b8f328662
> 
> Best regards,
> -- 
> Bhargav
> 
> 

      reply	other threads:[~2026-10-26 22:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 19:10 [PATCH] dt-bindings: remoteproc: ti,keystone-rproc: Convert to DT schema Bhargav Joshi
2026-10-26 22:42 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026224221.GA103164-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=goledhruva@gmail.com \
    --cc=j.bhargav.u@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=s-anna@ti.com \
    --cc=simona.toaca@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox