From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53618EDEC47 for ; Wed, 13 Sep 2023 11:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240381AbjIMLe7 (ORCPT ); Wed, 13 Sep 2023 07:34:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240358AbjIMLet (ORCPT ); Wed, 13 Sep 2023 07:34:49 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4081C3C0E for ; Wed, 13 Sep 2023 04:34:05 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-52a1ce529fdso8881214a12.1 for ; Wed, 13 Sep 2023 04:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694604843; x=1695209643; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wM5SIUdq9q8lGvXrXs9VMWSQTu6Zcs1sHBlGbNl1KLk=; b=x/Am8EON2gkt1A/n8jVWiPwZOJjSM3hm/+eTcUR2VrrMDUfLCXlPdh1/LccfVnOCp2 VsH2Q8+fWHzvxyaua4hVFciVCl9pr5qhdq5tI5Zs91rYI5pQbVLhABlrEKhnQv1sdhV+ 1GEiQLx3b1KodHiQEmP68xzq15KFDkCfvkA6EzHyJLk6bPE4/7MWSfSE3rDFgCp53jLc yzcF2cp+UbdNfHjLC+oRK3DTc33J4PaISBSuAwwdK7ZVJViKbjB0wvceh0ehsArG9Bmx e9cffcO8QwllBlQXOz6wcWBX+mQvIp9ZdFrNHsWBFWFJKS2P9CDfK9NG8Ixa+OsvkzGf OaZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694604843; x=1695209643; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wM5SIUdq9q8lGvXrXs9VMWSQTu6Zcs1sHBlGbNl1KLk=; b=T/JilV2YKGZETKkpoc3sKU9YV3zibFeo2m4604SlR1esZKc3J31JknxcX2LEAUAby4 IHIi5pXDXkHrBeUjopu2TAWhaJ/PmnWviVUnVYtYkHHLJq5eobVY0BuIz4MzmY0eNDtO I5zFKwBKdF8YXtIiPGoio0L758T8WqPR35/+n/h9cnp81fHj1R77qyzIGJDNQmHmpniz ultJkYPvI4qZmJXA/sp7uDyGnigAOxoRBAu2Z3hdiUfahFOkeXDRMg9u5+Dhi3894HaD KwWr5o46hcF3vp2pUG5YnDcWIULaPDYjUihhVhufm809mGw2GwE7wgC0Hejw5Kr0orig dwIg== X-Gm-Message-State: AOJu0Yy4Q8ya/zZOtXgasivnpwAP1WcVDyrm6qB4b3DNnPUW1o/Rrw2v BU5+6WfEDSrEyrp1t9zBedAQ8Q== X-Google-Smtp-Source: AGHT+IFpLPaGgHkHb7TWz2h534XTfQQkS800fp8I2bYQFpK202UNLN0lz7T7mWJfEwkv5Wc31F2IBA== X-Received: by 2002:a17:906:32c3:b0:9a1:f5b1:c85d with SMTP id k3-20020a17090632c300b009a1f5b1c85dmr1827996ejk.12.1694604843481; Wed, 13 Sep 2023 04:34:03 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id a22-20020a1709064a5600b00992ca779f42sm8288599ejv.97.2023.09.13.04.34.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Sep 2023 04:34:02 -0700 (PDT) Message-ID: <32e308fa-1118-e17a-8038-c28cb2484c92@linaro.org> Date: Wed, 13 Sep 2023 13:34:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v6 2/4] remoteproc: k3: Split out data structures common with M4 driver Content-Language: en-US To: Hari Nagalla , andersson@kernel.org, mathieu.poirier@linaro.org, p.zabel@pengutronix.de, martyn.welch@collabora.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20230913111644.29889-1-hnagalla@ti.com> <20230913111644.29889-3-hnagalla@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20230913111644.29889-3-hnagalla@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 13/09/2023 13:16, Hari Nagalla wrote: > From: Martyn Welch > > We will be adding the M4F driver which shares a lot of commonality > with the DSP driver. Common data structures are introduced here. > > Signed-off-by: Martyn Welch > Signed-off-by: Hari Nagalla > --- > Changes in v6: > - Created a separate patch for data structures to ease review > > drivers/remoteproc/ti_k3_common.h | 103 ++++++++++++++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 drivers/remoteproc/ti_k3_common.h > > diff --git a/drivers/remoteproc/ti_k3_common.h b/drivers/remoteproc/ti_k3_common.h > new file mode 100644 > index 000000000000..5e1f27741183 > --- /dev/null > +++ b/drivers/remoteproc/ti_k3_common.h > @@ -0,0 +1,103 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * TI K3 Remote Processor(s) driver common code > + * > + * Refactored from ti_k3_dsp_remoteproc.c. > + * > + * ti_k3_dsp_remoteproc.c: > + * Copyright (C) 2018-2022 Texas Instruments Incorporated - https://www.ti.com/ > + * Suman Anna > + */ > + > +#ifndef REMOTEPROC_TI_K3_COMMON_H > +#define REMOTEPROC_TI_K3_COMMON_H > + > +#define KEYSTONE_RPROC_LOCAL_ADDRESS_MASK (SZ_16M - 1) > + > +/** > + * struct k3_rproc_mem - internal memory structure > + * @cpu_addr: MPU virtual address of the memory region > + * @bus_addr: Bus address used to access the memory region > + * @dev_addr: Device address of the memory region from DSP view > + * @size: Size of the memory region > + */ > +struct k3_rproc_mem { > + void __iomem *cpu_addr; > + phys_addr_t bus_addr; > + u32 dev_addr; > + size_t size; Where is the split? I see only addition here. Where is the usage of this header? This is basically dead code. Don't add dead code, but instead actually move the structures here! Move is cut and paste, not just paste. Best regards, Krzysztof