From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF5DC6FD1F for ; Mon, 13 Mar 2023 01:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229898AbjCMBZg (ORCPT ); Sun, 12 Mar 2023 21:25:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229910AbjCMBZf (ORCPT ); Sun, 12 Mar 2023 21:25:35 -0400 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9CBA367C0; Sun, 12 Mar 2023 18:25:33 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R771e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VdeZwZg_1678670731; Received: from 30.97.48.63(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VdeZwZg_1678670731) by smtp.aliyun-inc.com; Mon, 13 Mar 2023 09:25:31 +0800 Message-ID: <4c27d8dd-8468-ff6d-a015-b4017b82bc72@linux.alibaba.com> Date: Mon, 13 Mar 2023 09:25:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] hwspinlock: omap: drop of_match_ptr for ID table To: Krzysztof Kozlowski , Ohad Ben-Cohen , Bjorn Andersson , linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230311111438.251422-1-krzysztof.kozlowski@linaro.org> From: Baolin Wang In-Reply-To: <20230311111438.251422-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 3/11/2023 7:14 PM, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). > > drivers/hwspinlock/omap_hwspinlock.c:164:34: error: ‘omap_hwspinlock_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski LGTM. Thanks. Reviewed-by: Baolin Wang > --- > drivers/hwspinlock/omap_hwspinlock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c > index 1fb3a2550e29..dfe82952671b 100644 > --- a/drivers/hwspinlock/omap_hwspinlock.c > +++ b/drivers/hwspinlock/omap_hwspinlock.c > @@ -174,7 +174,7 @@ static struct platform_driver omap_hwspinlock_driver = { > .remove = omap_hwspinlock_remove, > .driver = { > .name = "omap_hwspinlock", > - .of_match_table = of_match_ptr(omap_hwspinlock_of_match), > + .of_match_table = omap_hwspinlock_of_match, > }, > }; >