From: rishabhb@codeaurora.org
To: Randy Dunlap <rdunlap@infradead.org>
Cc: bjorn.andersson@linaro.org, ohad@wizery.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
tsoni@codeaurora.org, psodagud@codeaurora.org,
sidgup@codeaurora.org
Subject: Re: [PATCH v4 0/3] Move recovery/coredump configuration to sysfs
Date: Fri, 18 Sep 2020 10:15:36 -0700 [thread overview]
Message-ID: <500895ac9667a82f0ca65696145858f2@codeaurora.org> (raw)
In-Reply-To: <55d2c397-fad3-9dea-289b-6c10d31565ba@infradead.org>
On 2020-09-17 16:40, Randy Dunlap wrote:
> On 9/17/20 11:56 AM, Rishabh Bhatnagar wrote:
>> From Android R onwards Google has restricted access to debugfs in user
>> and user-debug builds. This restricts access to most of the features
>> exposed through debugfs. This patch series removes the
>> recovery/coredump
>> entries from debugfs and moves them to sysfs.
>> 'Coredump' and 'Recovery' are critical interfaces that are required
>> for remoteproc to work on Qualcomm Chipsets. Coredump configuration
>> needs to be set to "inline" in debug/test build and "disabled" in
>> production builds. Whereas recovery needs to be "disabled" for
>> debugging purposes and "enabled" on production builds.
>>
>> Changelog:
>>
>> v4 -> v3:
>> - Remove the feature flag to expose recovery/coredump
>>
>> v3 -> v2:
>> - Remove the coredump/recovery entries from debugfs
>> - Expose recovery/coredump from sysfs under a feature flag
>>
>> v1 -> v2:
>> - Correct the contact name in the sysfs documentation.
>> - Remove the redundant write documentation for coredump/recovery sysfs
>> - Add a feature flag to make this interface switch configurable.
>>
>> Rishabh Bhatnagar (3):
>> remoteproc: Expose remoteproc configuration through sysfs
>> remoteproc: Add coredump configuration to sysfs
>> remoteproc: Add recovery configuration to sysfs
>>
>> Documentation/ABI/testing/sysfs-class-remoteproc | 44 ++++++++
>> drivers/remoteproc/Kconfig | 12 +++
>> drivers/remoteproc/remoteproc_debugfs.c | 10 +-
>> drivers/remoteproc/remoteproc_sysfs.c | 126
>> +++++++++++++++++++++++
>> 4 files changed, 190 insertions(+), 2 deletions(-)
>>
>
> Hi,
>
> Is there a patch 3/3?
> This email (reply) is patch 0/3, then I see
> patch 1/2
> patch 2/2
> so I'm confused. However, the diffstat above references a Kconfig file
> and neither patch 1/2 nor patch 2/2 contains any Kconfig changes.
>
> thanks.
Hi Randy,
The cover letter got messed up. There are only 2 patches now whereas in
the
earlier versions there were 3 patches. I'll be sending out v5 soon.
Please review that.
prev parent reply other threads:[~2020-09-18 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 18:56 [PATCH v4 0/3] Move recovery/coredump configuration to sysfs Rishabh Bhatnagar
2020-09-17 18:56 ` [PATCH v4 1/2] remoteproc: Move coredump " Rishabh Bhatnagar
2020-09-17 18:56 ` [PATCH v4 2/2] remoteproc: Move recovery " Rishabh Bhatnagar
2020-09-17 23:40 ` [PATCH v4 0/3] Move recovery/coredump " Randy Dunlap
2020-09-18 17:15 ` rishabhb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500895ac9667a82f0ca65696145858f2@codeaurora.org \
--to=rishabhb@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=psodagud@codeaurora.org \
--cc=rdunlap@infradead.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox