From: Luca Weiss <luca@z3ntu.xyz>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Luca Weiss <luca.weiss@fairphone.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt
Date: Mon, 26 Jun 2023 22:26:03 +0200 [thread overview]
Message-ID: <5684422.DvuYhMxLoT@z3ntu.xyz> (raw)
In-Reply-To: <2b14f2a7-7f65-1b9d-06dc-92f0ea7fe096@linaro.org>
On Montag, 26. Juni 2023 22:18:11 CEST Konrad Dybcio wrote:
> On 26.06.2023 22:17, Luca Weiss wrote:
> > On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
> >> Add the missing short interrupt. This fixes the schema warning:
> >>
> >> wled@d800: interrupt-names: ['ovp'] is too short
> >>
> >> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >> ---
> >>
> >> arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
> >> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
> >> 100644
> >> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
> >>
> >> pm6150l_wled: leds@d800 {
> >>
> >> compatible = "qcom,pm6150l-wled";
> >> reg = <0xd800>, <0xd900>;
> >>
> >> - interrupts = <0x5 0xd8 0x1
IRQ_TYPE_EDGE_RISING>;
> >> - interrupt-names = "ovp";
> >> + interrupts = <0x5 0xd8 0x1
IRQ_TYPE_EDGE_RISING>,
> >> + <0x5 0xd8 0x2
IRQ_TYPE_EDGE_RISING>;
> >> + interrupt-names = "ovp", "short";
> >
> > Are you sure this interrupt really exists? It's not a thing used
> > downstream at least:
> > https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/
> > android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293
> Confirmed with a reliable source.
Fine by me then.
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
>
> Konrad
>
> > Regards
> > Luca
> >
> >> label = "backlight";
> >>
> >> status = "disabled";
next prev parent reply other threads:[~2023-06-26 20:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
2023-06-26 20:00 ` [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro" Konrad Dybcio
2023-06-26 21:27 ` Rob Herring
2023-06-26 20:00 ` [PATCH 2/7] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks Konrad Dybcio
2023-06-26 21:28 ` Rob Herring
2023-06-26 20:00 ` [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt Konrad Dybcio
2023-06-26 20:17 ` Luca Weiss
2023-06-26 20:18 ` Konrad Dybcio
2023-06-26 20:26 ` Luca Weiss [this message]
2023-06-26 20:00 ` [PATCH 4/7] arm64: dts: qcom: pm660l: " Konrad Dybcio
2023-06-26 20:00 ` [PATCH 5/7] arm64: dts: qcom: pmi8950: Add missing OVP interrupt Konrad Dybcio
2023-06-26 20:00 ` [PATCH 6/7] arm64: dts: qcom: pmi8994: " Konrad Dybcio
2023-06-26 20:00 ` [PATCH 7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3 Konrad Dybcio
2023-06-27 6:09 ` Krzysztof Kozlowski
2023-07-14 5:48 ` (subset) [PATCH 0/7] random msm bindings fixes Bjorn Andersson
2023-07-19 3:21 ` Bjorn Andersson
2023-07-22 5:17 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5684422.DvuYhMxLoT@z3ntu.xyz \
--to=luca@z3ntu.xyz \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kholk11@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=marijn.suijten@somainline.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox