From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB5AC4320A for ; Mon, 23 Aug 2021 16:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 324A9613DB for ; Mon, 23 Aug 2021 16:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbhHWQUS (ORCPT ); Mon, 23 Aug 2021 12:20:18 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:37314 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbhHWQUR (ORCPT ); Mon, 23 Aug 2021 12:20:17 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629735575; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=FsdWWS5i8+Mrzr5FVS8GQ0BaF3qwXImZiY/O4K6ZXGw=; b=FD8uMVunIjNzSO1p0ZY3YNKPDbrpO6TqYylO1ZbOHpB4OaBNm7UDgZhmUkEPmOLTqo/1rzbF Pi3s8/AHsNRm/Vn73kJLOstdQja3YsYEKZAXA8nK5/sOXBCddUQwHxnLsTYLVJ51r8ihBhdC 7Dj2KSV5JKjhOs5uuj423/YJMhM= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI4ZWZiZiIsICJsaW51eC1yZW1vdGVwcm9jQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 6123ca7df588e42af1f37ab3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 23 Aug 2021 16:19:09 GMT Sender: sibis=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id EAD8CC43617; Mon, 23 Aug 2021 16:19:08 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id 41F01C4338F; Mon, 23 Aug 2021 16:19:08 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 23 Aug 2021 21:49:08 +0530 From: Sibi Sankar To: Stephen Boyd Cc: bjorn.andersson@linaro.org, mka@chromium.org, robh+dt@kernel.org, ulf.hansson@linaro.org, rjw@rjwysocki.net, agross@kernel.org, ohad@wizery.com, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, rishabhb@codeaurora.org, sidgup@codeaurora.org Subject: Re: [PATCH v5 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP property In-Reply-To: References: <1629342136-3667-1-git-send-email-sibis@codeaurora.org> <1629342136-3667-3-git-send-email-sibis@codeaurora.org> Message-ID: <5848670f513187734d7625f242bbf67b@codeaurora.org> X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 2021-08-21 23:47, Stephen Boyd wrote: > Quoting Sibi Sankar (2021-08-20 07:24:02) >> On 2021-08-20 00:25, Stephen Boyd wrote: >> > Quoting Sibi Sankar (2021-08-18 20:02:05) >> >> The load state power-domain, used by the co-processors to notify the >> >> Always on Subsystem (AOSS) that a particular co-processor is up/down, >> >> suffers from the side-effect of changing states during suspend/resume. >> >> However the co-processors enter low-power modes independent to that of >> >> the application processor and their states are expected to remain >> >> unaltered across system suspend/resume cycles. To achieve this >> >> behavior >> >> let's drop the load state power-domain and replace them with the qmp >> >> property for all SoCs supporting low power mode signalling. >> >> >> > >> > How do we drop the load state property without breaking existing DTBs? >> > Maybe we need to leave it there and then somehow make it optional? Or >> > do >> > we not care about this problem as the driver will start ignoring it? >> >> We can afford to break the bindings >> because of the following reason: >> >> * Load state in mainline is currently >> broken i.e. it doesn't serve its >> main purpose of signalling AOP of >> the correct state of Q6 during >> system suspend/resume. Thus we >> can maintain current functionality >> even without the load state votes >> i.e. when a new kernel with load >> state removed is used with an older >> dtb the remoteproc functionality >> will remain the same. >> > > Alright. Is that reflected somewhere in the commit text? I must have > missed it. Can you please add it? Commit message throughout the series mention that the current load state implementation is broken but it is never mentioned explicitly that it is the reason why bindings can be broken. I'll wait for a couple of days to see if I get any more comments and will re-word it in the next re-spin. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.