Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

Tony Lindgren
2018-12-19T17:18:16Z

* Mark Brown <broonie@kernel.org> [181219 17:07]:
> On Wed, Dec 19, 2018 at 04:48:52PM +0100, David Lechner wrote:
> > On 12/19/18 4:43 PM, Roger Quadros wrote:
>
> > > Did I do something wrong or we just need to enhance regmap_debugfs.c?
>
> > Do you assign the name field in pru_regmap_config and
> > pru_debug_regmap_config?
>
> Yeah, you'll at least need to override the name since the default is to
> use the name of the device and that'll result in two duplicates.

Also combining IO regions often has a serious issue that the
separate IO regions may not be in the same device (or same
interconnect target module).

This means that flushing a posted write with a read-back for
an IO region will only flush it for a single device and not
the other(s). And this leads into hard to find bugs :)

Regards,

Tony