From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FA9B26CE10 for ; Tue, 1 Jul 2025 10:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751364989; cv=none; b=W1pYGWTNUS8eXgmmnAt3S/EwKNFf8MW1KX771zdQNa69ajQK0Btlv5hrOtbKMClUNLC6Qgt04SPF/SDKRfm/thJIhKS12GA3cwTHdOIy9OPfSH2fZb0KQq1bOx/ofCCcVZ/dk/5bWJ6eqnUsLiPG3+YFdb7t/iAQbcz5/TdmvKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751364989; c=relaxed/simple; bh=2vbNBkeXRi/g9zbIjofBUV/jYjTJHU7Rfds+Aml04H0=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=jY2tKnWQYZ5Cs2+Cn5PYSRfGVyEYsomqDhzbp1aZYrwPgNdxDySMGjCDoGOzIPe0teeVpALL31X3q61EfkM4qjzGI5ghMbpSOV93nHI2V3/G3BrJ4dPB16PW0YUao9yKsEZhmPkE9YyqvUKUS4MPSGDqlhR+YboMuGCzWmSql9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=zh96yD3s; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="zh96yD3s" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-607434e1821so4708501a12.0 for ; Tue, 01 Jul 2025 03:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1751364986; x=1751969786; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8xXy8h+9TejItbdqFIzK4yC4mViXvShPTEKGB2PqHcA=; b=zh96yD3skf/xfV03qpXhZd1nGNC115XO4MNv74tXOedn0eHB9Vvo8Rw46RLhfB/oL1 zCyZeh6vTszxpAOexV8RLJl8JO1LwfxElToDDOC/ky9Ic3+98LMymGsgN4/Z6wqwMmZl KambGpZFVDIdwsj/lYwDo8d06n9IHCfx1pmR+cH6X66tVAQuezaBJWdm5zrhkIASoslP TsdvZoe67FPJCt/PQGtpwFlvWdMULe/hOWpzunz0o3CTZOP2ctqxKX2zKF0zU5dLBI7C MeuZXZ3n7/xHalaFUm9G+77KNz6RLZcUpX0DSfU68mMFO+R6NnSn1KeBipf85L8BUiVy EphA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751364986; x=1751969786; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8xXy8h+9TejItbdqFIzK4yC4mViXvShPTEKGB2PqHcA=; b=NMEoX81Vn9nedW8hF5z0qVvYy8k6AV2alcBGwTCJwWjoFPkBSJyMblKvPiytfLvZK4 9asb4TaJllfuCxKyaZKQ8gSin60K5MgBHAojK9Aq7NscbCTygUYW355sMuMa9rElKn+k +bRWs0hnHYoYSGanA6hRQuC/lDQFqYWcwuVpGJ8ehiyQRT8Jqjjidp4CZYmeaP6sjE12 c3Q/RLeljTvNC08wHdpXmU+FN7vj9fi+F40SF6cHyFZ7uOMFtgNURu8egXYMoa6KEVJ4 IVJzsxW44bEvLo/qOzF0x83j664Fzui9H9nJyaM4ZVB/4ZWJqDT9rNbtrbLRnANX3TqT nfzw== X-Forwarded-Encrypted: i=1; AJvYcCX3XTjm9SPHQ+FoqST5TlJQNrUGJEOdhnleMEnt0UjwIkRk4w2/oNFpUEv8A2QPlAbFI5I0hukiGvGGBdUIlGoS@vger.kernel.org X-Gm-Message-State: AOJu0YxrQXr9aGdmCJXhsY8+GBGZKBnb+GwYRJ5IlD3OPjdgTeqaV/3F v2mxvuTW4Zw4KAraDMGFwla7ORRQh3a+J3a59DG7lq0e/RioKtRp2ngqmgB63F58LfQ= X-Gm-Gg: ASbGncsQCph3ccq5BBLTbYQZ0gtX1CV+O8Z+fsGntNT6JC74bHw++yeKfckUciiWU6s e/yV8lk44CFQuovM3VVp+mw7GPPieyv7/o37Q17JJSiK2H6SZmIJ5XiKq9jj3SmRcq97QCft+cj Nmg3sA/R1G2bV46bfguzp8FZWY549UDJK7MEu1gOJ5Za89NJ3XuY1eooRExOfqJWjCoiVIcPBF5 dkPpXodgk5LueR4E/9w8/broTmL/4CwvXnG2Werfw2DDNQp8R6oM5/eRyW3abCDmFWk8KkKq9s8 c4K5WDq37NrCALiO0r5JwDkL2GO6YbKf1Mj531WXMN5PTMDhKtN+HSUeGonOyjknQ4ziRqdNl/i /yk8RnZOOz8A46M2e8iRoQu+50bjBPVBXHV/RTTkhVtixk7MKu6n8CjMXUoepn9pVe2OLemeUZv kKyDLG9A== X-Google-Smtp-Source: AGHT+IFzOBuC3mZoHMgSDKxYE+Gp2QoQjARO39dkLRc1i2qcYef9U28ETLuq2rRvzxSOj1rllcECwg== X-Received: by 2002:a05:6402:2694:b0:60b:fb2c:b7b3 with SMTP id 4fb4d7f45d1cf-60c88a41c83mr12973871a12.0.1751364986494; Tue, 01 Jul 2025 03:16:26 -0700 (PDT) Received: from localhost (2001-1c00-3b8a-ea00-c4de-d39d-05f4-c77a.cable.dynamic.v6.ziggo.nl. [2001:1c00:3b8a:ea00:c4de:d39d:5f4:c77a]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60c8320b5aasm7072967a12.76.2025.07.01.03.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 03:16:26 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 01 Jul 2025 12:16:25 +0200 Message-Id: Subject: Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP From: "Luca Weiss" To: "Krzysztof Kozlowski" Cc: "Bjorn Andersson" , "Mathieu Poirier" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Manivannan Sadhasivam" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250627-sm7635-remoteprocs-v2-0-0fa518f8bf6d@fairphone.com> <20250627-sm7635-remoteprocs-v2-2-0fa518f8bf6d@fairphone.com> <20250701-pretty-vivacious-panther-540ff4@krzk-bin> In-Reply-To: <20250701-pretty-vivacious-panther-540ff4@krzk-bin> Hi Krzysztof, On Tue Jul 1, 2025 at 10:14 AM CEST, Krzysztof Kozlowski wrote: > On Fri, Jun 27, 2025 at 08:55:43AM +0200, Luca Weiss wrote: >> Document the ADSP & CDSP remoteprocs on the SM7635 Platform. >>=20 >> Signed-off-by: Luca Weiss >> --- >> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 37 +++++++++++++++= +++++++ >> 1 file changed, 37 insertions(+) >>=20 >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pa= s.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >> index 2dd479cf48217a0799ab4e4318026d8b93c3c995..44cc329be5067ab6cbaa0a46= 7669cb3f55c7e714 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >> @@ -18,6 +18,8 @@ properties: >> oneOf: >> - enum: >> - qcom,sdx75-mpss-pas >> + - qcom,sm7635-adsp-pas >> + - qcom,sm7635-cdsp-pas > > I don't understand why this is here and mpss and wpss are in other file. > It is supposed to be in one binding file, especiall that: Is that the idea? (see my reply to my sm8350-pas patch) > >> - qcom,sm8550-adsp-pas >> - qcom,sm8550-cdsp-pas >> - qcom,sm8550-mpss-pas >> @@ -165,6 +167,24 @@ allOf: >> minItems: 5 >> maxItems: 5 >> =20 >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm7635-adsp-pas >> + - qcom,sm7635-cdsp-pas > > it does not fit existing cases! > >> + then: >> + properties: >> + interrupts: >> + minItems: 6 >> + maxItems: 6 >> + interrupt-names: >> + minItems: 6 >> + maxItems: 6 >> + memory-region: >> + minItems: 2 >> + maxItems: 2 >> + >> - if: >> properties: >> compatible: >> @@ -185,6 +205,7 @@ allOf: >> compatible: >> contains: >> enum: >> + - qcom,sm7635-adsp-pas >> - qcom,sm8550-adsp-pas >> - qcom,sm8650-adsp-pas >> - qcom,sm8750-adsp-pas > > sm6350 fits, doesn't it? Not quite, for sure the firmware-name and memory-region for adsp and cdsp on this SoC requires the dtb firmware file as well, apart from that it looks similar enough. I'm also okay with creating a new (after the whole renaming thing) qcom,milos-pas.yaml which contains the bindings for all 4 *-pas'es. Let me know what you want to see in the next version. Regards Luca > >> @@ -239,6 +260,22 @@ allOf: >> - const: mxc >> - const: nsp >> =20 >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm7635-cdsp-pas >> + then: >> + properties: >> + power-domains: >> + items: >> + - description: CX power domain >> + - description: MX power domain >> + power-domain-names: >> + items: >> + - const: cx >> + - const: mx > > And again this is like sm6350 :/ > > Best regards, > Krzysztof