From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BABC0C433FE for ; Sat, 5 Dec 2020 00:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 869B122D6E for ; Sat, 5 Dec 2020 00:26:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726753AbgLEA05 (ORCPT ); Fri, 4 Dec 2020 19:26:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726210AbgLEA04 (ORCPT ); Fri, 4 Dec 2020 19:26:56 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDAF2C061A4F for ; Fri, 4 Dec 2020 16:26:10 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id y74so8194524oia.11 for ; Fri, 04 Dec 2020 16:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qOGIn6XgIjkM7jRRGqXrjtA4GUnaVDyVp5HpjIpLBeQ=; b=cspoud3vzZ21kG9yq7HVX14L34/4y0sCDfxSomzTpfqz0uDLEsUBY4YOMDCtRRp3N1 r9KOpbpiILwKjd20qFbK08ymxr6RU6Ea8Q03AKwhoMUx2kvlXTzhjef9rAaJJDgOEKZ1 l8+ZMS9f3WNriFCGFf4IXG/jbu1dCWHK3v2UIlxEgyLB4F0ipahdJ9HP0opCJOhQeMFq qa2Hftj8LuD6/9usXLXcL6Ee97bv3EzSQovbj9KI1QvlJ4A35CSxbh6/+zlivadP/9cs vCN8V1kK9zEY84k/+klNF6uQ47Nd8op5S1fGFbjW4wDB/Hp8LcTNqz7ODiqb6Wnm/emt XR/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qOGIn6XgIjkM7jRRGqXrjtA4GUnaVDyVp5HpjIpLBeQ=; b=QKynW93yeTQL9aJ5mRIsi2Tkl5VfS9LvHPnkH1ZkG9IUQFIua+VyibDZBXbX0I3Yyp mDzPkDn6u9hVd4U5W2eHzn0SpJjUhesF9rtBL3azAqrQNprFuOgICyN+9qlPltLU+Wmz 5JkZMlodaw+pll7oh3PVF90lnytYZF7b4EBWlXFpvQT83rS6SxqjJf/0QgITVdxZgdrj 5VPtB4+m98HZ+50bmAR4Pgjo/BaA9aodXLylqsA0GNmQQQ7fDlqB+QiyTalK0zH4Ce4n eNdJ4yopvQWx/gckvRJJXhDGccQYZ5QJ3p+tT4ClxBGND7PiU54LpR1a1AiIoYU9pFYN XDPw== X-Gm-Message-State: AOAM533ou8AvzaUoY7Pf7z/0P3YfCuvxJwccWNASFjRiLfZtqP31bSS5 g4OWh7QbFNF9Nr7gU4EDuhWiUA== X-Google-Smtp-Source: ABdhPJyMefuSvFZG9IsAQncafN3zL56HOZm/awMd79vg1THW6ginWeewzZoZQ/jHvS9NBMwc5lpq9A== X-Received: by 2002:aca:f089:: with SMTP id o131mr5098170oih.88.1607127970239; Fri, 04 Dec 2020 16:26:10 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id r7sm1018595oih.21.2020.12.04.16.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 16:26:09 -0800 (PST) Date: Fri, 4 Dec 2020 18:26:07 -0600 From: Bjorn Andersson To: "Peng Fan (OSS)" Cc: ohad@wizery.com, mathieu.poirier@linaro.org, o.rempel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Richard Zhu Subject: Re: [PATCH V3 3/7] remoteproc: imx_rproc: correct err message Message-ID: References: <20201204074036.23870-1-peng.fan@oss.nxp.com> <20201204074036.23870-4-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201204074036.23870-4-peng.fan@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Fri 04 Dec 01:40 CST 2020, Peng Fan (OSS) wrote: > From: Peng Fan > > It is using devm_ioremap, so not devm_ioremap_resource. Correct > the error message and print out sa/size. > > Acked-by: Richard Zhu > Reviewed-by: Mathieu Poirier > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index d1abb253b499..aa5fbd0c7768 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -270,7 +270,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > att->sa, att->size); > if (!priv->mem[b].cpu_addr) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "devm_ioremap failed\n"); I would prefer if this was expanded to a proper sentence, and I really like the second part of the commit message to be included in the change. So something like: dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); And similarly below if mapping a memory-region fails. Thanks, Bjorn > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > -- > 2.28.0 >