From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9356AC77B70 for ; Mon, 17 Apr 2023 06:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230130AbjDQG7B (ORCPT ); Mon, 17 Apr 2023 02:59:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230046AbjDQG7B (ORCPT ); Mon, 17 Apr 2023 02:59:01 -0400 X-Greylist: delayed 184 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 16 Apr 2023 23:58:59 PDT Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C245F1BC2 for ; Sun, 16 Apr 2023 23:58:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681714553; cv=none; d=strato.com; s=strato-dkim-0002; b=P5TA3vNdUMsuzevccSXfTnl4fC6v+MDL0dE6uZjCYY4xOWN2IrHHUVtNlzoFKazGzL cz0p73X5CUiyZwNhjQIBdSJSCVXKZhtKK8TfjHDHk7KuoJcyQkfXlDhR8zsyX3FZLAGS yJU2shb5wmxSNTt4NGf847k9fZ95G6Af9KMB6zP3ATNeT3fvnir4F68vqzFFCUez+plD 9aGbrOq2/CQTJ+WpS+yu9/7jO28M/HvyVvWwvyi7JrkEc31VEW8SZDk4ZWkFYqq87NlF C32l6I90kDEezhmDNMsR3zWSXMMWN3hWlTixVwe77ZIa9SoKxTI7cQckoclPMlvg7deP 1cDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1681714553; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=xcCeKYOa0MHGI98dKHHahLnFxggYEtvrjNiDEqIX4+M=; b=K0D+ov924lOA2MtnZ1HO+z17L4ppJA8usr2LKzR5bTgFfwazxYnytIP9+mzO+3LeYc QvAhzNObfM40nZqCloDQsnxkUZcRB3nMg7o6bpUJTNp+3FGXCkYQMCXzAX36KhcM5cID ddW5kBiBFdQQV2e9fGKA8lbop//T+c8qUQP9OJ6MB97s7nbpMIB+B289OJDrbMyHy/on S7mLldJP7JbnIx2/tueaB009UAUlouqBWnyayY0bXrNoDmn67eFT+Ndr172Y9sY5XHYh qUZm6yJKG2mcSyfJfR5BOJoh2+FOXjjiUOJ9w9hEihTwqQHlRIzwarcAmZUZyTp4mls7 Ck8Q== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1681714553; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=xcCeKYOa0MHGI98dKHHahLnFxggYEtvrjNiDEqIX4+M=; b=kAYexSHiBs4aMdie84oslKxBucZdbrS/eWCEBEvWBTyWvOtz4mI0j0T1ir/d3SEIcj KvuP12OHVOZO6Y4TrFJ7QEBLjlow0k6DeNEio09uG+xHQ2AUdU8/jq+t32PolCwlSUZz rjfwwm7+MHmH7p8CeEaOJM+47uqhTWVsnb2NXsuNTBWX/JNdemM0+s/PV2+BBw98tb0Z BC55IuVyZ/hoHQK6SQH63eVcLyH3+nekJ+HBAenC/uCa7bBrbBXUTP3XEDKC0UFDvi8q c9lhhjY6c0sA3BHXO34xkPvYmyJa1ovWZOivNC++Cewhz6B5s0R9bYB8TpoQlUlUMPJ2 V+Jg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1681714553; s=strato-dkim-0003; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=xcCeKYOa0MHGI98dKHHahLnFxggYEtvrjNiDEqIX4+M=; b=XmOcnTYfGsJZvU6ZPE2pXSKnGb/tXzX5IpofqN1KLLF1yP+3DShdLFTvZUTnYFlrQZ x5HT+hx+xzOtrQEouuCA== X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u261EJF5OxJD4paA8peN1A==" Received: from gerhold.net by smtp.strato.de (RZmta 49.4.0 DYNA|AUTH) with ESMTPSA id j6420az3H6tqb7Z (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 17 Apr 2023 08:55:52 +0200 (CEST) Date: Mon, 17 Apr 2023 08:55:45 +0200 From: Stephan Gerhold To: jbreva@nayarsystems.com Cc: Loic Poulain , Sergey Ryazanov , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: wwan: Expose secondary AT port on DATA1 Message-ID: References: <20230414-rpmsg-wwan-secondary-at-port-v2-1-9a92ee5fdce2@nayarsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414-rpmsg-wwan-secondary-at-port-v2-1-9a92ee5fdce2@nayarsystems.com> Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Mon, Apr 17, 2023 at 08:07:24AM +0200, Jaime Breva via B4 Relay wrote: > From: Jaime Breva > > Our use-case needs two AT ports available: > One for running a ppp daemon, and another one for management > > This patch enables a second AT port on DATA1 > > Signed-off-by: Jaime Breva For future patch resubmissions please pick up already given review tags when you resend new versions (b4 trailers can help you with this). Acked-by: Stephan Gerhold Thanks, Stephan > --- > Changes in v2: > - Modified subject prefix to be netdev list compliant > - Link to v1: https://lore.kernel.org/r/20230414-rpmsg-wwan-secondary-at-port-v1-1-6d7307527911@nayarsystems.com > --- > drivers/net/wwan/rpmsg_wwan_ctrl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wwan/rpmsg_wwan_ctrl.c b/drivers/net/wwan/rpmsg_wwan_ctrl.c > index 31c24420ab2e..e964bdeea2b3 100644 > --- a/drivers/net/wwan/rpmsg_wwan_ctrl.c > +++ b/drivers/net/wwan/rpmsg_wwan_ctrl.c > @@ -149,6 +149,7 @@ static const struct rpmsg_device_id rpmsg_wwan_ctrl_id_table[] = { > /* RPMSG channels for Qualcomm SoCs with integrated modem */ > { .name = "DATA5_CNTL", .driver_data = WWAN_PORT_QMI }, > { .name = "DATA4", .driver_data = WWAN_PORT_AT }, > + { .name = "DATA1", .driver_data = WWAN_PORT_AT }, > {}, > }; > MODULE_DEVICE_TABLE(rpmsg, rpmsg_wwan_ctrl_id_table); > > --- > base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c > change-id: 20230414-rpmsg-wwan-secondary-at-port-db72a66ce74a > > Best regards, > -- > Jaime Breva >