From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FF3C0015E for ; Tue, 18 Jul 2023 16:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232642AbjGRQX0 (ORCPT ); Tue, 18 Jul 2023 12:23:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232692AbjGRQX0 (ORCPT ); Tue, 18 Jul 2023 12:23:26 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D2FA10D2 for ; Tue, 18 Jul 2023 09:23:24 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-67ef5af0ce8so5942642b3a.2 for ; Tue, 18 Jul 2023 09:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689697404; x=1692289404; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8btmNM4fZaWtft2y/AZfU76LwbrOpMNoLAwhQ6pc8YQ=; b=cmpZJ3bTZzlfNOFXhI408nH7WPN8NVQzrqyA2LZFUAt2ZOW8NnC/8keoT7FLyr0b5f t6HltMnTJ5JdbWFLLXVp4AzQlo1wPzXXQPVFFU/bYFZAEoEx65jYxw1LtXXphqZBsNup Pf77k/o8WsJWGccCvRi+CCeOVQhP257vTYjEvPqkRZqahwSd8pXQdDYL+8qwNE+FHLzs CwGwT8Dod9oI/ubbdtftQf7xIiJOp6xXmpbVwwOHT9ZJ+1ibx6oTsJw6O4knZRaa/GZT VMC2Tq+q+htaAVAAruvwjryHXXUbWS+R2p1eXAuf2hwgCQIhCn3Y8IHjHxQJVdfl1DgX 0J9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689697404; x=1692289404; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8btmNM4fZaWtft2y/AZfU76LwbrOpMNoLAwhQ6pc8YQ=; b=C8Oq0DhIYjs0l6nRzByasjiV3W/3dMgrqV0N/2PIuPr+buZpb3JktWBdB/0spmHbc0 b1z2uTM/Fezd8damlDgs959H5ynO48Fm++eNJxRseTF6UiLp+qA5Qt0rvkZ/t6DoP7i4 ZQKYpAj1n/SYDtywYwEYbOq8j3+fCZWs9xpaDn+XBcotklkq9CKH3+oSAG0r+L8/HDGg /YcTESZYXIWxFTbKbADtxR1dRxZmWl5uuht0JO8LlwCnOhQfAqOfvJ2PxGPY95Mh8hGy lxO7nQhY12xKSKmWgNT6ifbB5zgyj9qe74SGZzQLOImbx2t7wKqpoiZt5/hT7tfhw4Oa GxtA== X-Gm-Message-State: ABy/qLbQ+2rGaCBLOBKwjkm0RJeoKH9lpYMTDrAY8+YxOLPwY/eTPGll 0LTPRlkEXHT6dMHPBvNVFdrG9A== X-Google-Smtp-Source: APBJJlEmvs3NrdWOLttT+xLgm5IvnEqfm68aKPVbDjqZNLieClmsHcxjK5jE9syxd0gRUXjnXHGGwQ== X-Received: by 2002:a05:6a20:549f:b0:12c:fa41:3fab with SMTP id i31-20020a056a20549f00b0012cfa413fabmr19605772pzk.45.1689697403839; Tue, 18 Jul 2023 09:23:23 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:181:e3fe:53e1:920]) by smtp.gmail.com with ESMTPSA id z1-20020aa791c1000000b006661562429fsm1769261pfa.97.2023.07.18.09.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 09:23:23 -0700 (PDT) Date: Tue, 18 Jul 2023 10:23:21 -0600 From: Mathieu Poirier To: Bjorn Andersson Cc: Bjorn Andersson , Sarannya S , Chris Lew , Deepak Kumar Singh , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter Subject: Re: [PATCH] rpmsg: glink: Avoid dereferencing NULL channel Message-ID: References: <20230717165538.1542034-1-quic_bjorande@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717165538.1542034-1-quic_bjorande@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Mon, Jul 17, 2023 at 09:55:38AM -0700, Bjorn Andersson wrote: > The newly introduced signal command handler checks for non-existing > channel and print an error message, but then continues on to dereference > that same channel. > > Instead abort the handler when no channel is found. > > Fixes: a2b73aa512a4 ("rpmsg: glink: Add support to handle signals command") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/202307160800.sb7gMnL6-lkp@intel.com/ > Signed-off-by: Bjorn Andersson > --- > drivers/rpmsg/qcom_glink_native.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c > index e10c05ed21bb..82d460ff4777 100644 > --- a/drivers/rpmsg/qcom_glink_native.c > +++ b/drivers/rpmsg/qcom_glink_native.c > @@ -1070,8 +1070,10 @@ static void qcom_glink_handle_signals(struct qcom_glink *glink, > spin_lock_irqsave(&glink->idr_lock, flags); > channel = idr_find(&glink->rcids, rcid); > spin_unlock_irqrestore(&glink->idr_lock, flags); > - if (!channel) > + if (!channel) { > dev_err(glink->dev, "signal for non-existing channel\n"); > + return; > + } I have applied this patch. Thanks, Mathieu > > enable = sigs & NATIVE_DSR_SIG || sigs & NATIVE_CTS_SIG; > > -- > 2.25.1 >