From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7614471721 for ; Thu, 14 Mar 2024 14:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710427985; cv=none; b=sJh7PhDEZ6bdLGPO9f4G7LbW9CDXC4eezWnf0nhOgD18HnJiMMx0/cHkb7m62H6aY6qLLKKSGXoPp2kuYvyoEMsT+/5HMr4PDuUfVHElunhRU88+UvkOg02AnGnpfyIAm4Tft9JcJhquTUBZcLqDEofo7X6QWgvLo9lAhYuRPnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710427985; c=relaxed/simple; bh=Z4Ix1Oz24qrsjV1vmGqdhWdEKSxI4Rx28UJCxDH4Sx0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=if3cb9lZAMpkoer/O7PFkj9ooVaUk6SgXtZLpTgK5qqc9qIHXESkhTozPGTlxBcufy60PFXgS48xrFyj6beMDeCgwVbhL7GGIiI3b9P7G4bRg9Y078qKpVQPh73ND2CVXWWYpl4Ta2kCNsvaUokGHuN3UHBFCesPHG/QzEHkZ6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yeawrzyK; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yeawrzyK" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6e6b3dc3564so1024528b3a.2 for ; Thu, 14 Mar 2024 07:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710427983; x=1711032783; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gQdGRCc8CvufO8pJrzg/EbeDXgOQDIEiNqPLlOCuoyM=; b=yeawrzyK12AlYySnBbLvlrY1hiqyxCZSY1Rim5dOnqUe13MaKTSR9H03Cx2n3ZAZxI UR7h+ffqhVUKMSLkcycaRCSVaBu+0kLoXQzrbtouG4YI0MtPMeRrIKvceunrfAJRCGQP 0Rrluu34ssIuS5bgS/0+hdMZXSI4GRPxGCCGt4NH0yXnAykDFzSEvXu05OGlEfisr5K6 Km3sVE+a6EB27U1hJZ9d2ncYaF2E1qgdw8yLtq1MyT4Uy9RI93zMoy8s01FHNe1XOQrb 2+sIajZSHGn6SqKKG0s4UXoTO0GVnBIn0DdMk2C8Uyi3q8H9a/m6MiGwuIjPxK3SFdc5 d+/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710427983; x=1711032783; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gQdGRCc8CvufO8pJrzg/EbeDXgOQDIEiNqPLlOCuoyM=; b=qKimO627+4H4MAjKK0L/L/juPqHB3m1y883AOLDfyy6AGgrE+lPYZMbaziL6iFZKsO OBtQeMcO3YIBGzdS0iNX1jn7Qbg/xfd4VB4d5MDHt6K4vFYLTa0xGcTEi66erGq1gY7v 4rUD0TlbAq385ElWPsAevFFmoDPiwmG3kcv+W8SxhQM7FFYk11qRyKEd80bamzNTTbE5 0xOftcQ9Vje2ovb5SUef/MSBRCH3YIQZV2l42Bu9ICtukt1uHLclPDc0vJXHRa/tYSwT Xt7VSmB56SzFeT/f9ImHKX0niK8eC030b5RxS5DCzhRyWkVPChYFD1y/8JeUWKKPMdMm cUKw== X-Forwarded-Encrypted: i=1; AJvYcCWvyaKAnQUHtwJJOkGGem15xXln++I3wUgYBaXxeYffuWRavidKfWR3z47I0ywop42XZ0Abt+dEqMZ+xruadHkA8AxKbFKdPTO8djblOn/JGw== X-Gm-Message-State: AOJu0YwOKAsF3U15cEzEmz2TSsyUMSxUxph7RxzZ6lJuR3KIzRnh6y9G 9jkOUY9qOLWAMfYPfBL+p6sr0o6MfpYApujwG83+p0xnfV5lt7zJ+JqsyPj7MSsuPkSL6doUovM 6 X-Google-Smtp-Source: AGHT+IHEMN+NstoSXqaYuO+a0b+IClYsaLbJ/T+IJD4cV0xAleMVWkTv6lKGty1MmRGzfPlPcDv1+Q== X-Received: by 2002:a05:6a00:39a1:b0:6e6:7af6:2201 with SMTP id fi33-20020a056a0039a100b006e67af62201mr1888318pfb.8.1710427982718; Thu, 14 Mar 2024 07:53:02 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:7983:888b:1e31:65e6]) by smtp.gmail.com with ESMTPSA id fb12-20020a056a002d8c00b006e6b73eb992sm1543850pfb.118.2024.03.14.07.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 07:53:02 -0700 (PDT) Date: Thu, 14 Mar 2024 08:52:59 -0600 From: Mathieu Poirier To: Abdellatif El Khlifi Cc: Bjorn Andersson , Rob Herring , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Krzysztof Kozlowski , Conor Dooley , Drew.Reed@arm.com, Adam.Johnston@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver Message-ID: References: <20240301164227.339208-1-abdellatif.elkhlifi@arm.com> <20240301164227.339208-2-abdellatif.elkhlifi@arm.com> <20240307194026.GA355455@e130802.arm.com> <20240311114442.GA82865@e130802.arm.com> <20240312173252.GA38992@e130802.arm.com> <20240313171756.GA82165@e130802.arm.com> Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240313171756.GA82165@e130802.arm.com> On Wed, Mar 13, 2024 at 05:17:56PM +0000, Abdellatif El Khlifi wrote: > Hi Mathieu, > > On Wed, Mar 13, 2024 at 10:25:32AM -0600, Mathieu Poirier wrote: > > On Tue, Mar 12, 2024 at 05:32:52PM +0000, Abdellatif El Khlifi wrote: > > > Hi Mathieu, > > > > > > On Tue, Mar 12, 2024 at 10:29:52AM -0600, Mathieu Poirier wrote: > > > > > This is an initial patchset for allowing to turn on and off the remote processor. > > > > > The FW is already loaded before the Corstone-1000 SoC is powered on and this > > > > > is done through the FPGA board bootloader in case of the FPGA target. Or by the Corstone-1000 FVP model > > > > > (emulator). > > > > > > > > > >From the above I take it that booting with a preloaded firmware is a > > > > scenario that needs to be supported and not just a temporary stage. > > > > > > The current status of the Corstone-1000 SoC requires that there is > > > a preloaded firmware for the external core. Preloading is done externally > > > either through the FPGA bootloader or the emulator (FVP) before powering > > > on the SoC. > > > > > > > Ok > > > > > Corstone-1000 will be upgraded in a way that the A core running Linux is able > > > to share memory with the remote core and also being able to access the remote > > > core memory so Linux can copy the firmware to. This HW changes are still > > > This is why this patchset is relying on a preloaded firmware. And it's the step 1 > > > of adding remoteproc support for Corstone. > > > > > > > Ok, so there is a HW problem where A core and M core can't see each other's > > memory, preventing the A core from copying the firmware image to the proper > > location. > > > > When the HW is fixed, will there be a need to support scenarios where the > > firmware image has been preloaded into memory? > > No, this scenario won't apply when we get the HW upgrade. No need for an > external entity anymore. The firmware(s) will all be files in the linux filesystem. > Very well. I am willing to continue with this driver but it does so little that I wonder if it wouldn't simply be better to move forward with upstreaming when the HW is fixed. The choice is yours. Thanks, Mathieu