From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AD5916DC1B for ; Mon, 1 Jul 2024 16:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719851928; cv=none; b=YOySUFn7FCkZjhFe5Q+0NSuD2NeCCZQMhDT9giL7l98CwXyytSAUhLnBjjWcNidw4QfWZlSjDdijCaBVzQG7WfluAI2V7+9hStbPBDCm+mKRRLk/nxW2FlQvUvcUJqhTQDAfuqMiwAw2YJu5ad2vxX66PgzzAf1et0beTIvlD7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719851928; c=relaxed/simple; bh=0b7GgSUI0eaO01MBB0nXBh/uhDFmkdDbzFFrkkaPLGg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IWx/O/PNPVddHoie9djMuO4/L1xofjyIMpvwgDHfhZNLcpG2NQBlp6MZKmz8CotzQ7AP7BsDdM6a91ksba+0XAsPZ64mUMIiWRnkC08LqRi5lc954g2YOQema63cxYPMOQ0skW37iPT0FuzfFlhaHfdVjR+dFZgFCPexswhsUFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y642MEww; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y642MEww" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7065a2f4573so2076377b3a.2 for ; Mon, 01 Jul 2024 09:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719851926; x=1720456726; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hNYjJKW2jt8iaEsXSmdf0KI6tUTkldXsy2itazLTZ+0=; b=y642MEww6iDrivxrs4wcxpJnjBHGw8CuSQqqOEzp7WhHLkzBJ6MRQH94x3FFOBZYO7 /72FUlfsLCjk2ETrjytYwEDnbDTafgbl1zoIP4gDBFHH+v/aoiLuFCY8TbgaLy4NFJ+h emVPnhsBlKfI9V514uX0QvAuds2V0NXkJX/JhSE46cJGU2C/ZjSbVBhkMok3m/I2Ei6G zbaEI64POA2Rcd6WEJoM5/9Cc4nn2tdDpLKCVt6MxdxT6OhBR9Dji+iZqHpZ8iPuTZV4 Bmgm+qw2eKESMPDADDmbZKi/xyUdYkkKZ+rZdDOFKrPKmsRRqDdStc0VdHccsdHUmx2m gjgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719851926; x=1720456726; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hNYjJKW2jt8iaEsXSmdf0KI6tUTkldXsy2itazLTZ+0=; b=vhhK2kPIk5Tjqdtl8ccBXPhG+v+owilI4VU2bKzfTHBwfAPejzIQniD74H63Bg2wPs hJPgS/lfFm17Ne0epMHmlF/FbAgI8JBC/7wiWjaBxrllYSKA88t16Jc8qsEzlH7TryA2 cMPhxAKOrBLhWf7Icl7qGtn8KSlQTHPciQdxbol8eOW9g8Yis//joHiQtIiyt27LIXpl qGN+5R6VioXP5AVFo4C6V4wCaWikjUMItJo2ugwKygYkUHvRdOPiA7MBgBmtuVyqS7h/ duKxGz8WOTS9SUqh/FLOOa/EDGB9iC7pJH8G5lPG9Zv/ISIVkz8wiXiLwynJmA+4Psid r6Iw== X-Forwarded-Encrypted: i=1; AJvYcCU9cM0KBygYAH56lwUks122FE0YIIB01CSuQJEVZw1UYQbRxho/kjH3D+16udv21zMndA+TIYSStjaCakFEQHyo0NH/oJGF65B8jZhzokpujQ== X-Gm-Message-State: AOJu0Yy+ITiIKU51efetsxvXOebpNCPUQcUA/Ea1oLmaNJ0anGDzA/a3 al0wXyqp1vQlKdrICpEFRs+u9/WXmP0T5eViJRQHy3RNIiA284ChmtQ3OLoB/9s= X-Google-Smtp-Source: AGHT+IGc+D4Kly/VppZGK/Z1ZC7dkWa/VVh5diZ2R4Kt/mwAbmpm/6oFFdZKNY8WdAVVVUZU4t+S3w== X-Received: by 2002:a05:6a21:789f:b0:1be:c59a:8ed8 with SMTP id adf61e73a8af0-1bef60fa8a2mr5963059637.16.1719851926542; Mon, 01 Jul 2024 09:38:46 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:be24:7a34:86fc:1a51]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70838a9a188sm6555725b3a.131.2024.07.01.09.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 09:38:46 -0700 (PDT) Date: Mon, 1 Jul 2024 10:38:43 -0600 From: Mathieu Poirier To: Hari Nagalla Cc: Nishanth Menon , Vignesh Raghavendra , "Andrew F. Davis" , Bjorn Andersson , Philipp Zabel , Suman Anna , Thomas Petazzoni , Alexandre Belloni , Udit Kumar , Thomas Richard , Gregory CLEMENT , =?iso-8859-1?Q?Th=E9o?= Lebrun , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection Message-ID: References: <20240621150058.319524-1-richard.genoud@bootlin.com> <20240621150058.319524-2-richard.genoud@bootlin.com> <3064a3cb-9153-3bd1-4c55-79e8911f029f@ti.com> Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3064a3cb-9153-3bd1-4c55-79e8911f029f@ti.com> On Mon, Jul 01, 2024 at 04:13:00AM -0500, Hari Nagalla wrote: > On 6/28/24 14:58, Mathieu Poirier wrote: > > > This could lead in an incorrect IPC-only mode detection if reset line is > > > asserted (so reset_control_status() return > 0) and c_state != 0 and > > > halted == 0. > > > In this case, the old code would have detected an IPC-only mode instead > > > of a mismatched mode. > > > > > Your assessment seems to be correct. That said I'd like to have an RB or a TB > > from someone in the TI delegation - guys please have a look. > Agree with Richard's assessment, and the proposed fix looks good. > > Reviewed-by: > Hari Nagalla I have applied this patch, no need to send it again. Thanks, Mathieu