From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B202A19B3E2 for ; Tue, 16 Jul 2024 15:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721143015; cv=none; b=RwhQLrVSp3kxBfihsJVAJ3Q4chdKggL0zKr8a3+aPIFFm7YCQ62vzRrkL1ETa5WMQAprE1iB6BhDUVnWIyH9IwboeM36ehb9vBlWP+lBNETVY/A4QoRM4hhHAgcaeo1z1Xe1mNFI69/GFcfPPxuDesxfRggAitLD2Zme+sO5E7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721143015; c=relaxed/simple; bh=QdugAtkkmtyw1j2n4aC/U95y3fRjs/Qu67PPL3gShUE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TZdWIG3X1ZagoqsS+Rix4EnTCpejtj31cGwNPydXGE1u5B+2wN8off4tbo2YftZdGPbhfbh015wTV+lfOnAD2haQNoKYc7SkKsvfqLKf66/2509zxHWZHztHqvbXmpy+/9w6IISJxELcAhcg5lJ8SeD0BN9PHEKgvO290baLrPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Dn8L3TNZ; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dn8L3TNZ" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-70af4868d3dso4283512b3a.3 for ; Tue, 16 Jul 2024 08:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721143012; x=1721747812; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q+oBquCC6Yqm7bL0Kr3aJX57Dgk/RB3bFu+I79pPnBY=; b=Dn8L3TNZ+4GGHpZzyY6vTKGmsQrmp6593yYDWGI+s/3GXs4bR/n9muz4eFXLl4OtJZ SbX5ID/EbzALM0A5dWt1+faK8GtoKVEoZ5D88z1p/G6b6alCgKeVc3EdMy20SHW/kBmH K6yG2wkNVcQmB3vWAR4H+wANKzc7agRoRQvB2lxkPdX8bUA28b3bRS9cq/rR2XT2Bhb8 cWSDvQqxS4Za8Az0kMSNlEISoW8C21H3egfBB2l4SjDoC3BcWn2lX+OO46L+cNLqWEp+ abL3BKZXG85hzW71VgUZdKk6CvCOKDNdj355ZYA4wqudoHychEdMtCD3Iu+vRBW2KHFt 2Ksw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721143012; x=1721747812; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q+oBquCC6Yqm7bL0Kr3aJX57Dgk/RB3bFu+I79pPnBY=; b=Zu6znxaWWqsDEMzyYG5QYqc25ZEgJhKIY/8Yr8RoZ1CE+WV2mXZ1qiNDxjnev0YRpi iPy0hIr+DZfMMB+rKa6ALIP5YzBaNFkgSTqw4nfgVH62nJPtYjVIEbuTgwZbAU5Ickyh h49jT6i1ipdGtCHlEHsxK5f2Q/6Z7ANkC8faGf8+cSZtN9Bek1YnS0myQ67jmS00Au0T ghv/66kLt/bqiPxj/9CjrrX/PTsZZxwkwPM9HhKwBGvCxe6tevzc0STycXKIcnA7wiWR 5ucW5AS39DQMRW2wc2ZUz/uI1PL/cDtz1xTIpa6mlRq9h8M9IQ2tFrjkplbaek5eWBNg VeWA== X-Forwarded-Encrypted: i=1; AJvYcCUyVP6GoPmRKlR/oFaAuXDLzeGKVkdGkPrb7FbNck35dc/X1wC/+S80FcSYlF+A1CemM8RaZ+nfs8BXHIVlRK3zUj04llILC4A01KastRILeQ== X-Gm-Message-State: AOJu0YwJr7gJRQgnDLjF3C6hXLqlHeSXghFJRmSfDRIJ7UqCBpSRABkP UKLN0NVTY8XtySLSnszNbD6UMjsSf6UyK5q0BqB8Cji9BURGDs4UYEd8KXqLG84= X-Google-Smtp-Source: AGHT+IHK38fZflwQZj+0YBMxhcUoqsY5qUO9G0uXW0RmTRimetE4YldMaHWfupwsPvdp5aX1P8Rc/w== X-Received: by 2002:a05:6a00:238c:b0:6ec:f2e7:21a8 with SMTP id d2e1a72fcca58-70c2e9942e1mr3475412b3a.21.1721143011828; Tue, 16 Jul 2024 08:16:51 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:5d01:167d:9cf4:148e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b7ec7da19sm6413009b3a.133.2024.07.16.08.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 08:16:51 -0700 (PDT) Date: Tue, 16 Jul 2024 09:16:48 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" , marex@denx.de, iuliana.prodan@nxp.com, daniel.baluta@nxp.com Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Terry Lv Subject: Re: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M Message-ID: References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> <20240712-imx_rproc-v1-1-7bcf6732d328@nxp.com> Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712-imx_rproc-v1-1-7bcf6732d328@nxp.com> Good morning, On Fri, Jul 12, 2024 at 04:34:54PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The DDR Alias address should be 0x40000000 according to RM, so correct > it. > > Fixes: 4ab8f9607aad ("remoteproc: imx_rproc: support i.MX8MQ/M") This commit was merged more than 3 years ago... I don't see how such a blatant mistake could have survived this long without causing problems or being noticed. On top of things checkpatch gives me a warning. > Reported-by: Terry Lv > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 144c8e9a642e..3c8b64db8823 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -210,7 +210,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { > /* QSPI Code - alias */ > { 0x08000000, 0x08000000, 0x08000000, 0 }, > /* DDR (Code) - alias */ > - { 0x10000000, 0x80000000, 0x0FFE0000, 0 }, > + { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, Without access to HW or the documentation there is no way for me to assess the validity of this patch. Marek, Iuliana and Daniel - please review and test this patch. Thanks, Mathieu > /* TCML */ > { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM}, > /* TCMU */ > > -- > 2.37.1 >