From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC40193087 for ; Mon, 26 Aug 2024 15:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724686317; cv=none; b=pnGX7i7zdhIv9T8TjthLilOmZOh9csnEe088c3N7T1ieZfWFNizsWjrgT1pbYPx1OFVEKRGrU33klkzn2jxM8ohJ/2EnXBUrQxpu0JKgWROBumkyxjgMMH0I3QB7/7Lc3WRxEyIPRdCXxSEKNkQpPL5ZOxZXWiS5LapFJ1SXakU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724686317; c=relaxed/simple; bh=MOKUuEvekK5rwgwZYlRZvsdCZfLN6nGaulZIK0yONvU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kLMD7cqtFf4fZ6TNDNMDEBEu0KaOPm/s7+Ml/M1w7zM2m4tc1IcskNtfyjI+o/DLn8Nf1WPRCQPdpxX+IV47Oq5eHtSyB9Ste4KMnK1ckx2ye7f+3BTFPqMi9cNN+HqKKVxQuKnb8pxCOE4sCf2HqzgmDXe7y+MObV99b0qjsqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N79ijhlW; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N79ijhlW" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2d3b5f2f621so3149484a91.1 for ; Mon, 26 Aug 2024 08:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724686315; x=1725291115; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b5++6viK3zYZWJbNYQZb73hz3jjchrb/vDCmq+vJ2U4=; b=N79ijhlWCv4XyQ5b8I+gmEjcSBg5ydEI0KbnvR4vHiwrTlexBpCv7PkoB6KxcTHYEJ 3Xp48uuA3mbGbW/C8UkOpFVbMbywkKsmNmZlHjy0jZZiP66NEk+4+82mMXLXaLokwaQH 59EQcQ1yAQpqyyxTBPKOIEKc6VLNlgfxkJ7zfLC7mdD0OWwFoVd+ceHbyGMfoyKKZrEX 2kCbCkhlIG5FozqY+G7KGLWlnXz9fG1gR3BE9tc03B8273eB8jEYLIadl0wGs+mWHetG one71n2TzysZPZcuZo5ByhxxXX6wFMsRYERDpuJSJPXjQCpKWaSZwGGiDI/0r9khyVLe 3Vqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724686315; x=1725291115; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b5++6viK3zYZWJbNYQZb73hz3jjchrb/vDCmq+vJ2U4=; b=S/RSKwtWZdBvXvFdtMZbVSGB14wrw21naDh7I+y6jsTKpQqI8HpOi8B3scpk1amA9u 3gGCaUR1gno1YS3HIcFmSSgWwTbL6DXT4sjL7qjoMisJa4w2sPi8ehbFeXJ9xV8uyeaz v1idi6b/TbphQMBme5h8aexvtzDDB+i1MZKB7tt4lEQcPH5ppmZp9AAldPmKDCgF1SMQ bPqVogyS5KU/GDLRMLe4OxOwoykq6f1DoyjJt5zQmJuq2rKuG7J8KkEvyu9p2BJJdkqi lO4Yq9Gk6rRpxULepdAjjI1MxMt077BZa4uh5AKQVw52sL3/9PwzRWLQ3eh585wUkg6k KCIg== X-Forwarded-Encrypted: i=1; AJvYcCUk1/UI4YhwqpCBvQ4gtADpQ01NqhlG8Z8elPKuFM5mv1isQaE2IMkukLtzYnRG8LdtdPiiJHBESZxYCTKzJuV1@vger.kernel.org X-Gm-Message-State: AOJu0YxRJ7nFU+scEVP7IOIWUvXRjZUH6Lcih4ua4KhzVOkTrQbjPtWo FkEf39Zb0slE5a2xMUMgjhGDH4ZtOej2HCa/bxenK3xXcz7ERcPW4XVtxauZoTE= X-Google-Smtp-Source: AGHT+IFat5E7ycTJSdkRmb690GFUDdXL/SJqFXqM0lbjqbfMedPx08c7A4wYVc/U8aWkzS3LORhuZg== X-Received: by 2002:a17:90a:1f88:b0:2d6:1981:bbf7 with SMTP id 98e67ed59e1d1-2d646d2bbd3mr9746593a91.32.1724686315109; Mon, 26 Aug 2024 08:31:55 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:841:3fb0:c1d:cf23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d61968ecc7sm9674318a91.54.2024.08.26.08.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 08:31:54 -0700 (PDT) Date: Mon, 26 Aug 2024 09:31:52 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Daniel Baluta , Iuliana Prodan , Marek Vasut , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v3 0/2] remoteproc: imx_rproc: support non-blocking tx for i.MX7ULP Message-ID: References: <20240822-imx_rproc-v3-0-6d943723945d@nxp.com> Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822-imx_rproc-v3-0-6d943723945d@nxp.com> On Thu, Aug 22, 2024 at 09:48:48PM +0800, Peng Fan (OSS) wrote: > The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The i.MX7ULP Linux > poweroff and restart rely on rpmsg driver to send a message to Cortex-M4 > firmware. Then Cortex-A7 could poweroff or restart by Cortex-M4 to > configure the i.MX7ULP power controller properly. > > However the reboot and restart kernel common code use atomic notifier, > see kernel/reboot.c: do_kernel_power_off, do_kernel_restart. > Linux 'poweroff' cmd will trigger kernel 'do_kernel_power_off' > Linux 'reboot' cmd will trigger kernel 'do_kernel_restart'. > > Power off and restart are totally different operations and are not > complementary. So need to make sure the mailbox be changed to non-blocking > mode in SYS_OFF_MODE_POWER_OFF_PREPARE and SYS_OFF_MODE_RESTART_PREPARE > stage. Otherwise with blocking tx mailbox, there will be kernel dump, > because of blocking mailbox will use wait_for_completion_timeout. In the > poweroff or restart case, there is no need to wait, because after M4 got > the message, M4 will put A7 to reboot or poweroff. > > patch 1 is to support non-blocking tx mailbox channel > patch 2 is to switch to non-blocking tx for system poweroff or restart. > > Signed-off-by: Peng Fan > --- > Changes in v3: > - patch 2: Introduce an flags entry for dcfg and set IMX_RPROC_NEED_SYSTEM_OFF > for i.MX7ULP, drop used "struct sys_off_data data" and add comment(per Frank). > Drop R-b of patch 2 because of this change. > - Patch 1: commit log rewritten and R-b dropped. > (Thanks to Daniel). > - Update patch 2 commit log and cover-letter to clarify reboot and > poweroff are different operations and not complementary > (Thanks to Daniel). > - Link to v2: https://lore.kernel.org/r/20240719-imx_rproc-v2-0-cd8549aa3f1f@nxp.com > > Changes in v2: > - Separated patch 5,6 from v1 > - Update commit patch 1 with adding "No functional changes" > - Link to v1: https://lore.kernel.org/r/20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com > > --- > Peng Fan (2): > remoteproc: imx_rproc: Allow setting of the mailbox transmit mode > remoteproc: imx_rproc: Add support for poweroff and reboot > > drivers/remoteproc/imx_rproc.c | 54 +++++++++++++++++++++++++++++++++++++----- > drivers/remoteproc/imx_rproc.h | 4 ++++ > 2 files changed, 52 insertions(+), 6 deletions(-) I have applied this set. Thanks, Mathieu > --- > base-commit: 33a32de2d79c051f27ed57c4ac90cdb406f91928 > change-id: 20240712-imx_rproc-25f3ab753c58 > > Best regards, > -- > Peng Fan >