From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF1EB192B69 for ; Mon, 30 Sep 2024 16:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727714731; cv=none; b=R8REJBdxMVfNxMjS6UAkT8tlrEgtOc8uZT0pqXwHi0GXnSu6S5sZKP1QsHkj4YkyAShEnfPF7DkLUrk5oCwUtfbgpuw28SmSEjtN5tWtcdCqKp2Ezrb49q9VQXJIaOONaV3cElfY+rQdSjyWrvWREHYFYzdHz2K3LBnA1WT7bRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727714731; c=relaxed/simple; bh=As4xlKeH8pzXDzf4olvO/gak593BaigkLPoloN50dV0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XlIxTeuz1Pmo7Ub2vHzIzFVkLK+sX18SmD6z9mjBEmsyf/rUVpSzTkluxAtdfFvSAe9/nBd/AYbBJ1/xtuao3k6n+g0jPEa2wjfpXKRIeM6eLr7RcZ5lWAUBrn8TSU3iIWkhBW6nPU8GsS3oQCKW7569tocJzzzajfbVl61Npo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=o4h7QNFk; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o4h7QNFk" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-7e6cbf6cd1dso3116178a12.3 for ; Mon, 30 Sep 2024 09:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727714729; x=1728319529; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SvcxQTQeQJCxAAgL5ZNrVRQRYKFeNgf1iUtSk1J+SBQ=; b=o4h7QNFkYYbFrYyv0R4IXHYUG/90ykN7mh4lrr1eEeCT70W94WyCqAO1wRZr9wAX2D F9xu9ybZdZs1I5zgvKrPxmKGAsYwzhPEOjOQ5N/lqTa22w6XD6npn1YgrZRN/imTzzUg 5ATHy0zX9wq9VDuA1FJ2cy7UyWEOHqhC33mXQi5dUbv0s4+qmY6GpC99lhwzCZO7TPLU vdiwc6HtIy1lOIchzrzj/jhChkCh28kfcON8pMhuqIYEW6lhBsFvl9BkMI2RtBK+yq8M SQbc+7ClStHEQAxbP1QaovXk7AYZS9TjgprxqJClWC2EORMhfvOUNjCiuCfo7h1ewsnv tqaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727714729; x=1728319529; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SvcxQTQeQJCxAAgL5ZNrVRQRYKFeNgf1iUtSk1J+SBQ=; b=SY7plTiEdyH69sAkS9TeQNBdqUCZQcj7Rt0bw//bEF4KWnU4TXjoSY4hL4XPCnLJuH PgIUDAdfkXypX5joU83DpaT/r7jFTB4r+QgzKZtqOjWNpslPR0G0EUixJAmi4HEi7+CE L1mbGzEetp/mZ1nP/qJNGKTra2JvNvi2HqxUr8LA5rjAO1z8nVypJd3D0dcgal4p5rxh vn5C4TXgFJS8gal1wUP5B0IPZzxsXGS8G6rl0JCXecP8ec8jVMnF4ek3Nps94WITzoJK MB1TanSRKol2V15CNFf/cK6iZ71Yk89EZXrWpvciY3y9HMvbEia3yanrnfmjo/9nDLnW rq9Q== X-Gm-Message-State: AOJu0YxK+/6+vz4re5vShN7PVvZPo0HttUsJbAhy3fJKp61L0P4Uf3FV aegQLny+3GjLPpuWIUPcih5A5jkFh3U/NNzfr6gjx9EbMEcDVQ3hh6EruGjMztk= X-Google-Smtp-Source: AGHT+IFZCWfdQrwy49Ce5W9jR5Wa05yMjvNskGuw5IOlhsx0iH8HMju8vYH03I+79lPN0n/TIp3wDQ== X-Received: by 2002:a05:6a20:3b19:b0:1cf:53ea:7fbc with SMTP id adf61e73a8af0-1d4fa6a1496mr13517438637.18.1727714729181; Mon, 30 Sep 2024 09:45:29 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:6561:7ef:acea:822e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b2649ae1fsm6412216b3a.8.2024.09.30.09.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 09:45:28 -0700 (PDT) Date: Mon, 30 Sep 2024 10:45:26 -0600 From: Mathieu Poirier To: Markus Elfring Cc: linux-remoteproc@vger.kernel.org, Andrew Davis , Bjorn Andersson , Hari Nagalla , Martyn Welch , Suman Anna , Wadim Egorov , LKML , kernel-janitors@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH] remoteproc: k3: Call of_node_put(rmem_np) only once in three functions Message-ID: References: Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 24, 2024 at 02:43:40PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 24 Sep 2024 14:28:35 +0200 > > An of_node_put(rmem_np) call was immediately used after a pointer check > for a of_reserved_mem_lookup() call in three function implementations. > Thus call such a function only once instead directly before the checks. > > This issue was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/remoteproc/ti_k3_dsp_remoteproc.c | 6 ++---- > drivers/remoteproc/ti_k3_m4_remoteproc.c | 6 ++---- > drivers/remoteproc/ti_k3_r5_remoteproc.c | 3 +-- > 3 files changed, 5 insertions(+), 10 deletions(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c > index 8be3f631c192..d08a3a98ada1 100644 > --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c > +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c > @@ -576,11 +576,9 @@ static int k3_dsp_reserved_mem_init(struct k3_dsp_rproc *kproc) > return -EINVAL; > > rmem = of_reserved_mem_lookup(rmem_np); > - if (!rmem) { > - of_node_put(rmem_np); > - return -EINVAL; > - } > of_node_put(rmem_np); > + if (!rmem) > + return -EINVAL; > > kproc->rmem[i].bus_addr = rmem->base; > /* 64-bit address regions currently not supported */ > diff --git a/drivers/remoteproc/ti_k3_m4_remoteproc.c b/drivers/remoteproc/ti_k3_m4_remoteproc.c > index 09f0484a90e1..a16fb165fced 100644 > --- a/drivers/remoteproc/ti_k3_m4_remoteproc.c > +++ b/drivers/remoteproc/ti_k3_m4_remoteproc.c > @@ -433,11 +433,9 @@ static int k3_m4_reserved_mem_init(struct k3_m4_rproc *kproc) > return -EINVAL; > > rmem = of_reserved_mem_lookup(rmem_np); > - if (!rmem) { > - of_node_put(rmem_np); > - return -EINVAL; > - } > of_node_put(rmem_np); > + if (!rmem) > + return -EINVAL; > > kproc->rmem[i].bus_addr = rmem->base; > /* 64-bit address regions currently not supported */ > diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c > index 747ee467da88..d0ebdd5cfa70 100644 > --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c > +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c > @@ -1001,12 +1001,11 @@ static int k3_r5_reserved_mem_init(struct k3_r5_rproc *kproc) > } > > rmem = of_reserved_mem_lookup(rmem_np); > + of_node_put(rmem_np); > if (!rmem) { > - of_node_put(rmem_np); > ret = -EINVAL; > goto unmap_rmem; > } > - of_node_put(rmem_np); > > kproc->rmem[i].bus_addr = rmem->base; > /* > -- > 2.46.1 >