From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v2 0/5] SC8280XP SLPI
Date: Mon, 19 May 2025 11:35:15 +0200 [thread overview]
Message-ID: <aCr7UzmK7XCjpsOx@hovoldconsulting.com> (raw)
In-Reply-To: <20250517-topic-8280_slpi-v2-0-1f96f86ac3ae@oss.qualcomm.com>
On Sat, May 17, 2025 at 07:27:49PM +0200, Konrad Dybcio wrote:
> SC8280XP features a SLPI, much like its distant relative, SM8350.
Please get into the habit of spelling out *and* explaining internal
Qualcomm acronyms like "SLPI" so that your cover letter and commit
messages makes sense to people outside of Qualcomm.
Also say something about whether and how this is useful for anyone
currently or if it, for example, depends on Qualcomm proprietary user
space bits.
> Dmitry Baryshkov (1):
> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: enable sensors DSP
At first I was worried that missing firmware could cause issues here
(e.g. drivers not reaching sync state as with venus), but Lenovo has
indeed released the SLPI firmware already.
Are there any other potential downsides to enabling this (e.g. before
anyone can actually use the sensors)?
> Konrad Dybcio (4):
> dt-bindings: remoteproc: qcom,sm8350-pas: Add SC8280XP
> arm64: dts: qcom: sc8280xp: Fix node order
> arm64: dts: qcom: sc8280xp: Add SLPI
> arm64: dts: qcom: sc8280xp-crd: Enable SLPI
Without firmware this results in errors like:
remoteproc remoteproc0: slpi is available
remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2
remoteproc remoteproc0: powering up slpi
remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2
remoteproc remoteproc0: request_firmware failed: -2
but enabling for the CRD reference design and requiring users (read:
developers) to copy it from Windows should be OK.
Johan
next prev parent reply other threads:[~2025-05-19 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 17:27 [PATCH v2 0/5] SC8280XP SLPI Konrad Dybcio
2025-05-17 17:27 ` [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sm8350-pas: Add SC8280XP Konrad Dybcio
2025-05-17 17:27 ` [PATCH v2 2/5] arm64: dts: qcom: sc8280xp: Fix node order Konrad Dybcio
2025-05-18 10:58 ` Dmitry Baryshkov
2025-05-17 17:27 ` [PATCH v2 3/5] arm64: dts: qcom: sc8280xp: Add SLPI Konrad Dybcio
2025-05-18 10:58 ` Dmitry Baryshkov
2025-05-17 17:27 ` [PATCH v2 4/5] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: enable sensors DSP Konrad Dybcio
2025-05-17 17:27 ` [PATCH v2 5/5] arm64: dts: qcom: sc8280xp-crd: Enable SLPI Konrad Dybcio
2025-05-18 10:58 ` Dmitry Baryshkov
2025-05-19 9:35 ` Johan Hovold [this message]
2025-05-20 14:29 ` [PATCH v2 0/5] SC8280XP SLPI Konrad Dybcio
2025-05-20 14:45 ` Dmitry Baryshkov
2025-05-21 7:11 ` Johan Hovold
2025-05-20 2:14 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCr7UzmK7XCjpsOx@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marijn.suijten@somainline.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox