From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4359F3043B7 for ; Fri, 29 Aug 2025 16:11:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756483906; cv=none; b=O+Ic5lpwjQsUCzp9xb7B5czEZ8e+Q1dEkLqE7sRhTomieN4N+dxKJEO4jDNP8nadL+DNZjKvyn+UAFkfYQT7zeLPcQG6ogd4q4YPJvX0FuGrIPa3taFAquspfbuH8KdX64XuYX9K1YViOWXiOLN93vr8q6dQFX9AUJuTi3jPSs0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756483906; c=relaxed/simple; bh=tTY7r03wgO+Jv1B5lRquX6wrCUgO7uUzlezmCJKhxgs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n6mS8+NM88x8yyC1X0gHLK4CLg3z3J9H/Fby1q631zaCcun/yGdeWc+Dmn6yYX5hJ/cKt2FIyTu7hc9XMp88kI2xThfhTzZCoJp8r4nLgtqHn4ZbHpiYrURbbYP4SyeFA+9hLeB9E3h1KXFoKmfyFOMutgRcrj+n75EnvhHlAXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ucw/A11k; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ucw/A11k" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-770530175b2so1825499b3a.3 for ; Fri, 29 Aug 2025 09:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756483902; x=1757088702; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GdG4ZBE60MQo9skvlcwc2CKeFpgl13LiTrzShDv9gcU=; b=ucw/A11ksrS5Bo670qiQMnOJnukH+sukEvnAuamReEq9kWPwd6UKcH77wl9Z91jyKd JU5174fT5Bo7eTce5vbraIhHg7PLPT0BTO8oo1PQMQ7KOlmdu1DFYdAZsuNRKSsz0a1k C1CO2XwULkgtW6t0wBuKOkBcW32O7RjqrTwKXfzchK1+wS5VMkP8v9mpZjvH8KT1ks+F kjKvqjolYib0VOVa+KbfwFUkNt1Y+UrOrVTprxftvWBzGT7F7vVNSvLo8FCkjSicGPmm fm9o/9SC1F7hYLnQm3ZUllRr3j46kv4uQDoyzR093AOj8rJVh6EN3qwhuSH/a1cBIPrY dy8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756483902; x=1757088702; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GdG4ZBE60MQo9skvlcwc2CKeFpgl13LiTrzShDv9gcU=; b=Y0H91jvudC7ccvGZ1NURKmAFazxrDjXdDhzLGTRU23R6nsOdq1Fpj057glqS1ay3PZ z3P/Gs1CDfL1Vhlb6YMLeCB+HvclSYTx/Vd/jSqXk2j3T0zg+JjEuCgpv9dbnpCwsZmW 6IPBkOqtO4z0/nWCxt9GEpsmq5B/l5XlWHp70WOCLSxkDh9JzXROAIspW1o6gk1Kfzm5 Sc9SPahXOPimTNs7MTjZHiLPjbYanKPcMEO2IcTskBlCLQOUt0WY5UrTaapXfr74Pvr4 TnbVh0qAoI7iX7otYYR7qe5iev7mLO6Z3SVB4O/viuok7oXrRWnZdbsBXjOrDCcrRKN0 pm8w== X-Forwarded-Encrypted: i=1; AJvYcCU+luZFt0H5MkOaLhIRAE0/VlXXFcGkr/T2xDNWrurn0UufC3iCNAZIfbD/iRMsOm8F9KOVSfgSqbO53Rlw8gqn@vger.kernel.org X-Gm-Message-State: AOJu0Yx//CXvxmq8B7+cougYQDbf3odbpNKUaHOW6wZ66w7Bf8lNc2K/ HmXQsfX4nOl8latgFNcH033HQXJqP5P6rz09zqBwKKsYmBm2HEzVr2IM3/aMECnqGpM= X-Gm-Gg: ASbGncu4o8QCYf8+jt9JhK92dFxURhUXUZkiTlgfIHJi7cTh1w5qYkOLlDtAMaPrUZn +SZBVkQo0V5wMJy9dC2R6/ybF//ykk8w1uqGpjbEiM0f6gWH8KJFE/G2cX+0TXQfpKrzWJwCEFm kug9rroqvhF3haTR6LYTGfG/k0/kCZB1l+BEIQBfnGGzhkaemrnQbxAZ2B5zYfqQhSfquOpVrqY 7T7z9ydH8ps5p2CSEwKPio8sXP7AlOwOtMb1LXNFCL+kCRlFXW18GFpckQXENU4T3nNbQvTjoqW xpCH/om5U54BZtyJT1aFvmyznQcPdxjbfMD32Lp0USsejrc9wTb2mHbWRFOIXuh5Xw+64phqE62 aKa71U3eOf6Gi0RXYiW9fZANAANKSIVhsrlmxwNh+NA/+KMzSCCxYccmrMQxocWIkJGSvulJNJP 9+ZsNmIKPP6RYWenEnTOuWDcYDmCIuH1F6v6I= X-Google-Smtp-Source: AGHT+IG0BijOfS1syDO9r7bmXPHtEUUgTx65TwjuioQwopzbTILdFIw8bOkcRYbE5nIUD3sncpBFew== X-Received: by 2002:a05:6a00:a28:b0:772:2e00:831f with SMTP id d2e1a72fcca58-7722e00b9b5mr4167788b3a.4.1756483902507; Fri, 29 Aug 2025 09:11:42 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:c8f8:92f5:116b:3068]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7722a26ae02sm2755442b3a.21.2025.08.29.09.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 09:11:42 -0700 (PDT) Date: Fri, 29 Aug 2025 10:11:39 -0600 From: Mathieu Poirier To: Christophe JAILLET Cc: Bjorn Andersson , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Beleswar Padhi , linux-remoteproc@vger.kernel.org Subject: Re: [PATCH v5] remoteproc: k3: Correctly release some resources allocated in k3_rproc_request_mbox() Message-ID: References: Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Aug 24, 2025 at 09:52:37PM +0200, Christophe JAILLET wrote: > If an error occurs after a successful k3_rproc_request_mbox() call, > mbox_free_channel() should be called to avoid a leak. > > Such a call is missing in the error handling path of k3_dsp_rproc_probe(). > It is also missing both in the error handling path of k3_m4_rproc_probe() > and in the (in-existent) corresponding remove function. > > Switch to managed resources to avoid these leaks and simplify the code. > Remove the now unneeded mbox_free_channel(). > > Signed-off-by: Christophe JAILLET > Reviewed-by: Beleswar Padhi > Tested-by: Beleswar Padhi > --- Appied. Thanks, Mathieu > Compile tested only. > > Changes in v5: > - Update subject line [Beleswar Prasad Padhi] > - Add R-b and T-b tags > - Rebase with latest -next (especially, because of commit f9a4c582e508 > ("remoteproc: k3: Remove remote processor mailbox ping)) > > v4: https://lore.kernel.org/all/f96befca61e7a819c0e955e4ebe40dc8a481619d.1751060507.git.christophe.jaillet@wanadoo.fr/ > > Previous versions: > https://lore.kernel.org/all/591e219df99da6f02c9d402f7854bc3ab23e76f9.1726328417.git.christophe.jaillet@wanadoo.fr/ > --- > drivers/remoteproc/ti_k3_common.c | 12 ++++++++++++ > drivers/remoteproc/ti_k3_dsp_remoteproc.c | 2 -- > drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 -- > 3 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/ti_k3_common.c b/drivers/remoteproc/ti_k3_common.c > index 8266e11914af..56b71652e449 100644 > --- a/drivers/remoteproc/ti_k3_common.c > +++ b/drivers/remoteproc/ti_k3_common.c > @@ -155,11 +155,19 @@ int k3_rproc_release(struct k3_rproc *kproc) > } > EXPORT_SYMBOL_GPL(k3_rproc_release); > > +static void k3_rproc_free_channel(void *data) > +{ > + struct k3_rproc *kproc = data; > + > + mbox_free_channel(kproc->mbox); > +} > + > int k3_rproc_request_mbox(struct rproc *rproc) > { > struct k3_rproc *kproc = rproc->priv; > struct mbox_client *client = &kproc->client; > struct device *dev = kproc->dev; > + int ret; > > client->dev = dev; > client->tx_done = NULL; > @@ -172,6 +180,10 @@ int k3_rproc_request_mbox(struct rproc *rproc) > return dev_err_probe(dev, PTR_ERR(kproc->mbox), > "mbox_request_channel failed\n"); > > + ret = devm_add_action_or_reset(dev, k3_rproc_free_channel, kproc); > + if (ret) > + return ret; > + > return 0; > } > EXPORT_SYMBOL_GPL(k3_rproc_request_mbox); > diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c > index 7a72933bd403..d6ceea6dc920 100644 > --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c > +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c > @@ -175,8 +175,6 @@ static void k3_dsp_rproc_remove(struct platform_device *pdev) > if (ret) > dev_err(dev, "failed to detach proc (%pe)\n", ERR_PTR(ret)); > } > - > - mbox_free_channel(kproc->mbox); > } > > static const struct k3_rproc_mem_data c66_mems[] = { > diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c > index ca5ff280d2dc..04f23295ffc1 100644 > --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c > +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c > @@ -1206,8 +1206,6 @@ static void k3_r5_cluster_rproc_exit(void *data) > return; > } > } > - > - mbox_free_channel(kproc->mbox); > } > } > > -- > 2.51.0 >