From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dawei Li <dawei.li@linux.dev>
Cc: linux-remoteproc@vger.kernel.org
Subject: [bug report] rpmsg: char: Implement eptdev based on anonymous inode
Date: Wed, 22 Oct 2025 14:05:36 +0300 [thread overview]
Message-ID: <aPi6gPZE2_ztOjIW@stanley.mountain> (raw)
Hello Dawei Li,
Commit 2410558f5f11 ("rpmsg: char: Implement eptdev based on
anonymous inode") from Oct 15, 2025 (linux-next), leads to the
following Smatch static checker warning:
drivers/rpmsg/rpmsg_char.c:548 rpmsg_anonymous_eptdev_create()
error: dereferencing freed memory 'eptdev' (line 546)
drivers/rpmsg/rpmsg_char.c
538 /* Anonymous inode only supports these file flags */
539 if (flags & ~(O_ACCMODE | O_NONBLOCK | O_CLOEXEC))
540 return -EINVAL;
541
542 eptdev = rpmsg_eptdev_alloc(rpdev, parent, false);
543 if (IS_ERR(eptdev))
544 return PTR_ERR(eptdev);
545
546 ret = rpmsg_eptdev_add(eptdev, chinfo, false);
547 if (ret) {
--> 548 dev_err(&eptdev->dev, "failed to add %s\n", eptdev->chinfo.name);
^^^^^^ ^^^^^^
The rpmsg_eptdev_add() function frees "eptdev" on error.
549 return ret;
550 }
551
552 fd = anon_inode_getfd("rpmsg-eptdev", &rpmsg_anonymous_eptdev_fops, eptdev, flags);
553 if (fd < 0) {
554 put_device(&eptdev->dev);
555 return fd;
556 }
557
558 mutex_lock(&eptdev->ept_lock);
559 ret = __rpmsg_eptdev_open(eptdev);
Should we free eptdev if __rpmsg_eptdev_open() fails?
560 mutex_unlock(&eptdev->ept_lock);
561
562 if (!ret)
563 *pfd = fd;
564
565 return ret;
566 }
regards,
dan carpenter
next reply other threads:[~2025-10-22 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 11:05 Dan Carpenter [this message]
2025-10-22 15:53 ` [bug report] rpmsg: char: Implement eptdev based on anonymous inode Dawei Li
2025-10-22 16:41 ` Mathieu Poirier
2025-11-10 17:05 ` Mathieu Poirier
2025-11-11 12:53 ` Dawei Li
2025-11-11 16:41 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPi6gPZE2_ztOjIW@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dawei.li@linux.dev \
--cc=linux-remoteproc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox