public inbox for linux-remoteproc@vger.kernel.org
 help / color / mirror / Atom feed
* [bug report] remoteproc: qcom_wcnss: Fix reserved region mapping failure
@ 2026-04-10 10:14 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2026-04-10 10:14 UTC (permalink / raw)
  To: Rob Herring; +Cc: linux-remoteproc

Hello Rob Herring (Arm),

Commit f9b888599418 ("remoteproc: qcom_wcnss: Fix reserved region
mapping failure") from Jan 28, 2026 (linux-next), leads to the
following Smatch static checker warning:

	drivers/remoteproc/qcom_wcnss.c:541 wcnss_alloc_memory_region()
	warn: 'wcnss->mem_region' is not an error pointer

drivers/remoteproc/qcom_wcnss.c
    527 static int wcnss_alloc_memory_region(struct qcom_wcnss *wcnss)
    528 {
    529         struct resource res;
    530         int ret;
    531 
    532         ret = of_reserved_mem_region_to_resource(wcnss->dev->of_node, 0, &res);
    533         if (ret) {
    534                 dev_err(wcnss->dev, "unable to resolve memory-region\n");
    535                 return ret;
    536         }
    537 
    538         wcnss->mem_phys = wcnss->mem_reloc = res.start;
    539         wcnss->mem_size = resource_size(&res);
    540         wcnss->mem_region = devm_ioremap_wc(wcnss->dev, wcnss->mem_phys, wcnss->mem_size);
--> 541         if (IS_ERR(wcnss->mem_region)) {
                    ^^^^^^^^^^^^^^^^^^^^^^^^
We changed from devm_ioremap_resource_wc() to devm_ioremap_wc() so the
error handling needs to be change back to a NULL check.

    542                 dev_err(wcnss->dev, "unable to map memory region: %pR\n", &res);
    543                 return PTR_ERR(wcnss->mem_region);
    544         }
    545 
    546         return 0;
    547 }

This email is a free service from the Smatch-CI project [smatch.sf.net].

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-04-10 10:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-10 10:14 [bug report] remoteproc: qcom_wcnss: Fix reserved region mapping failure Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox