Re: [PATCH v3 3/9] remoteproc: qcom_q6v5_mss: Add MDM9607

Bryan O'Donoghue
2026-01-02T13:00:36Z

On 02/01/2026 12:00, Konrad Dybcio wrote:
> Now I don't like that this driver is going
>
> val |= BIT(i);
> writel(val, foo);
> // val is "altered" but not really
> val |= readl(foo);
>
> I didn't notice we were just doing a readback for the sake of a readback
> in the last revision. MDM9607 should most definitely have it too..
> Perhaps I should have just read the comment

Yeah this just looks dodgy and inconsistent in this code.

And anyway, why OR those bits in...

---
bod