From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12A834343F5 for ; Wed, 8 Jul 2026 17:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783530481; cv=none; b=Bf3qYL1xk6RqXnkQ/VooxatfeImDTsc6PNsf+5EVfdlpHvfVJgppB17w7QfIzUNx0qfRzi0brf9kZRXiZRBbsI+3XmWG0Mwb34ZjAyCfiZ6fjQjsmlDbrrv9t/cltKna1H1g/RoYNiekpYXJxVjwaYZ48+V5H+SaZwMyV9G5znA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783530481; c=relaxed/simple; bh=Okun8PgF7PUdESpTukMLPfo/8mr/wu4lK2Kd+zVCkCk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XB433E77iawv4QrmTi3sxPc4bHczOzOZa+h3htTDPN56kJfDVbY2q474RagW3yfH0p9dnf6DYrF1eDL0ApfOkOCaeVgGJgyhODcBAUOfOjbmy9r7+n22mGSE4l5VS4aCsuPpk2aIxIEgpOSFFNGeZc3cxkfwgm+Cbo+0ooz0qNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N91GAFJT; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N91GAFJT" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-383cb94f742so848009a91.3 for ; Wed, 08 Jul 2026 10:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783530476; x=1784135276; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7wFTXwb6Z1kkFm2K1NVbhztTCfF3worZxBUKjCMRONY=; b=N91GAFJTo3Hlksu450DpqF01E3fLxMFEFcITn1lwSAzLecXwqB+QMeAQFMOpH0IZJM cxTFFRUQosIdgifTKPPtliig/XFu1XErwCrYFLsPbkyZd4bpeOWw5e8VKGpq1rfzJsQ9 NwltAFFXQxR4UYG7ajOkqb9MQQicvs9+K6vGQCK09Sj+VOx2lCnlOaj+3EbDZAzDWdHy nnxeBfycRTd7aY3GEl39Sjr7BnIIiHk3YTVkNiczvv8g+ilvjBl+M3G77oqaOETQZk8L CiW79kRzKMBFzcQd9+shfG51P0gWwjZS9ci1Mrp3kysYUhdCytfVa5k3AvMBmtBptQCv ZvXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783530476; x=1784135276; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7wFTXwb6Z1kkFm2K1NVbhztTCfF3worZxBUKjCMRONY=; b=YtskWXPdMatuBB2LW2xxxmd+QD5xUrty5nLJXdT97AMZPRjI+KYQhSamAMO3dCjvO8 VrbxVW3AWBS/HdT++ZUipUKUWEOJiynKUPI+IGE1SzsWLZJrR/2TTQUbB76fGgxtiwXM kcykuAR93GVD+N0YX+q+34MPAUzCzYQ9AjTKJC1XtuKSAgBAnKdqVU0/9T2im8tmu0XH pFsANNZlLC2xUx9x1c6dzAYG3bcDNVth7v5ypqWoGSdckbE+tfirgKf9KofX3n6qPVVQ ekxczn3LcGEEb9h/GjWX5YdGKcgGpUSwtv9/BQXWXPASyADNXIaQ2qcwepRPgJcp6Dih uBRg== X-Forwarded-Encrypted: i=1; AHgh+RqnPHQ2nmdtOb4mZ8/pkeaXBEWGU5CUCyw4N7NGB+1r81NNfeTaf9NzIRNwD99c9V8htDbaTNRLT0KNkKr+MOpz@vger.kernel.org X-Gm-Message-State: AOJu0Yx+LtTXfTJJh+vtcLhWdu23+H1hP6UJZVie8FeBVAR1q6CpgEyS K5CyO5jRfqryk1DNvFIh0lRrVADW7rQ+3qP+pPaDH1jIut1YFXQjRGDanTAu2/UHjLY= X-Gm-Gg: AfdE7clavn0sGR42Uf8tKcrZzPUQDBJc+0wj7S2l6wNy3YCjpnXBXg0iJ0y4HOYk6xV Ls4BTS9+DtfHKkTWOr28jFjOeEGcfdB4NFm7bCsJoEIBjTn0GLez+cUkxKIOjadTrP67LB54XIX slSovGZj8IjfkUdhpynb+8Ynd8MJW5JzbTCKFNZevHPMn4pW2NAxGAkO/Ot4a2NENR+UwXmgyGn aPlgHl6H+VfpZHPwm45mG421lN4wPxa7J55dOqX+N73rZ2HsSUwWGQCJrI3Q/FULdhqTbuQxp87 aDxgt9EcoTA2gSRZJWKA78tFHtG4nD8hCzQCNLRJ7pnU6XFGK12w3eZKqM4KdiYi1ukDefhQ2FZ UsbTVXClG1WnwrVrwX4VKgyGrdWm2xbb+kSxlnRdWk9K7xM4fj2H3stsfSaYBLWQoMA55l+U2qB Y/awbL1PGI87iRnEzd X-Received: by 2002:a17:90a:d88f:b0:37f:ef32:d444 with SMTP id 98e67ed59e1d1-3893fe5bb10mr3499928a91.1.1783530475481; Wed, 08 Jul 2026 10:07:55 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:da71:a4fe:1ac2:9750]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-388fdaa2c73sm1084089a91.1.2026.07.08.10.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 10:07:54 -0700 (PDT) Date: Wed, 8 Jul 2026 11:07:52 -0600 From: Mathieu Poirier To: Johan Hovold Cc: Bjorn Andersson , Matthias Brugger , AngeloGioacchino Del Regno , Guangshuo Li , linux-remoteproc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Erin Lo Subject: Re: [PATCH] remoteproc: scp: fix device reference leak on failed lookup Message-ID: References: <20260706065614.389412-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706065614.389412-1-johan@kernel.org> On Mon, Jul 06, 2026 at 08:56:14AM +0200, Johan Hovold wrote: > Make sure to drop the reference taken to the SCP device when attempting > to look up its driver data before the driver has been bound. > > Note that holding a reference to a device does not prevent its driver > data from going away. > > Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183") > Cc: stable@vger.kernel.org # 5.6 > Cc: Erin Lo > Signed-off-by: Johan Hovold > --- > drivers/remoteproc/mtk_scp.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 85a74c9ec521..436656bdfa8b 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -36,6 +36,7 @@ struct mtk_scp *scp_get(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct device_node *scp_node; > struct platform_device *scp_pdev; > + struct mtk_scp *scp; > > scp_node = of_parse_phandle(dev->of_node, "mediatek,scp", 0); > if (!scp_node) { > @@ -51,7 +52,13 @@ struct mtk_scp *scp_get(struct platform_device *pdev) > return NULL; > } > > - return platform_get_drvdata(scp_pdev); > + scp = platform_get_drvdata(scp_pdev); > + if (!scp) { > + put_device(&scp_pdev->dev); > + return NULL; > + } > + > + return scp; > } > EXPORT_SYMBOL_GPL(scp_get); > > -- > 2.54.0 >