From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
linux-remoteproc@vger.kernel.org,
Baolin Wang <baolin.wang@linux.alibaba.com>
Subject: Re: [PATCH v2 0/4] hwspinlock: add summary in debugfs
Date: Mon, 29 Jun 2026 13:40:24 +0300 [thread overview]
Message-ID: <akJLmLwO8IGu5KbP@ashevche-desk.local> (raw)
In-Reply-To: <akIzahjROM4GAlOR@ninjato>
On Mon, Jun 29, 2026 at 10:57:14AM +0200, Wolfram Sang wrote:
...
> > --- a/drivers/hwspinlock/hwspinlock_core.c
> > +++ b/drivers/hwspinlock/hwspinlock_core.c
> > @@ -16,7 +16,7 @@
> > #include <linux/types.h>
> > #include <linux/err.h>
> > #include <linux/jiffies.h>
> > -#include <linux/radix-tree.h>
> > +#include <linux/xarray.h>
>
> According to some quick grepping, there are 102 users of XArray
> including this header and 423 users which are not including this header.
> Do you think this is a useful improvement to add the header directly
> (per subsystem to keep the number of patches limited)?
My 2c that we should follow the IWYU principle. XArray header is not generic
enough that we may rely on something else to provide it. And hence I'm fully
with including that explicitly. That mentioned users simply neglected the
principle and I consider that as an inconvenience.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-29 10:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 8:51 [PATCH v2 0/4] hwspinlock: add summary in debugfs Wolfram Sang
2026-06-22 8:52 ` [PATCH v2 1/4] radix-tree: add parameter doc for radix_tree_deref_slot_protected() Wolfram Sang
2026-06-22 10:16 ` Andy Shevchenko
2026-06-22 8:52 ` [PATCH v2 2/4] radix-tree: allow more lock types with radix_tree_deref_slot_protected() Wolfram Sang
2026-06-22 10:18 ` Andy Shevchenko
2026-06-22 8:52 ` [PATCH v2 3/4] hwspinlock: annotate slot pointer as RCU sensitive Wolfram Sang
2026-06-22 10:20 ` Andy Shevchenko
2026-06-29 9:07 ` Wolfram Sang
2026-06-22 8:52 ` [PATCH v2 4/4] hwspinlock: add summary in debugfs Wolfram Sang
2026-06-22 10:24 ` Andy Shevchenko
2026-06-22 13:59 ` [PATCH v2 0/4] " Matthew Wilcox
2026-06-22 16:20 ` Wolfram Sang
2026-06-29 8:57 ` Wolfram Sang
2026-06-29 10:40 ` Andy Shevchenko [this message]
2026-06-29 10:55 ` Wolfram Sang
2026-06-29 18:54 ` Matthew Wilcox
2026-07-01 15:07 ` Wolfram Sang
2026-06-29 10:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akJLmLwO8IGu5KbP@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andersson@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=willy@infradead.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox