From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19456283FE5 for ; Fri, 9 Oct 2026 15:11:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791558691; cv=none; b=i7+zYE0fN9ALAsHOx6bkouj+D7GF9nY4ZujTwEXwkUkxBHD6b/e2J6rRWHsqXBMpVwDa3VqvpNx0LM4ADT2dNT+wYMcOKjeVCJ2ZRlDDXvk+kLzTY5AncTXfqgn28RIke8lpAyV7GLPEtN0PkE0hl2d9nKzvJYzqWbUB9rTcnR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791558691; c=relaxed/simple; bh=CWQ8/i2hnWz9mwtHhRbUBlfXDq/qLQBYT+2/sqfdVJE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mTgOfK4dq1qKXrefgKzVjN97XhjCsqnMkuSLEk8BF+qIBH4G8MqvN25VOMjel61wNFXVXzZL3pQUKhZgl3cXlX0Xis//OUxn5KPDjUdZG9WcC7E6YWD1UbzIJtZ3k2azeUCEq7vC4QS3xG5BqgrT+11+imT9ECwQKWAlZIYCEK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ADL/kRLg; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ADL/kRLg" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-cc4aa18f9afso3230436a12.3 for ; Fri, 09 Oct 2026 08:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1791558689; x=1792163489; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tI0FBjJw5y4gdtGFwBDX98lJORYRvSjv3jiqMKoW3vI=; b=ADL/kRLgxYvb2vmXo6ektfonSXfo7q/3fQUxvDoRarNQ4Oqmeh8QJOrtr81/+RPgm7 YbYhy1Hd6+j87jiY/kmVXa10jfutcD92Q2RvNsZRQZysXSRiDVcvwlwB98eqLtkY1y5I D8TnLlCop7nowO5BRce68uOb09VVp/GBa1GXpoPccej9QdrqynrqoDSH9geCx+0XB94Z fY5hVDWQj0LRxPAxZCm894J2RgirkZUaSSqC6Q2GwUpZBt0zn7JCZ8QFcYfA9N1DO71x Qz7BtOranTwMhmGqWzItlsFp7mU6yKCuEhk/nfIQS7+k8Aya7wZC0ltJmc3LFUAABTcz 46Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791558689; x=1792163489; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tI0FBjJw5y4gdtGFwBDX98lJORYRvSjv3jiqMKoW3vI=; b=ELCDzhcW0nfTi+8dUpvl5vP+Goqs8z1h8n0GhYDfYUtgZ+PaR2hT9rjFQztM5g82dj Sy2Ur9TlOlxoKFvm888ERim3GVrjKiin9wh0CnrOPx/wnyuy550Qvfl0IxxoYqs13C9h JZ52k7tuZmR4jd1c43ueqPTC+LwJfUgCMHQJICsFyH3uGyRb2X7kpIQSfAtHzOFBsMtr c9EG8gdCmnlj8QyqP9ZT4AWTdoXbOTzI1ZRxBECQ+oDvRI+DeKmdWmKF9QRzbh4Bp+t7 Ui9n5D8TYXJZW8ADLgSb5B6re/V5dtmx1pePWhFwpg9SdoT3oZXoGvmkw4j1orimjTf3 0KrQ== X-Forwarded-Encrypted: i=1; AKwUvBzSA7t/r5Hxf3VIJnXgu5X/9iUl4vsuymAatSTgb3AReaI7p5hQXSrCAT59faHOPnxb4ZBD4VgMqij6g3uXPo3k@vger.kernel.org X-Gm-Message-State: AFq9FYKdoRWng5//pUcvvoJ4KMVR5egQUobKlR5oR6MGRPQqcaRnxFz9 NYucOtnAPlAwhW0RK0A5bsX/S23SHFnRO8tIts+bwutTscNUBn6ULnEd1SLMov8JX1Ql2ozN2ZE opfZV X-Gm-Gg: AYBFou08DbHR0BVXokgXF/JadrZKzDGSNS6mmPEVnMSOqYg3jgWGbuFzX/qnsyg8WxO 1S8wXsw2oQEmGb8+BN6IxdY+MqCKYy5/XwApMfSgmjhmy36uB8riz/fQirQl1o+TZ3ozHIE4CD2 FR8G3DuyweWbx2xJDT8gopvGb8w0xXzLlBGjzbYoWOOyGwmuTQnI/X0lqf6NvZHibpVE6tAR7UK XiXWZTSQ3twwEC6W/IajzirEWnPW7aZKkaGAjylZj6lbQ3cnOZ2WbSs3xSeMjS3MR3zrqNJg2VX Rv/p+OTVQ9pkA+B0llhclBQQa9OR77hFrZyVrtvjL7zhS+t/T5g0NKvjRw3pbqpLzhcelScLnKL SsBROAuJlV8wxJdjerTCurP5XgaSSX/A6aU/olybMO8OnOJD+NRz2hNYL6G1ExLokKdmoQeOCUk ITS8zt+3RdXMBcjzo3Se2tiWDyPx2f/IccebkQxA9jBAgjiqA6hplHOy13VEMdZvK2W7j2WYdk6 w== X-Received: by 2002:a17:90b:3145:b0:3a8:86d6:aab2 with SMTP id 98e67ed59e1d1-3ab3a99b883mr2053681a91.63.1791558689150; Fri, 09 Oct 2026 08:11:29 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:9f78:f82f:d05e:99a4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd3da05caaesm1117345a12.32.2026.10.09.08.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2026 08:11:28 -0700 (PDT) Date: Fri, 9 Oct 2026 09:11:26 -0600 From: Mathieu Poirier To: Yonghao Zhang Cc: andersson@kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH v3] remoteproc: core: Fetch the auto-boot firmware only once Message-ID: References: <20261001081056.38293-1-hyz3367@gmail.com> Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261001081056.38293-1-hyz3367@gmail.com> On Thu, Oct 01, 2026 at 04:10:56PM +0800, Yonghao Zhang wrote: > Auto-boot for an always-on remote processor registers an asynchronous > request_firmware_nowait() whose callback, rproc_auto_boot_callback(), > calls rproc_boot() first and only releases the fetched image at the > very end of the callback. rproc_boot() does not take this image as an > argument: it fetches the very same image again with a synchronous > request_firmware(), so every auto-boot reads the firmware image twice > and allocates the buffer twice; on kernels with the sysfs fallback > enabled, the uevent round-trip is repeated as well. > > The asynchronous request exists only so that rproc_add() does not > block on the filesystem read; the image it fetches is never used. > The core already defers rproc_boot() to a worker for detached > processors (attach_work). Reuse that worker for offline processors > too and drop the asynchronous firmware request: rproc_boot() fetches > the image exactly once and dispatches between a firmware boot and > an attach based on the processor state. The work is renamed to > boot_work to match its widened role. > > commit 400e64df6b23 ("remoteproc: add framework for controlling remote > processors") noted back in 2011 that "we must wait until it completes > before we try to unregister the device". rproc_del() now does exactly > that: it waits for the boot work with cancel_work_sync(), which also > closes the theoretical window in which a pending attach work could > outlive the rproc instance. > > The changed fallback behaviour only matters for legacy > configurations. udev dropped its userspace firmware loader back in > 2014, as recorded in > Documentation/driver-api/firmware/fallback-mechanisms.rst, and the > kernel has documented since commit 02c399306826 ("firmware_loader: > enhance Kconfig documentation over FW_LOADER") that "Linux no longer > relies on or uses a fallback mechanism in userspace". Auto-boot now > uses the same synchronous fallback semantics as every other explicit > boot source (sysfs, cdev). > > Signed-off-by: Yonghao Zhang > --- > Changes in v3: > - Drop rproc_trigger_auto_boot() wrapper and schedule boot_work > directly in rproc_add() (Mathieu). > > Changes in v2: > - Fix the order described in the changelog: the callback calls > rproc_boot() first and releases the asynchronously fetched image at > the end of the callback (Mathieu). > - Fix typo "proccessor". > > drivers/remoteproc/remoteproc_core.c | 66 +++++++--------------------- > include/linux/remoteproc.h | 4 +- > 2 files changed, 19 insertions(+), 51 deletions(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 263e12f022ea..b88bf179507d 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -1662,51 +1662,23 @@ static int rproc_attach(struct rproc *rproc) > } > > /* > - * take a firmware and boot it up. > - * > - * Note: this function is called asynchronously upon registration of the > - * remote processor (so we must wait until it completes before we try > - * to unregister the device. one other option is just to use kref here, > - * that might be cleaner). > + * Boot or attach the remote processor in the background: rproc_add() > + * runs in probe context and must not block while the firmware image is > + * read from storage. rproc_boot() dispatches on the processor state, > + * so this covers both a firmware boot and an attach to a processor > + * started by another entity. > + * > + * Note: rproc_del() waits for this work to complete with > + * cancel_work_sync(), so the rproc instance remains valid for the > + * entire lifetime of this function. > */ > -static void rproc_auto_boot_callback(const struct firmware *fw, void *context) > -{ > - struct rproc *rproc = context; > - > - rproc_boot(rproc); > - > - release_firmware(fw); > -} > - > -static void rproc_attach_work(struct work_struct *work) > +static void rproc_boot_work(struct work_struct *work) > { > - struct rproc *rproc = container_of(work, struct rproc, attach_work); > + struct rproc *rproc = container_of(work, struct rproc, boot_work); > > rproc_boot(rproc); > } > > -static int rproc_trigger_auto_boot(struct rproc *rproc) > -{ > - int ret; > - > - if (rproc->state == RPROC_DETACHED) { > - schedule_work(&rproc->attach_work); > - return 0; > - } > - > - /* > - * We're initiating an asynchronous firmware loading, so we can > - * be built-in kernel code, without hanging the boot process. > - */ > - ret = request_firmware_nowait(THIS_MODULE, FW_ACTION_UEVENT, > - rproc->firmware, &rproc->dev, GFP_KERNEL, > - rproc, rproc_auto_boot_callback); > - if (ret < 0) > - dev_err(&rproc->dev, "request_firmware_nowait err: %d\n", ret); > - > - return ret; > -} > - > static int rproc_stop(struct rproc *rproc, bool crashed) > { > struct device *dev = &rproc->dev; > @@ -2348,11 +2320,8 @@ int rproc_add(struct rproc *rproc) > rproc_create_debug_dir(rproc); > > /* if rproc is marked always-on, request it to boot */ > - if (rproc->auto_boot) { > - ret = rproc_trigger_auto_boot(rproc); > - if (ret < 0) > - goto rproc_remove_dev; > - } > + if (rproc->auto_boot) > + schedule_work(&rproc->boot_work); > > /* expose to rproc_get_by_phandle users */ > mutex_lock(&rproc_list_mutex); > @@ -2361,10 +2330,6 @@ int rproc_add(struct rproc *rproc) > > return 0; > > -rproc_remove_dev: > - cancel_work_sync(&rproc->crash_handler); > - rproc_delete_debug_dir(rproc); > - device_del(dev); > rproc_remove_cdev: > rproc_char_device_remove(rproc); > return ret; > @@ -2552,7 +2517,7 @@ struct rproc *rproc_alloc(struct device *dev, const char *name, > INIT_LIST_HEAD(&rproc->subdevs); > INIT_LIST_HEAD(&rproc->dump_segments); > > - INIT_WORK(&rproc->attach_work, rproc_attach_work); > + INIT_WORK(&rproc->boot_work, rproc_boot_work); > INIT_WORK(&rproc->crash_handler, rproc_crash_handler_work); > spin_lock_init(&rproc->crash_handler_lock); > > @@ -2630,6 +2595,9 @@ int rproc_del(struct rproc *rproc) > if (cancel_work_sync(&rproc->crash_handler)) > pm_relax(rproc->dev.parent); > > + /* auto-boot may still be fetching firmware: wait for it here */ > + cancel_work_sync(&rproc->boot_work); > + > __rproc_shutdown(rproc, true); > > rproc_delete_debug_dir(rproc); > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h > index a44368737b39..d77e24539133 100644 > --- a/include/linux/remoteproc.h > +++ b/include/linux/remoteproc.h > @@ -231,7 +231,7 @@ enum rproc_features { > * @subdevs: list of subdevices, to following the running state > * @notifyids: idr for dynamically assigning rproc-wide unique notify ids > * @index: index of this rproc device > - * @attach_work: workqueue for attaching rproc > + * @boot_work: workqueue for booting rproc > * @crash_handler: workqueue for handling a crash > * @crash_handler_lock: serializes crash handler queueing and deletion > * @deleting: remoteproc deletion has begun > @@ -277,7 +277,7 @@ struct rproc { > struct list_head subdevs; > struct idr notifyids; > int index; > - struct work_struct attach_work; > + struct work_struct boot_work; > struct work_struct crash_handler; > spinlock_t crash_handler_lock; > bool deleting; > -- > 2.34.1 >