From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.175 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792689660; b=jqTBPyfpdAbyMhjZDJekXHH4eZZWQYJybmSBPMr+G4rtNJqVnFFBWcP39Y1CIQ1ucVU1 fl1eXOGZdArormTGXDW0oT+ikhuubizXVmjx9u5aI4BQTAiGrm7YH65Wcd096IRqU6s6i lrKOomI2HTllKyv7eZF0S2p7gtdiwQpP7kpmyYAamcrNpQnsVCniq83w0l01nLNDasjGP 7zBSEHR+LarHx7Uj2MpxIbbWSqGPanDLt83/LNqKSEszuSZZYFt3OYye4DXbEFS9rr7Mj 9wFclLN5W+KCSU+UOL7wMIMRo8lg7x4uWgQrAmtSVWCN79RoWbELmkoy/+GNcEQ1j7A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792689660; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=qSKC6LmTr8AlslSEV3eV/HjwmhQt0Co2xOFmLGtEaEI=; b=SecoBRDkyDSYp45yRBbBqHMoL5BiMXn0rcQh+vSQNbvl1PaKe3GnAddAKo5glGWbFh7i zbbymEtigNhChGZqnW5/8AyNHvrfg7nhBxOpvgEcr1hHwqHJfutf1uI6HhkEWZodzJk+F HUO265c3sR1LpUTi0HckppxC9ir31GOS3ptjJc0i4p0Rt+2baNpZMDMQVQsZr2hXtPLAv A5HtjdezrqLH3xZ8iYF9G23r3tAkFjJhwY6FHq9PIzFLW/jmyZbTGj4Wa5grJ+w64w0az J+q/AQ2KpQcdwmQFwaXiwPoYKVr34e3GupxNEDQ3rPlM5XtPvUMdZ5NUZZDpFe/LXyQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=OMg3vCev; arc=none smtp.remote-ip=209.85.214.175 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AE09606A31B for ; Thu, 22 Oct 2026 17:20:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9AE09606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=OMg3vCev Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2e831e86ebfso12363605ad.1 for ; Thu, 22 Oct 2026 10:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1792689659; x=1793294459; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=qSKC6LmTr8AlslSEV3eV/HjwmhQt0Co2xOFmLGtEaEI=; b=OMg3vCev/2Ujxa9oEpgiu0xbE1LUsHSx8nyHW6T/WI6oPLeznW1CrSavu0LbaKsnMb uBnXAI+0yj14nVvqT/8yyv+IKogdNcJedJKOfCcpprK4OdRiWQ2YQ/WTkREHRICuY/PT P7hgzWoebssFygNwNUfU8BJ456S3GXdprnm6l2w98eQI5ECmqnUuLgXXUjDkosqPboxd 8RPo9uMtHby6nc7xilDqLAm6VO1pe8ymjbfxTPQz48pQCpDyFcapZyo/9RFLYzHJQhhO Ess3kGcgCrp1SKM7CO7nGZwJpQxTf6ilOILjYnORGbW0p+5eIU7804ZgsKVAu34BF5+r QfeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792689659; x=1793294459; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qSKC6LmTr8AlslSEV3eV/HjwmhQt0Co2xOFmLGtEaEI=; b=1tiNQYFj7dxcJidIf9kXAHsdHZHcXK6r6ZzaFJXbz8ikcQydxdGTSn5oVvBHhWSTKp zwSPVfiz20hfoib7kInsQWNHphIOeMY4CNFddqlyBHBi9q8ggArp0NI9jl41Sv7rSs7Z 0IO/3AB/I/or5O+Xmu864xu+04coXnTphErKZmWFhYCPLFpMv1kbPIINJ+JYmApCa+7R EsTdDqSCwNVVXnD5gOoi7d9Alr+6m6uGsUNpItKA4ClHADW9A39WMiLBK8I8jX8JSprl CiQOkWOrBTwft457wPZt+ynT6774Wt2+8GYKzijk5dGcdyfjMD/8TAf4htLRSPOeFznk Mt2A== X-Forwarded-Encrypted: i=1; AKwUvBw8WQcEtKP1tcL9ZR+mjjPS+im/pdnLcxsa1ilRRmJFNqpOf8VeQbraxMjHMrucvKdv+AC6B5oXaHIdBCiSFD2F@vger.kernel.org X-Gm-Message-State: AFq9FYLzQAnnTvam1Zu0tJt0/bgLWu7jNo/yLKAsqu30P9PzrGXcHLEe BLASexSWIWkLD5fCQex49vpAmdECOC4EGTLNuPxU0bwuvolznB+2x5pYyuPqFLuTMes= X-Gm-Gg: AYBFou3x3kR0/7rJ2+X5yIzhaq1PZ2GryTAJSyvFaKJ9QYStrgdML3Ut5TFw7TBHbdZ qiAlUnRrgqPj5jdo5t06gT1UcoOXY83hCJf9Vk9td0VFeXELgrAuqTuxnTvsvJ//bD5YVSc0b/s Hs8ehPWf83NXVdWqFMyFXhLCRWVBVZUtE7Ma1PPBA2tiMWFmTBhCbSf99494mtu7CwJk2aCBiKU q87tg09XNf+E5tZrUrqN4T0Z+Dqt1M/WqYifoj2eMOz1Q9DlM78tM0RK1Y77AxsEogLM/OcY4E/ aseKecDe9y8adYgzRLFOiN/kKDtr6ixocw3kBAFsKG1v2ZRj8k1xFW8HM3taIOXn5kY0U0afuZS 78rzuibLLHB0yBASwhHCn5fOqibOkvWrWw8xatIm018KhYtPqBHWRtj7T6kzKOmtkaqsrJoUBMy kz8g7O5APSedIpMjizmVpVqfQhYNYLY4aLHzBpgcKplp9Pl7YP+Wk5kZVcJVpCuJy8l5XbUZ17V Nb6ZjksMrpJCccd1ItjqMKpptNvlyY1xQLtHxJq5divXwVSTMRxWGv2/F1oO3CWEZ2/RGjKjx48 h4fG X-Received: by 2002:a17:903:2f89:b0:2e5:54c6:e5c9 with SMTP id d9443c01a7336-2ea437b4bf8mr47547695ad.2.1792689658924; Thu, 22 Oct 2026 10:20:58 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:9e85:9169:41c7:bc2d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ea7b366766sm1137285ad.31.2026.10.22.10.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 10:20:58 -0700 (PDT) Date: Thu, 22 Oct 2026 11:20:55 -0600 From: Mathieu Poirier To: Frank.Li@oss.nxp.com Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Laurentiu Mihalcea , Frank Li , Francesco Valla Subject: Re: [PATCH v7 2/3] remoteproc: imx_rpoc: use memory-region-names to avoid hidden ABI Message-ID: References: <20261020-memory-region-name-v7-0-1413d5928340@nxp.com> <20261020-memory-region-name-v7-2-1413d5928340@nxp.com> X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261020-memory-region-name-v7-2-1413d5928340@nxp.com> On Tue, Oct 20, 2026 at 12:50:22PM -0400, Frank.Li@oss.nxp.com wrote: > From: Laurentiu Mihalcea > > The driver currently derives the memory region type from the referenced > memory node name, creating a hidden DT ABI. Since memory node names are > not constrained by the binding, incorrect names can silently pass DT > validation, as seen in examples using "vdevbuffer" instead of > "vdev0buffer" ([1] and [2]). > > Parse memory-region-names to identify the expected memory regions and avoid > relying on memory node names as ABI. > > Link: https://lore.kernel.org/imx/a3602ef8-2b77-4cc3-adef-2c4cba08a5d9@nabladev.com/ [1] > Link: https://lore.kernel.org/imx/alexXTYQHUs76J7v@SMW015318/T/#mb9dc709ff3adc24d9db6d30c973f37b580f6f1f9 [2] > > Signed-off-by: Laurentiu Mihalcea > Reviewed-by: Peng Fan > Reviewed-by: Francesco Valla > Signed-off-by: Frank Li > --- > drivers/remoteproc/imx_rproc.c | 32 ++++++++++++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 581bb07f5893f..1647726893d1a 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -635,6 +635,25 @@ static int imx_rproc_sm_lmm_prepare(struct rproc *rproc) > return 0; > } > > +static int imx_rproc_rmem_to_resource(struct device_node *np, > + int index, > + struct resource *res) > +{ > + int ret; > + > + ret = of_reserved_mem_region_to_resource(np, index, res); > + if (ret) > + return ret; > + > + /* "memory-region-names" is optional */ > + ret = of_property_read_string_index(np, "memory-region-names", > + index, &res->name); > + if (ret == -EINVAL) > + return 0; > + > + return ret; > +} > + > static int imx_rproc_prepare(struct rproc *rproc) > { > struct imx_rproc *priv = rproc->priv; > @@ -648,7 +667,7 @@ static int imx_rproc_prepare(struct rproc *rproc) > int err; > struct resource res; > > - err = of_reserved_mem_region_to_resource(np, i++, &res); > + err = imx_rproc_rmem_to_resource(np, i++, &res); > if (err) > break; > > @@ -823,11 +842,20 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > if (nph <= 0) > return 0; > > + if (!of_property_present(np, "memory-region-names")) { > + dev_warn(dev, "using node names for carveouts should be avoided\n"); Get rid of dev_warn(). > + } else { > + if (nph != of_property_count_strings(np, "memory-region-names")) { > + dev_err(dev, "invalid reserved memory name count\n"); > + return -EINVAL; > + } > + } > + > /* remap optional addresses */ > for (a = 0; a < nph; a++) { > struct resource res; > > - err = of_reserved_mem_region_to_resource(np, a, &res); > + err = imx_rproc_rmem_to_resource(np, a, &res); > if (err) { > dev_err(dev, "unable to resolve memory region\n"); > return err; > > -- > 2.43.0 >