From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Nikita Travkin <nikita@trvn.ru>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
cros-qcom-dts-watchers@chromium.org
Cc: David Wronek <davidwronek@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/4] remoteproc: qcom: pas: Add sc7180 adsp
Date: Tue, 5 Sep 2023 10:35:14 +0200 [thread overview]
Message-ID: <b85245cc-868a-442e-8f27-ae6ee60d49cc@linaro.org> (raw)
In-Reply-To: <20230905-sc7180-adsp-rproc-v1-2-dfea7699da7b@trvn.ru>
On 5.09.2023 07:47, Nikita Travkin wrote:
> sc7180 has a dedicated ADSP similar to the one found in sm8250.
> Add it's compatible to the driver reusing the existing config so
> the devices that use the adsp can probe it.
>
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index b5447dd2dd35..55fafc68200e 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -1161,6 +1161,7 @@ static const struct of_device_id adsp_of_match[] = {
> { .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init },
> { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init },
> { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init },
> + { .compatible = "qcom,sc7180-adsp-pas", .data = &sm8250_adsp_resource},
Should we use a fallback here, maybe?
Konrad
next prev parent reply other threads:[~2023-09-05 16:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 5:47 [PATCH 0/4] sc7180: Add ADSP Nikita Travkin
2023-09-05 5:47 ` [PATCH 1/4] dt-bindings: remoteproc: qcom: sc7180-pas: Add ADSP compatible Nikita Travkin
2023-09-05 7:04 ` Krzysztof Kozlowski
2023-09-05 5:47 ` [PATCH 2/4] remoteproc: qcom: pas: Add sc7180 adsp Nikita Travkin
2023-09-05 8:35 ` Konrad Dybcio [this message]
2023-09-05 10:24 ` Nikita Travkin
2023-09-05 5:47 ` [PATCH 3/4] arm64: dts: qcom: sc7180: Add tertiary mi2s pinctrl Nikita Travkin
2023-09-05 5:47 ` [PATCH 4/4] arm64: dts: qcom: sc7180: Add ADSP Nikita Travkin
2023-09-05 7:05 ` Krzysztof Kozlowski
2023-09-05 7:12 ` Krzysztof Kozlowski
2023-09-05 7:18 ` Krzysztof Kozlowski
2023-09-05 10:34 ` Nikita Travkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b85245cc-868a-442e-8f27-ae6ee60d49cc@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=davidwronek@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox