From: "Raghavendra, Vignesh" <vigneshr@ti.com>
To: Devarsh Thakkar <devarsht@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<andersson@kernel.org>, <devicetree@vger.kernel.org>,
<mathieu.poirier@linaro.org>, <p.zabel@pengutronix.de>,
<linux-remoteproc@vger.kernel.org>, <robh+dt@kernel.org>,
<linux-kernel@vger.kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <s-anna@ti.com>
Cc: <hnagalla@ti.com>, <praneeth@ti.com>, <nm@ti.com>,
<a-bhatia1@ti.com>, <j-luthra@ti.com>
Subject: Re: [PATCH v6 2/3] dt-bindings: remoteproc: ti: Add new compatible for AM62 SoC family
Date: Tue, 17 Jan 2023 20:19:15 +0530 [thread overview]
Message-ID: <cfd56381-e9b1-b316-319c-c1f504daf1d9@ti.com> (raw)
In-Reply-To: <bd0460de-eff2-9162-4edb-d3527041d7a6@ti.com>
Hi Devarsh,
On 1/17/2023 10:54 AM, Devarsh Thakkar wrote:
> Hi Krzysztof,
>
> On 17/01/23 00:36, Krzysztof Kozlowski wrote:
>> On 16/01/2023 16:19, Devarsh Thakkar wrote:
>>> AM62 family of devices don't have a R5F cluster, instead
>>> they have single core DM R5F.
>>> Add new compatible string ti,am62-r5fss to support this scenario.
>>>
>>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions. However, there's no need to repost patches *only* to add the
>> tags. The upstream maintainer will do that for acks received on the
>> version they apply.
>>
>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>>
>> If a tag was not added on purpose, please state why and what changed.
> I apologize if it was not clear but yes I didn't put the tag as
> patch was updated to use cluster-mode=3 for am62x as per review comments on
> https://lore.kernel.org/all/20230110183505.GA2741090@p14s/
It would be helpful in future if you document why tag was dropped as
part of change log (below tearline) to indicate its intentional.
>
> I'll append a note below commit message on Reviewed-By
> removal when I post the next series.
> Regards
> Devarsh
>>
>>
>> Best regards,
>> Krzysztof
>>
next prev parent reply other threads:[~2023-01-17 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 15:19 [PATCH v6 0/3] Add single core R5F IPC for AM62 SoC family Devarsh Thakkar
2023-01-16 15:19 ` [PATCH v6 1/3] remoteproc: k3-r5: Simplify single core config set Devarsh Thakkar
2023-01-16 16:43 ` Mathieu Poirier
2023-01-16 15:19 ` [PATCH v6 2/3] dt-bindings: remoteproc: ti: Add new compatible for AM62 SoC family Devarsh Thakkar
2023-01-16 19:06 ` Krzysztof Kozlowski
2023-01-17 5:24 ` Devarsh Thakkar
2023-01-17 14:49 ` Raghavendra, Vignesh [this message]
2023-01-16 15:19 ` [PATCH v6 3/3] remoteproc: k3-r5: Use separate compatible string for TI AM62x " Devarsh Thakkar
2023-01-16 16:45 ` Mathieu Poirier
2023-01-17 14:41 ` Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd56381-e9b1-b316-319c-c1f504daf1d9@ti.com \
--to=vigneshr@ti.com \
--cc=a-bhatia1@ti.com \
--cc=andersson@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox