From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v5 12/12] arm64: dts: mediatek: mt8195: Add SCP 2nd core
Date: Fri, 10 Feb 2023 15:09:28 +0100 [thread overview]
Message-ID: <db22c545-da11-9869-ef20-31d5a7a33318@collabora.com> (raw)
In-Reply-To: <20230210085931.8941-13-tinghan.shen@mediatek.com>
Il 10/02/23 09:59, Tinghan Shen ha scritto:
> Rewrite the MT8195 SCP device node as a cluster and
> add the SCP 2nd core in it.
>
> Since the SCP device node is changed to multi-core structure,
> enable SCP cluster to enable probing SCP core 0.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../boot/dts/mediatek/mt8195-cherry.dtsi | 4 +++
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 30 ++++++++++++++-----
> 2 files changed, 27 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> index 56749cfe7c33..4f9bc7581adb 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> @@ -933,6 +933,10 @@
> interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> +&scp_cluster {
> + status = "okay";
> +};
> +
> &scp {
> status = "okay";
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 8f1264d5290b..87e49f5fb7b3 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -826,14 +826,30 @@
> clocks = <&infracfg_ao CLK_INFRA_AO_GCE2>;
> };
>
> - scp: scp@10500000 {
> - compatible = "mediatek,mt8195-scp";
> - reg = <0 0x10500000 0 0x100000>,
> - <0 0x10720000 0 0xe0000>,
> - <0 0x10700000 0 0x8000>;
> - reg-names = "sram", "cfg", "l1tcm";
> - interrupts = <GIC_SPI 462 IRQ_TYPE_LEVEL_HIGH 0>;
> + scp_cluster: scp@10500000 {
> + compatible = "mediatek,mt8195-scp-dual";
> + reg = <0 0x10720000 0 0xe0000>, <0 0x10700000 0 0x8000>;
> + reg-names = "cfg", "l1tcm";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0 0x10500000 0x100000>;
> status = "disabled";
> +
> + scp: scp@0 {
Minor nit: Please change this to `scp_c0:`.
Like that, we keep consistency and increase readability, as we're clearly then
reading that one node is for core 0, the other is for core 1.
This is fine even on devices using only a single SCP core, because in devicetree
we are describing the hardware, not the software implemetation of it - and the
MT8195 SoC does, by hardware, have two SCP cores anyway :-)
After which,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
prev parent reply other threads:[~2023-02-10 14:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 8:59 [PATCH v5 00/12] Add support for MT8195 SCP 2nd core Tinghan Shen
2023-02-10 8:59 ` [PATCH v5 01/12] dt-bindings: remoteproc: mediatek: Improve the rpmsg subnode definition Tinghan Shen
2023-02-10 8:59 ` [PATCH v5 02/12] arm64: dts: mediatek: mt8183-kukui: Update the node name of SCP rpmsg subnode Tinghan Shen
2023-02-10 14:05 ` AngeloGioacchino Del Regno
2023-02-10 8:59 ` [PATCH v5 03/12] dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP Tinghan Shen
2023-02-10 14:05 ` AngeloGioacchino Del Regno
2023-02-10 8:59 ` [PATCH v5 04/12] remoteproc: mediatek: Add SCP core 1 register definitions Tinghan Shen
2023-02-10 8:59 ` [PATCH v5 05/12] remoteproc: mediatek: Add MT8195 SCP core 1 operations Tinghan Shen
2023-02-10 8:59 ` [PATCH v5 06/12] remoteproc: mediatek: Extract remoteproc initialization flow Tinghan Shen
2023-02-10 14:02 ` AngeloGioacchino Del Regno
2023-02-13 3:34 ` TingHan Shen (沈廷翰)
2023-02-10 8:59 ` [PATCH v5 07/12] remoteproc: mediatek: Probe multi-core SCP Tinghan Shen
2023-02-10 8:59 ` [PATCH v5 08/12] remoteproc: mediatek: Control SCP core 1 by rproc subdevice Tinghan Shen
2023-02-10 8:59 ` [PATCH v5 09/12] remoteproc: mediatek: Setup MT8195 SCP core 1 SRAM offset Tinghan Shen
2023-02-10 8:59 ` [PATCH v5 10/12] remoteproc: mediatek: Handle MT8195 SCP core 1 watchdog timeout Tinghan Shen
2023-02-10 14:01 ` AngeloGioacchino Del Regno
2023-02-10 8:59 ` [PATCH v5 11/12] remoteproc: mediatek: Refine ipi handler error message Tinghan Shen
2023-02-10 8:59 ` [PATCH v5 12/12] arm64: dts: mediatek: mt8195: Add SCP 2nd core Tinghan Shen
2023-02-10 14:09 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db22c545-da11-9869-ef20-31d5a7a33318@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tinghan.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox