From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0262FC83007 for ; Tue, 28 Apr 2020 10:25:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D612B206C0 for ; Tue, 28 Apr 2020 10:25:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="r+NX3cUx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727117AbgD1KZo (ORCPT ); Tue, 28 Apr 2020 06:25:44 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:21236 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727025AbgD1KZo (ORCPT ); Tue, 28 Apr 2020 06:25:44 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588069544; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=mt8ZKt7ekHYxZxwdLyFwpLcwX/dr8EXCmWDuLwuteJM=; b=r+NX3cUx2o4i7ttYzBxrJCu71jA/5sU6MNtAXLaTsvrFQSovsYBdzy5og37i0qhq7uPJtXPA 0H/6273i7BH/imROL0CDckxV+8XxLTu5u8zeIqTKudf17K7Rfh9biLOMAQfNzivjKUC3gb0k jYs44HRvEbVDfn10NjJkFdUzDGA= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI4ZWZiZiIsICJsaW51eC1yZW1vdGVwcm9jQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea804a5.7fbc61c1f688-smtp-out-n05; Tue, 28 Apr 2020 10:25:41 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C5E44C433F2; Tue, 28 Apr 2020 10:25:41 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id 34211C433CB; Tue, 28 Apr 2020 10:25:40 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Apr 2020 15:55:40 +0530 From: Sibi Sankar To: Bjorn Andersson Cc: Andy Gross , Ohad Ben-Cohen , Rob Herring , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rishabh Bhatnagar Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs In-Reply-To: <20200428000110.2958704-1-bjorn.andersson@linaro.org> References: <20200428000110.2958704-1-bjorn.andersson@linaro.org> Message-ID: X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hey Bjorn, On 2020-04-28 05:31, Bjorn Andersson wrote: > Add the SM8250 audio, compute and sensor remoteprocs to the PAS DT > binding. > > Signed-off-by: Bjorn Andersson > --- > .../devicetree/bindings/remoteproc/qcom,adsp.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt > b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt > index 9938918b2fea..49ec30454198 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt > @@ -21,6 +21,9 @@ on the Qualcomm ADSP Hexagon core. > "qcom,sm8150-cdsp-pas" > "qcom,sm8150-mpss-pas" > "qcom,sm8150-slpi-pas" > + "qcom,sm8250-adsp-pas" > + "qcom,sm8250-cdsp-pas" > + "qcom,sm8250-slpi-pas" > > - interrupts-extended: > Usage: required > @@ -44,6 +47,9 @@ on the Qualcomm ADSP Hexagon core. > qcom,sm8150-adsp-pas: > qcom,sm8150-cdsp-pas: > qcom,sm8150-slpi-pas: > + qcom,sm8250-adsp-pas: > + qcom,sm8250-cdsp-pas: > + qcom,sm8250-slpi-pas: > must be "wdog", "fatal", "ready", "handover", "stop-ack" > qcom,qcs404-wcss-pas: > qcom,sm8150-mpss-pas: > @@ -105,10 +111,13 @@ on the Qualcomm ADSP Hexagon core. > qcom,sdm845-cdsp-pas: > qcom,sm8150-adsp-pas: > qcom,sm8150-cdsp-pas: > + qcom,sm8250-adsp-pas: Looks like adsp also uses lcx and lmx similar to slpi, the rest looks good Reviewed-by: Sibi Sankar > + qcom,sm8250-cdsp-pas: > must be "cx", "load_state" > qcom,sm8150-mpss-pas: > must be "cx", "load_state", "mss" > qcom,sm8150-slpi-pas: > + qcom,sm8250-slpi-pas: > must be "lcx", "lmx", "load_state" > > - memory-region: -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.