From: Chris Lew <clew@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Arun Kumar Neelakantam <aneela@codeaurora.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rpmsg: glink: Use spinlock in tx path
Date: Wed, 21 Feb 2018 11:39:45 -0800 [thread overview]
Message-ID: <f376c90c-513d-0148-7bd2-9aae2151fd2d@codeaurora.org> (raw)
In-Reply-To: <20180213190404.25026-1-bjorn.andersson@linaro.org>
Hey Bjorn,
Minor issue with the glink patch.
Thanks,
Chris
On 2/13/2018 11:04 AM, Bjorn Andersson wrote:
[..]
> @@ -288,15 +288,14 @@ static int qcom_glink_tx(struct qcom_glink *glink,
> const void *data, size_t dlen, bool wait)
> {
> unsigned int tlen = hlen + dlen;
> + unsigned long flags;
> int ret;
>
> /* Reject packets that are too big */
> if (tlen >= glink->tx_pipe->length)
> return -EINVAL;
>
> - ret = mutex_lock_interruptible(&glink->tx_lock);
> - if (ret)
> - return ret;
> + spin_lock_irqsave(&glink->tx_lock, flags);
>
qcom_glink_tx will return an uninitialized ret value with removal of
mutex_lock_interruptible.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-02-21 19:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 19:04 [PATCH] rpmsg: glink: Use spinlock in tx path Bjorn Andersson
2018-02-21 19:39 ` Chris Lew [this message]
2018-03-20 2:14 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f376c90c-513d-0148-7bd2-9aae2151fd2d@codeaurora.org \
--to=clew@codeaurora.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox