Linux Remote Processor Subsystem development
 help / color / mirror / Atom feed
From: Wadim Egorov <w.egorov@phytec.de>
To: Garrett Giordano <ggiordano@phytec.com>, <andersson@kernel.org>,
	<mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <upstream@lists.phytec.de>
Subject: Re: [PATCH 2/2] remoteproc: k3-r5: Fix log levels where appropriate
Date: Wed, 26 Jun 2024 21:00:36 +0200	[thread overview]
Message-ID: <f426d54e-9e70-4dfa-a989-c3b21aeca85a@phytec.de> (raw)
In-Reply-To: <20240626162203.3484272-2-ggiordano@phytec.com>

Hi Garrett,

Am 26.06.24 um 18:22 schrieb Garrett Giordano:
> Driver was logging information as debug. Changed dev_dbg to dev_info
> where appropriate.
> 
> Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
> ---
>   drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> index 50e486bcfa10..5821b6517063 100644
> --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> @@ -558,7 +558,7 @@ static int k3_r5_rproc_start(struct rproc *rproc)
>   
>   	boot_addr = rproc->bootaddr;
>   	/* TODO: add boot_addr sanity checking */
> -	dev_dbg(dev, "booting R5F core using boot addr = 0x%x\n", boot_addr);
> +	dev_info(dev, "booting R5F core using boot addr = 0x%x\n", boot_addr);
There is no need for this debug message to be in info level.

Regards,
Wadim
>   
>   	/* boot vector need not be programmed for Core1 in LockStep mode */
>   	core = kproc->core;

      reply	other threads:[~2024-06-26 19:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 16:22 [PATCH 1/2] remoteproc: k3-dsp: Fix log levels where appropriate Garrett Giordano
2024-06-26 16:22 ` [PATCH 2/2] remoteproc: k3-r5: " Garrett Giordano
2024-06-26 19:00   ` Wadim Egorov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f426d54e-9e70-4dfa-a989-c3b21aeca85a@phytec.de \
    --to=w.egorov@phytec.de \
    --cc=andersson@kernel.org \
    --cc=ggiordano@phytec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=upstream@lists.phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox