From: Hari Nagalla <hnagalla@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <andersson@kernel.org>, <mathieu.poirier@linaro.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<nm@ti.com>, <vigneshr@ti.com>, <s-anna@ti.com>, <b-padhi@ti.com>,
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kristo@kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] dt-bindings: remoteproc: k3-dsp: Add C7xv dsp variant for J722S
Date: Mon, 2 Mar 2026 03:34:43 -0600 [thread overview]
Message-ID: <f59045d3-c8de-9a76-b58a-e4531f550f4a@ti.com> (raw)
In-Reply-To: <f54bd097-d56b-4f87-926f-4778476a96d5@kernel.org>
On 2/13/26 03:34, Krzysztof Kozlowski wrote:
>> This does not explain lack of compatibility. You ALWAYS add new
>> compatible string. ALWAYS. Drop the last sentence and fix the patch.
>>
>
> And by "fix" I meant express compatibility or explain better why local
> reset is different than resets property, which applies to new device.
> The entire picture made by commit msg and existing binding is just very
> confusing.
>
> Best regards,
> Krzysztof
>
Understood. Thanks for the review. I'll submit a v2 with a better
explanation of the local reset vs resets property distinction.
Best Regards,
Hari
next prev parent reply other threads:[~2026-03-02 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 0:11 [PATCH 0/4] Fix AM62A/J722S C7XV DSP reset variation Hari Nagalla
2026-02-13 0:11 ` [PATCH 1/4] dt-bindings: remoteproc: k3-dsp: Add C7xv dsp variant for J722S Hari Nagalla
2026-02-13 8:13 ` Krzysztof Kozlowski
2026-02-13 9:34 ` Krzysztof Kozlowski
2026-03-02 9:34 ` Hari Nagalla [this message]
2026-02-13 0:11 ` [PATCH 2/4] arm64: dts: ti: k3-j722s-main: update compatible string for C7XV dsps Hari Nagalla
2026-02-13 8:14 ` Krzysztof Kozlowski
2026-02-13 0:11 ` [PATCH 3/4] remoteproc: k3-dsp: use local reset for C7XV dsps on AM62A Hari Nagalla
2026-02-13 0:11 ` [PATCH 4/4] remoteproc: k3-dsp: add compatible string for j722s C7XV DSP Hari Nagalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f59045d3-c8de-9a76-b58a-e4531f550f4a@ti.com \
--to=hnagalla@ti.com \
--cc=andersson@kernel.org \
--cc=b-padhi@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=s-anna@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox