From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:58493 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753106AbdEJNZu (ORCPT ); Wed, 10 May 2017 09:25:50 -0400 From: Laurent Pinchart To: Niklas =?ISO-8859-1?Q?S=F6derlund?= Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, tomoharu.fukawa.eb@renesas.com, Sakari Ailus , Geert Uytterhoeven Subject: Re: [PATCH 09/16] rcar-vin: decrease buffers needed to capture Date: Wed, 10 May 2017 16:25:49 +0300 Message-ID: <12667105.QFsJaJFvAH@avalon> In-Reply-To: <20170314185957.25253-10-niklas.soderlund+renesas@ragnatech.se> References: <20170314185957.25253-1-niklas.soderlund+renesas@ragnatech.se> <20170314185957.25253-10-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:50 Niklas S=F6derlund wrote: > It's possible to grab frames using only one buffer, this should never= > have been set to anything else then 1. >=20 > Signed-off-by: Niklas S=F6derlund Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c > b/drivers/media/platform/rcar-vin/rcar-dma.c index > 9ccd5ff55e192514..c37f7a2993fb5565 100644 > --- a/drivers/media/platform/rcar-vin/rcar-dma.c > +++ b/drivers/media/platform/rcar-vin/rcar-dma.c > @@ -1183,7 +1183,7 @@ int rvin_dma_probe(struct rvin_dev *vin, int ir= q) > =09q->ops =3D &rvin_qops; > =09q->mem_ops =3D &vb2_dma_contig_memops; > =09q->timestamp_flags =3D V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; > -=09q->min_buffers_needed =3D 2; > +=09q->min_buffers_needed =3D 1; > =09q->dev =3D vin->dev; >=20 > =09ret =3D vb2_queue_init(q); --=20 Regards, Laurent Pinchart