From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 937D131B80B for ; Fri, 7 Nov 2025 11:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762513228; cv=none; b=JWky1rk1X0thAMncGroF2OaReFXRG7DbGHIHsT4+Dm2PnsGZ/LEq2ptjBJySah7wxJXHFuf2poYZAsRkELh52kxpL8jv64cPbR2tYtZcCrOa3cFo10wI5ngU4jBS80qXZiaJKvOHD1t5a0YLyD+AlQMI2jvQ4sW8LPXNYhjLD/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762513228; c=relaxed/simple; bh=YP5Kx7k+Nd09x0w4SUTnReHV8qPMtlpM4hSGSOzvfg8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f+R2BytXhROOWWpAeYrbvcpRDl/UXnOWZUrLK1m5kDzpcsY4lN5sqMskiKW70y5p3j8RK554ujq01ZwmfcURB8tJldO7YabP+4+MLFi0ixdaq15aiolWa8wKmgkHdJkyjg0nwGA6wXlCi0E9692QZVA5WqeNnA9ZmMG1OlXr6JY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=meYRNVo/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=X7eXUY9j; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="meYRNVo/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="X7eXUY9j" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A73kfk9583748 for ; Fri, 7 Nov 2025 11:00:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3Yxrppr7/emo5nMkfpN1y9e7bjiQLYqkReu/RHenH+8=; b=meYRNVo/ytmsLIw3 9yLlW7GI4+rmzu1SkLLhvRhvP8rWpFv8etdCh6oOI0eghmA6tDSc4+hVriUcpmbT bvUyQrcf9TgGLMtQn9G+DabVKcab8kJVoyw9dkotpbWXALEFwxkESHu9/xGv20VL nacxkzyq6bconr1T4lWp2oNzE6cnmBNsSKhavXJQtBCa7T+USx4Ja6Uje777/aBI 6S25I9Inyk4w65tWzgHYtI+hnsskEBJILnxbA1HqfHj1VXyZUvwbpaTp6JPz2umy TUX/veb7bU/ued1EGhEUm+QNtaAtvgdwI55azNJSswoyx0dkp6JjaiBc//hM8H2d w5LLEA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a8yktjtjs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Nov 2025 11:00:25 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b1be0fdfe1so22175485a.2 for ; Fri, 07 Nov 2025 03:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762513224; x=1763118024; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3Yxrppr7/emo5nMkfpN1y9e7bjiQLYqkReu/RHenH+8=; b=X7eXUY9jhcys6rCJKfWotZD5Wt6XLsFNZzhmExcenT54Ewgatl+zppHG4iTptUzHMq wu+EN+m/nYrv1wxWffmJcVrBxusDeXl9u6DihAtSYrMREzt3jAeCv94BW7bgm57UBOP9 3GlNOXEN01GWK4f8CUN1cgvdB/b7TU7taLJoy2P1gfCbMDh0bCr3w1FltKUei+jjWtFU qLOf9n0UUxTMGGJ4BqWdgw6jjYlQfNhaoo4jxbzTOTDUvXpDlFrKjZQARPPLjnEnbWvf hK1J6AB9XW9d8hZzSMXXh6LBM6UUKnLAlBkU7NxWBJUjBveUStrHG+69YYYfEren+j8T ROcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762513224; x=1763118024; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3Yxrppr7/emo5nMkfpN1y9e7bjiQLYqkReu/RHenH+8=; b=ZqUgUc83IzDlnhmi9yTndGpHLzMq6YQ2SZutvzyeilZ1Tz/G99PHYxW1mGjo8fgm9+ f+Po565BPEKr0BP1UJConT2UyeTPsr3XJ84cSgxJcgLwiNhRVjju5TCl2kkl5AoL9uCe +hg8Dhr+imlObQnwheje0HTMmgLeZOHt1g1Bgggw689xaMOqhDJFo2nRUN5Nd8wEjI4W vpqq8WRKZJTsHcUWyFZjTcNZ82XsK8K16NOKQHVRoGTSoq7dX42JqKdw/IUMtO/pbnV6 4jngps3MHqxZj2MLCfDQnvOdbLJNGg3vYgc87fFu2wAvhoNaEfyEmHf8NhEh9M1KIb3h 6r6Q== X-Forwarded-Encrypted: i=1; AJvYcCVNRdPZbOhPH+WljXy2ntjcOyYTppVZXFQd0ni6BM/wOxtBinwzBwg+fTXhQlig1rsdOXw3lgbrg0lQy57u9LcuTw==@vger.kernel.org X-Gm-Message-State: AOJu0YzbwxlfNoKGn6PrVJqNZicrmldyL0qE+VON/K06WA7HA6SKaDQL CGFvX2RNVU2U9moDyRY2qzt8GAWYnNnW8uFjeqKfdTbsYZYSbfmHbAl+6wQVafrLBh/Iuilw0U0 BfpYvu6DFYYxVEuRdO72DkNGN7oxQ7MsGwT7mEZFXhwxumuIlHYROvTnpc5VdvR+zLEhH9otN1g == X-Gm-Gg: ASbGncsufSB02MacUIkvijJo3q8HU5IP9SRVKptvczyP14rSNgmx5yqAOgDmGmMUQ6r 7BDXX4bLxznlKWyKQ7/An/HqKelWfuspvwfnxGu06IgODfnlkzdLqz1rgYFN/UtgRa6swgFpJEw 6mZAtF0vdEa1eTIcOap39i+ePv70mLFATmhIhbfMrjn79s1/WHCPKW9MawJtyaNBmn0euVCeDLA UJ3ONcP+UZ7PDaOhEbVM9vycptw4tjwZt8uwH/DMCDkuPZ8o9BsyZfkZzX+RhCrjtq0XxuNwVzD 3VwkJD2JNRlsGktsmU52b8gsDXqOMO484usVx1emAS3cOeZyS/u4wNEI7E+83+u068r/n2BdgQU Ylhz+7JUqE+J/KZ6ui2KN/gbhdw5nb4kQ4bcaSWWWaRm4FqKvFb/Ki/tf X-Received: by 2002:a05:620a:4049:b0:85f:89:e114 with SMTP id af79cd13be357-8b245280933mr239718085a.1.1762513224065; Fri, 07 Nov 2025 03:00:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IH34Ma6AlYFANasFLA7REiIDlipeT0LBwxV1S1iyIGEImmErkoaBKdKchVkLndS6HBNKbTjKQ== X-Received: by 2002:a05:620a:4049:b0:85f:89:e114 with SMTP id af79cd13be357-8b245280933mr239705785a.1.1762513223227; Fri, 07 Nov 2025 03:00:23 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bf9bc874sm216910666b.54.2025.11.07.03.00.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Nov 2025 03:00:21 -0800 (PST) Message-ID: <14f95efb-0eb0-48ee-9132-df35abddfcc7@oss.qualcomm.com> Date: Fri, 7 Nov 2025 12:00:12 +0100 Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 6/8] net: stmmac: qcom-ethqos: split power management context into a separate struct To: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski References: <20251107-qcom-sa8255p-emac-v5-0-01d3e3aaf388@linaro.org> <20251107-qcom-sa8255p-emac-v5-6-01d3e3aaf388@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251107-qcom-sa8255p-emac-v5-6-01d3e3aaf388@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=bOgb4f+Z c=1 sm=1 tr=0 ts=690dd149 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=iTm1nGh4yTgqJnnOKdQA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 6Jb3sU7oLP6sMLFUZNBsZwVSxTsSRqIx X-Proofpoint-GUID: 6Jb3sU7oLP6sMLFUZNBsZwVSxTsSRqIx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA3MDA4OCBTYWx0ZWRfXy7cuBy8OxZkK hNn1yLo0idvWaLrAz9CYaSqAQFovXsW9bk/5KLcA1icGuRA93W55P989jYvPQDRVD1FtmG0IxwJ WgDFbuds44uighpvcg9VaqQ+TLfS0QXKJWSsp9cGIbpExryV84o/isEPyynuxpLxjIgDH49Tcg1 qtU52HmbtgMZ7GeQkWPKzN5zsdV8V3m67LX26cjreid8vUlZKZU00Ts2jnLb9KE6jC1wEHnhkBc enMgKLaA9p76XVD8+0McvJhJ4EHg7tTd4UKXdgQoFGAVhl7FkTnJY49/BC+u/0OQpvdY6RGlRZI cMu8goKrbnNzJL6VoH9YcTB8e3i/W+OWDRulHmWU6RUJB9GpgOwN2E5RuAF13qQvFrd9NNKRl63 dZ4DwJrQiDlx1WXvV1eHMktv6eOzkw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-07_02,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511070088 On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > With match data split into general and power-management sections, let's > now do the same with runtime device data. > > Signed-off-by: Bartosz Golaszewski > --- > .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 46 ++++++++++++---------- > 1 file changed, 25 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 1f00556bbad997e2ec76b521cffe2eb14fabb79e..09f122062dec87aa11804af2769ddff4964e6596 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -105,17 +105,21 @@ struct ethqos_emac_match_data { > const struct ethqos_emac_pm_data *pm_data; > }; > > +struct ethqos_emac_pm_ctx { > + struct clk *link_clk; > + unsigned int link_clk_rate; > + struct phy *serdes_phy; What is the benefit of doing this? PHY APIs happily consume a nullptr and NOP out, and the PHY is already retrieved with _optional(), similarly with clk Konrad