* [PATCH] drm: rcar-du: enable VSPDs on R8A7791
@ 2016-12-14 20:37 Sergei Shtylyov
2016-12-14 20:55 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2016-12-14 20:37 UTC (permalink / raw)
To: laurent.pinchart, airlied, dri-devel, linux-renesas-soc
We're going to use R8A7791 VSPDs to control DU, so set the corresponding
flag.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch.
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c
===================================================================
--- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -90,7 +90,8 @@ static const struct rcar_du_device_info
static const struct rcar_du_device_info rcar_du_r8a7791_info = {
.gen = 2,
.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
- | RCAR_DU_FEATURE_EXT_CTRL_REGS,
+ | RCAR_DU_FEATURE_EXT_CTRL_REGS
+ | RCAR_DU_FEATURE_VSP1_SOURCE,
.num_crtcs = 2,
.routes = {
/* R8A779[13] has one RGB output, one LVDS output and one
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: rcar-du: enable VSPDs on R8A7791
2016-12-14 20:37 [PATCH] drm: rcar-du: enable VSPDs on R8A7791 Sergei Shtylyov
@ 2016-12-14 20:55 ` Laurent Pinchart
2016-12-19 19:58 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2016-12-14 20:55 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: airlied, dri-devel, linux-renesas-soc
Hi Sergei,
Thank you for the patch.
On Wednesday 14 Dec 2016 23:37:08 Sergei Shtylyov wrote:
> We're going to use R8A7791 VSPDs to control DU, so set the corresponding
> flag.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
For the same reason I nacked the corresponding patch to the VSP1 driver, I
have to nack this one as well. The Gen2 DU has native planes, this patch would
prevent using them. I don't see a good reason to do so.
> ---
> The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch.
>
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> ===================================================================
> --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -90,7 +90,8 @@ static const struct rcar_du_device_info
> static const struct rcar_du_device_info rcar_du_r8a7791_info = {
> .gen = 2,
> .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> - | RCAR_DU_FEATURE_EXT_CTRL_REGS,
> + | RCAR_DU_FEATURE_EXT_CTRL_REGS
> + | RCAR_DU_FEATURE_VSP1_SOURCE,
> .num_crtcs = 2,
> .routes = {
> /* R8A779[13] has one RGB output, one LVDS output and one
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: rcar-du: enable VSPDs on R8A7791
2016-12-14 20:55 ` Laurent Pinchart
@ 2016-12-19 19:58 ` Sergei Shtylyov
2016-12-19 20:24 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2016-12-19 19:58 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: airlied, dri-devel, linux-renesas-soc
Hello!
On 12/14/2016 11:55 PM, Laurent Pinchart wrote:
>> We're going to use R8A7791 VSPDs to control DU, so set the corresponding
>> flag.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> For the same reason I nacked the corresponding patch to the VSP1 driver, I
> have to nack this one as well. The Gen2 DU has native planes, this patch would
> prevent using them. I don't see a good reason to do so.
One of the reasons is that these patches kill the horizontal noise when
playing video in Weston...
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: rcar-du: enable VSPDs on R8A7791
2016-12-19 19:58 ` Sergei Shtylyov
@ 2016-12-19 20:24 ` Laurent Pinchart
2016-12-26 19:45 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2016-12-19 20:24 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: airlied, dri-devel, linux-renesas-soc
Hi Sergei,
On Monday 19 Dec 2016 22:58:57 Sergei Shtylyov wrote:
> On 12/14/2016 11:55 PM, Laurent Pinchart wrote:
> >> We're going to use R8A7791 VSPDs to control DU, so set the corresponding
> >> flag.
> >>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > For the same reason I nacked the corresponding patch to the VSP1 driver, I
> > have to nack this one as well. The Gen2 DU has native planes, this patch
> > would prevent using them. I don't see a good reason to do so.
>
> One of the reasons is that these patches kill the horizontal noise when
> playing video in Weston...
What horizontal noise ? :-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: rcar-du: enable VSPDs on R8A7791
2016-12-19 20:24 ` Laurent Pinchart
@ 2016-12-26 19:45 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2016-12-26 19:45 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: airlied, dri-devel, linux-renesas-soc
On 12/19/2016 11:24 PM, Laurent Pinchart wrote:
>>>> We're going to use R8A7791 VSPDs to control DU, so set the corresponding
>>>> flag.
>>>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> For the same reason I nacked the corresponding patch to the VSP1 driver, I
>>> have to nack this one as well. The Gen2 DU has native planes, this patch
>>> would prevent using them. I don't see a good reason to do so.
>>
>> One of the reasons is that these patches kill the horizontal noise when
>> playing video in Weston...
>
> What horizontal noise ? :-)
Occurs with V4L2 renderer... :-)
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-26 19:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-14 20:37 [PATCH] drm: rcar-du: enable VSPDs on R8A7791 Sergei Shtylyov
2016-12-14 20:55 ` Laurent Pinchart
2016-12-19 19:58 ` Sergei Shtylyov
2016-12-19 20:24 ` Laurent Pinchart
2016-12-26 19:45 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).