From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kirsty.vergenet.net ([202.4.237.240]:34227 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034AbcETEUa (ORCPT ); Fri, 20 May 2016 00:20:30 -0400 Date: Fri, 20 May 2016 13:20:27 +0900 From: Simon Horman To: Sergei Shtylyov Cc: Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , Magnus Damm , Russell King , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 2/6] ARM: dts: r8a7794: add MSTP5 clocks Message-ID: <20160520042027.GD25184@verge.net.au> References: <2378837.cigT3tNQPe@wasted.cogentembedded.com> <1576909.nm8MtQ2Ln5@wasted.cogentembedded.com> <23a35d91-7ba3-be23-c8ee-5a056e6a627b@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <23a35d91-7ba3-be23-c8ee-5a056e6a627b@cogentembedded.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Thu, May 19, 2016 at 08:30:12PM +0300, Sergei Shtylyov wrote: > On 05/19/2016 07:25 PM, Geert Uytterhoeven wrote: > > >>Add some MSTP5 clocks to the R8A7794 device tree. > >> > >>Signed-off-by: Sergei Shtylyov > >> > >>--- > >>Changes in version 3: > >>- refreshed the patch. > >> > >>Changes in version 2: > >>- added "the" article to the change log. > >> > >> arch/arm/boot/dts/r8a7794.dtsi | 9 +++++++++ > >> include/dt-bindings/clock/r8a7794-clock.h | 1 + > >> 2 files changed, 10 insertions(+) > >> > >>Index: renesas/arch/arm/boot/dts/r8a7794.dtsi > >>=================================================================== > >>--- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi > >>+++ renesas/arch/arm/boot/dts/r8a7794.dtsi > >>@@ -1172,6 +1172,15 @@ > >> clock-indices = ; > >> clock-output-names = "irqc"; > >> }; > >>+ mstp5_clks: mstp5_clks@e6150144 { > >>+ compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; > >>+ reg = <0 0xe6150144 0 4>, <0 0xe615003c 0 4>; > >>+ clocks = <&hp_clk>, <&extal_clk>, <&p_clk>; > >>+ #clock-cells = <1>; > >>+ clock-indices = >>+ R8A7794_CLK_THERMAL R8A7794_CLK_PWM>; > >>+ clock-output-names = "audmac0", "thermal", "pwm"; > > > >R-Car E2 does not have the thermal module. > > My "R-Car Series, 2nd Generation User’s Manual: Hardware, Rev.1.02 Oct > 2014" says it does. What's your source? Please see chapter 80 of v2.00. I have also confirmed with the hw team that the thermal sensor is not present. FWIW until recently I was also going off the older documentation in this regards and the absence of the thermal block was a bit of a revelation to me. > >>+ }; > >> mstp7_clks: mstp7_clks@e615014c { > >> compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; > >> reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>; > >>Index: renesas/include/dt-bindings/clock/r8a7794-clock.h > >>=================================================================== > >>--- renesas.orig/include/dt-bindings/clock/r8a7794-clock.h > >>+++ renesas/include/dt-bindings/clock/r8a7794-clock.h > >>@@ -67,6 +67,7 @@ > >> #define R8A7794_CLK_IRQC 7 > >> > >> /* MSTP5 */ > >>+#define R8A7794_CLK_AUDIO_DMAC0 2 > >> #define R8A7794_CLK_THERMAL 22 > > > >Hence R8A7794_CLK_THERMAL should be removed. > > Well, remove it then. ;-) > > >> #define R8A7794_CLK_PWM 23 > > > >Gr{oetje,eeting}s, > > MBR, Sergei >