From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-renesas-soc-owner@vger.kernel.org>
Received: from kirsty.vergenet.net ([202.4.237.240]:34270 "EHLO
	kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751199AbcETEWi (ORCPT
	<rfc822;linux-renesas-soc@vger.kernel.org>);
	Fri, 20 May 2016 00:22:38 -0400
Date: Fri, 20 May 2016 13:22:35 +0900
From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-renesas-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/6] ARM: dts: r8a7794: add MSTP10 clocks
Message-ID: <20160520042235.GE25184@verge.net.au>
References: <2378837.cigT3tNQPe@wasted.cogentembedded.com>
 <3321354.LNTkVAhXvF@wasted.cogentembedded.com>
 <CAMuHMdVjrVFpEZPukWiLQK473R+7CTqVHc1jj8fktAD9RpH_sw@mail.gmail.com>
 <f0700315-af43-b208-cd91-8ca510bf5da9@cogentembedded.com>
 <CAMuHMdWSfx_Q9xopidpLCbwHhuPKwfokiUXYPpHxf3B2tC+-dw@mail.gmail.com>
 <ba23906d-afca-ed5c-511f-bd7531a277a8@cogentembedded.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ba23906d-afca-ed5c-511f-bd7531a277a8@cogentembedded.com>
Sender: linux-renesas-soc-owner@vger.kernel.org
List-ID: <linux-renesas-soc.vger.kernel.org>

On Thu, May 19, 2016 at 09:36:27PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 05/19/2016 08:41 PM, Geert Uytterhoeven wrote:
> 
> >>>>--- renesas.orig/include/dt-bindings/clock/r8a7794-clock.h
> >>>>+++ renesas/include/dt-bindings/clock/r8a7794-clock.h
> >>>>@@ -109,6 +109,34 @@
> >>>> #define R8A7794_CLK_I2C1               30
> >>>> #define R8A7794_CLK_I2C0               31
> >>>>
> >>>>+/* MSTP10 */
> >>>>+#define R8A7794_CLK_SSI_ALL            5
> >>>>+#define R8A7794_CLK_SSI9               6
> >>>>+#define R8A7794_CLK_SSI8               7
> >>>>+#define R8A7794_CLK_SSI7               8
> >>>>+#define R8A7794_CLK_SSI6               9
> >>>>+#define R8A7794_CLK_SSI5               10
> >>>>+#define R8A7794_CLK_SSI4               11
> >>>>+#define R8A7794_CLK_SSI3               12
> >>>>+#define R8A7794_CLK_SSI2               13
> >>>>+#define R8A7794_CLK_SSI1               14
> >>>>+#define R8A7794_CLK_SSI0               15
> >>>>+#define R8A7794_CLK_SCU_ALL            17
> >>>>+#define R8A7794_CLK_SCU_DVC1           18
> >>>>+#define R8A7794_CLK_SCU_DVC0           19
> >>>>+#define R8A7794_CLK_SCU_CTU1_MIX1      20
> >>>>+#define R8A7794_CLK_SCU_CTU0_MIX0      21
> >>>>+#define R8A7794_CLK_SCU_SRC9           22
> >>>>+#define R8A7794_CLK_SCU_SRC8           23
> >>>>+#define R8A7794_CLK_SCU_SRC7           24
> >>>
> >>>
> >>>R-Car E2 does not have SRC7, SRC8, SRC9, ...
> >>>
> >>>>+#define R8A7794_CLK_SCU_SRC6           25
> >>>>+#define R8A7794_CLK_SCU_SRC5           26
> >>>>+#define R8A7794_CLK_SCU_SRC4           27
> >>>>+#define R8A7794_CLK_SCU_SRC3           28
> >>>>+#define R8A7794_CLK_SCU_SRC2           29
> >>>>+#define R8A7794_CLK_SCU_SRC1           30
> >>>>+#define R8A7794_CLK_SCU_SRC0           31
> >>>
> >>>
> >>>... and SRC0.
> >>
> >>
> >>   Yet table 7A.12 in the rev1.02 manual lists them all. Your manual
> >>doesn't?
> >
> >I thought you were aware of this, cfr. your "[PATCH] rcar: src: skip
> >disabled-SRC nodes"?
> 
>    I am, I was just pointing out that this patch was backed by the manual I
> had...

It looks like the manual is incorrect in this regard.
Please update the patch as Geert suggests.

> >Gr{oetje,eeting}s,
> >
> >                        Geert
> 
> MBR, Sergei
>