From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kirsty.vergenet.net ([202.4.237.240]:54091 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760929AbcINIzC (ORCPT ); Wed, 14 Sep 2016 04:55:02 -0400 Date: Wed, 14 Sep 2016 10:54:56 +0200 From: Simon Horman To: Wolfram Sang Cc: Ulf Hansson , Wolfram Sang , Magnus Damm , linux-mmc , Linux-Renesas Subject: Re: [PATCH v7 0/6] UHS-I SDR-104 support for sh_mobile_sdhi Message-ID: <20160914085456.GD10233@verge.net.au> References: <1473764175-24580-1-git-send-email-horms+renesas@verge.net.au> <20160913125825.GA3510@katana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160913125825.GA3510@katana> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Tue, Sep 13, 2016 at 02:58:25PM +0200, Wolfram Sang wrote: > On Tue, Sep 13, 2016 at 02:48:26PM +0200, Ulf Hansson wrote: > > On 13 September 2016 at 12:56, Simon Horman wrote: > > > > > > Hi, > > > > > > this series is based on work by Ai Kyuse to add UHS-I SDR-104 support for > > > sh_mobile_sdhi. It builds on work by Shinobu Uehara, Rob Taylor, William > > > Towle and Ian Molton, Ben Hutchings, Wolfram Sang and others to add UHS-I > > > SDR-50 support to the same driver. > > > > > > It is based on a merge of the next branches of the mmc tree. > > > > > > To aid review the following git branch is provided: > > > * https:://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/sdr104-driver-v7 > > > > > > Overview of changes since v6: > > > * Address review by Ulf > > > - Detailed in per-patch changelogs > > > * Move integration (arm/arm64 dt) patches to separate patchset > > > > > > Please see http://elinux.org/Tests:SD-SDHI-SDR104 for indicative tests > > > results. > > > > > > > > > Ai Kyuse (3): > > > mmc: tmio: enhance illegal sequence handling > > > mmc: tmio: Add hw reset support > > > mmc: tmio: Add tuning support > > > > > > Simon Horman (3): > > > mmc: core: Add helper to see if a host can be retuned > > > mmc: tmio: document mandatory and optional callbacks > > > mmc: sh_mobile_sdhi: Add tuning support > > > > > > drivers/mmc/host/sh_mobile_sdhi.c | 265 +++++++++++++++++++++++++++++++++++++- > > > drivers/mmc/host/tmio_mmc.h | 18 ++- > > > drivers/mmc/host/tmio_mmc_pio.c | 87 ++++++++++++- > > > include/linux/mmc/host.h | 5 + > > > 4 files changed, 367 insertions(+), 8 deletions(-) > > > > > > -- > > > 2.7.0.rc3.207.g0ac5344 > > > > > > > This looks good to me, although I would like to get an ack from > > Wolfram before I queue this up. > > I'll test today or tomorrow. Same for the r7s72100 patches. Thanks! I found a logic error in the last patch of the series, I proposed a fix in a sub-thread for that patch. If you could use my proposed one-line fix when testing that would be great.