From: Wolfram Sang <wsa@the-dreams.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Simon Horman <horms@verge.net.au>,
Dirk Behme <dirk.behme@gmail.com>
Subject: Re: [PATCH v2 4/6] mmc: tmio: add eMMC support
Date: Mon, 19 Sep 2016 22:26:32 +0200 [thread overview]
Message-ID: <20160919202632.GA1425@katana> (raw)
In-Reply-To: <ddb477a7-4b3c-e67a-22fc-93432c4c75cb@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
> >+ u16 reg = sd_ctrl_read16(host, CTL_SD_MEM_CARD_OPT)
> >+ & ~(CARD_OPT_WIDTH | CARD_OPT_WIDTH8);
> >+
> >+ /* reg now applies to MMC_BUS_WIDTH_4 */
> >+ if (bus_width == MMC_BUS_WIDTH_1)
> >+ reg |= CARD_OPT_WIDTH;
> >+ else if (bus_width == MMC_BUS_WIDTH_8)
> >+ reg |= CARD_OPT_WIDTH8;
>
> Why not *switch*?
Didn't look better to me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-19 20:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 12:49 [PATCH v2 0/6] tmio: add support for eMMC with 8 bit bus width Wolfram Sang
2016-09-19 12:49 ` [PATCH v2 1/6] mmc: add define for R1 response without CRC Wolfram Sang
2016-09-19 12:49 ` [PATCH v2 2/6] mmc: rtsx_pci: use new macro for R1 " Wolfram Sang
2016-09-19 12:49 ` [PATCH v2 3/6] mmc: rtsx_usb: " Wolfram Sang
2016-09-19 12:49 ` [PATCH v2 4/6] mmc: tmio: add eMMC support Wolfram Sang
2016-09-19 17:31 ` Sergei Shtylyov
2016-09-19 20:26 ` Wolfram Sang [this message]
2016-09-19 12:49 ` [PATCH v2 5/6] arm64: dts: r8a7795: salvator: enable on-board eMMC Wolfram Sang
2016-09-19 17:25 ` Sergei Shtylyov
2016-09-19 20:29 ` Wolfram Sang
2016-09-19 12:49 ` [PATCH v2 6/6] arm64: dts: r8a7796: salvator: enable on board eMMC Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919202632.GA1425@katana \
--to=wsa@the-dreams.de \
--cc=dirk.behme@gmail.com \
--cc=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).