From: Wolfram Sang <wsa@the-dreams.de>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Simon Horman <horms@verge.net.au>,
Dirk Behme <dirk.behme@gmail.com>
Subject: Re: [PATCH v3 1/6] mmc: add define for R1 response without CRC
Date: Wed, 21 Sep 2016 08:00:33 +0200 [thread overview]
Message-ID: <20160921060033.GD1484@katana> (raw)
In-Reply-To: <ee4fe6b6-14bd-a0a5-9d6c-30c314ed83c3@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]
On Tue, Sep 20, 2016 at 06:25:37PM +0900, Jaehoon Chung wrote:
> Hi Wolfram,
>
> On 09/20/2016 05:57 AM, Wolfram Sang wrote:
> > The core uses it for polling. Give drivers a proper define handle this
> > case like for other response types.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> > include/linux/mmc/core.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
> > index b01e77de1a74de..4caee099b63a28 100644
> > --- a/include/linux/mmc/core.h
> > +++ b/include/linux/mmc/core.h
> > @@ -55,6 +55,9 @@ struct mmc_command {
> > #define MMC_RSP_R6 (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE)
> > #define MMC_RSP_R7 (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE)
> >
> > +/* Can be used by core to poll after switch to MMC HS mode */
> > +#define MMC_RSP_R1_NO_CRC (MMC_RSP_PRESENT|MMC_RSP_OPCODE)
>
> MMC_RSP_RQ_NO_CRC is described at Specification?
Yes. JEDEC eMMC Spec v5.1, chapter 6.6.2, in the note:
"NOTE While the actual timing change is done, the behavior of any
command sent (like CMD13) cannot be guaranteed due to the asynchronous
operation. Therefore it is not recommended to use CMD13 to check the
busy completion of the timing change indication. In case CMD13 is used
the host must ignore CRC errors, if appear."
And the MMC core does that. In mmc_ops.c:
70 if (ignore_crc)
71 cmd.flags &= ~MMC_RSP_CRC;
And ignore_crc is used in mmc.c (last 'true' parameter):
1023 err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
1024 EXT_CSD_HS_TIMING, EXT_CSD_TIMING_HS,
1025 card->ext_csd.generic_cmd6_time,
1026 true, false, true);
This is why I put the comment above the define.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-21 6:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 20:57 [PATCH v3 0/6] tmio: add support for eMMC with 8 bit bus width Wolfram Sang
2016-09-19 20:57 ` [PATCH v3 1/6] mmc: add define for R1 response without CRC Wolfram Sang
2016-09-20 9:25 ` Jaehoon Chung
2016-09-21 6:00 ` Wolfram Sang [this message]
2016-09-22 3:58 ` Jaehoon Chung
2016-09-19 20:57 ` [PATCH v3 2/6] mmc: rtsx_pci: use new macro for R1 " Wolfram Sang
2016-09-20 9:29 ` Jaehoon Chung
2016-09-21 6:03 ` Wolfram Sang
2016-09-19 20:57 ` [PATCH v3 3/6] mmc: rtsx_usb: " Wolfram Sang
2016-09-19 20:57 ` [PATCH v3 4/6] mmc: tmio: add eMMC support Wolfram Sang
2016-09-20 9:35 ` Jaehoon Chung
2016-09-21 6:07 ` Wolfram Sang
2016-09-19 20:57 ` [PATCH v3 5/6] arm64: dts: r8a7795: salvator: enable on-board eMMC Wolfram Sang
2016-09-19 20:57 ` [PATCH v3 6/6] arm64: dts: r8a7796: salvator: enable on board eMMC Wolfram Sang
2016-09-22 9:40 ` [PATCH v3 0/6] tmio: add support for eMMC with 8 bit bus width Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921060033.GD1484@katana \
--to=wsa@the-dreams.de \
--cc=dirk.behme@gmail.com \
--cc=horms@verge.net.au \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).