From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Chris Brandt <chris.brandt@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support
Date: Fri, 23 Sep 2016 09:41:24 +0200 [thread overview]
Message-ID: <20160923074123.GD20129@verge.net.au> (raw)
In-Reply-To: <CAMuHMdWckFaU__BM=WAOvJ+fVjEvNdLCFy0GNiKwU159aZTdhg@mail.gmail.com>
On Fri, Sep 23, 2016 at 09:09:07AM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt <chris.brandt@renesas.com> wrote:
> > Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> > ---
> > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > index e5dea5b..548b51f 100644
> > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > @@ -56,6 +56,10 @@
> > };
> > };
> >
> > +&sdhi1 {
> > + status = "okay";
>
> On all other boards, we have the bus-width property in the board-specific
> .dts instead of in the SoC-specific .dtsi.
I'd like us to be consistent as much as possible.
But I do wonder why it has been added as a board property.
> > +};
> > +
> > &scif2 {
> > status = "okay";
> > };
next prev parent reply other threads:[~2016-09-23 7:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 21:32 [PATCH 0/3] ARM: dts: r7s72100: add sdhi DT Chris Brandt
2016-09-22 21:32 ` [PATCH 1/3] ARM: dts: r7s72100: add sdhi clock to device tree Chris Brandt
2016-09-23 6:59 ` Geert Uytterhoeven
2016-09-26 14:52 ` Simon Horman
2016-09-22 21:32 ` [PATCH 2/3] ARM: dts: r7s72100: add sdhi " Chris Brandt
2016-09-23 7:05 ` Geert Uytterhoeven
2016-09-23 14:20 ` Chris Brandt
2016-09-23 14:32 ` Geert Uytterhoeven
2016-09-22 21:32 ` [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support Chris Brandt
2016-09-23 7:09 ` Geert Uytterhoeven
2016-09-23 7:41 ` Simon Horman [this message]
2016-09-23 14:33 ` Chris Brandt
2016-09-26 14:44 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923074123.GD20129@verge.net.au \
--to=horms@verge.net.au \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).