From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [RFC 2/3] mmc: host: tmio: SDIO_STATUS_QUIRK is rather SDIO_STATUS_SETBITS
Date: Tue, 10 Jan 2017 09:07:40 +0100 [thread overview]
Message-ID: <20170110080740.GD25239@verge.net.au> (raw)
In-Reply-To: <20170105114326.12426-3-wsa+renesas@sang-engineering.com>
On Thu, Jan 05, 2017 at 12:43:25PM +0100, Wolfram Sang wrote:
> QUIRK sounds like there is something wrong, but actually there are just
> some bits which need to be 1. Rename it to be more clear.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/mmc/host/sh_mobile_sdhi.c | 6 ++----
> drivers/mmc/host/tmio_mmc_pio.c | 2 +-
> include/linux/mfd/tmio.h | 2 +-
> 3 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> index 59db14b4827c33..1600fefc2c3e2c 100644
> --- a/drivers/mmc/host/sh_mobile_sdhi.c
> +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> @@ -641,10 +641,8 @@ static int sh_mobile_sdhi_probe(struct platform_device *pdev)
> */
> mmc_data->flags |= TMIO_MMC_HAVE_CMD12_CTRL;
>
> - /*
> - * All SDHI need SDIO_INFO1 reserved bit
> - */
> - mmc_data->flags |= TMIO_MMC_SDIO_STATUS_QUIRK;
> + /* All SDHI have reserved bits */
> + mmc_data->flags |= TMIO_MMC_SDIO_STATUS_SETBITS;
>
> ret = tmio_mmc_host_probe(host, mmc_data);
> if (ret < 0)
> diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
> index 60dc43b4574117..d6033620a45c12 100644
> --- a/drivers/mmc/host/tmio_mmc_pio.c
> +++ b/drivers/mmc/host/tmio_mmc_pio.c
> @@ -723,7 +723,7 @@ static void __tmio_mmc_sdio_irq(struct tmio_mmc_host *host)
> ireg = status & TMIO_SDIO_MASK_ALL & ~host->sdio_irq_mask;
>
> sdio_status = status & ~TMIO_SDIO_MASK_ALL;
> - if (pdata->flags & TMIO_MMC_SDIO_STATUS_QUIRK)
> + if (pdata->flags & TMIO_MMC_SDIO_STATUS_SETBITS)
> sdio_status |= 6;
>
> sd_ctrl_write16(host, CTL_SDIO_STATUS, sdio_status);
> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> index fba44abd05ba1a..5a05a34cc1a292 100644
> --- a/include/linux/mfd/tmio.h
> +++ b/include/linux/mfd/tmio.h
> @@ -97,7 +97,7 @@
> /*
> * Some controllers needs to set 1 on SDIO status reserved bits
> */
Is the following update to the above appropriate?
In particular, is it some or all?
* Controllers need to set 1 on SDIO status reserved bits
> -#define TMIO_MMC_SDIO_STATUS_QUIRK (1 << 8)
> +#define TMIO_MMC_SDIO_STATUS_SETBITS (1 << 8)
>
> /*
> * Some controllers have a 32-bit wide data port register
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-01-10 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 11:43 [RFC 0/3] mmc: host: tmio: sdio irq improvements Wolfram Sang
2017-01-05 11:43 ` [RFC 1/3] mmc: host: tmio: refactor calls to sdio irq Wolfram Sang
2017-01-10 8:05 ` Simon Horman
2017-01-05 11:43 ` [RFC 2/3] mmc: host: tmio: SDIO_STATUS_QUIRK is rather SDIO_STATUS_SETBITS Wolfram Sang
2017-01-10 8:07 ` Simon Horman [this message]
2017-01-19 19:40 ` Wolfram Sang
2017-01-05 11:43 ` [RFC 3/3] mmc: tmio: discard obsolete SDIO irqs before enabling irqs Wolfram Sang
2017-01-10 8:09 ` Simon Horman
2017-01-19 19:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110080740.GD25239@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).