From: Wolfram Sang <wsa@the-dreams.de>
To: Chris Brandt <Chris.Brandt@renesas.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Simon Horman <horms+renesas@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH] ARM: dts: r7s72100: fix sdhi clock define
Date: Tue, 17 Jan 2017 09:21:19 +0100 [thread overview]
Message-ID: <20170117082118.GA1487@katana> (raw)
In-Reply-To: <SG2PR06MB11656A823E53F55C4FBCA7E88A7C0@SG2PR06MB1165.apcprd06.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
> The reason is that would then keep me from having to modify the existing
> functions sh_mobile_sdhi_clk_enable/disable.
Why do you prefer this? I may be missing something but a small if-block
per function are not expensive IMO.
> Is anyone going to have an issue if I turn the card-detect clock on but never
> turn it off???? That was the patch that I was going to test out and submit.
It smells a bit hacky to me. And while hacky things are sometimes
needed, IMO this doesn't hold true here. With just 3 more lines (an
if-block in disable and a variable for the new clock) we can have it
proper.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-01-17 8:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 18:11 [PATCH] ARM: dts: r7s72100: fix sdhi clock define Chris Brandt
2017-01-12 19:57 ` Geert Uytterhoeven
2017-01-12 20:34 ` Chris Brandt
2017-01-13 8:35 ` Simon Horman
2017-01-13 14:44 ` Chris Brandt
2017-01-13 15:10 ` Geert Uytterhoeven
2017-01-13 17:16 ` Chris Brandt
2017-01-13 17:31 ` Geert Uytterhoeven
2017-01-13 17:56 ` Chris Brandt
2017-01-16 10:36 ` Geert Uytterhoeven
2017-01-16 11:40 ` Wolfram Sang
2017-01-17 4:27 ` Chris Brandt
2017-01-17 8:21 ` Wolfram Sang [this message]
2017-01-17 9:16 ` Geert Uytterhoeven
2017-01-17 9:45 ` Wolfram Sang
2017-01-17 9:52 ` Geert Uytterhoeven
2017-01-17 9:57 ` Wolfram Sang
2017-01-17 10:00 ` Geert Uytterhoeven
2017-01-17 14:48 ` Chris Brandt
2017-01-17 18:42 ` Chris Brandt
2017-01-17 19:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117082118.GA1487@katana \
--to=wsa@the-dreams.de \
--cc=Chris.Brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox