From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-renesas-soc-owner@vger.kernel.org>
Received: from kirsty.vergenet.net ([202.4.237.240]:39490 "EHLO
        kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932696AbdEKO6b (ORCPT
        <rfc822;linux-renesas-soc@vger.kernel.org>);
        Thu, 11 May 2017 10:58:31 -0400
Date: Thu, 11 May 2017 16:58:28 +0200
From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Ulrich Hecht <ulrich.hecht@gmail.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v4 3/7] arm64: dts: renesas: salvator-x: Enable HDMI
 outputs
Message-ID: <20170511145827.GF21895@verge.net.au>
References: <20170510070458.21193-1-laurent.pinchart+renesas@ideasonboard.com>
 <20170510070458.21193-4-laurent.pinchart+renesas@ideasonboard.com>
 <CAMuHMdU1UPjwEQh4LoNUqUEv58ML=BWOA_VMKLGn2YE7L-22Lg@mail.gmail.com>
 <3272565.o4gaMbvL4P@avalon>
 <CAMuHMdX5gG+fD5NfyfQsrLDyOQA+6pCx7MPK592qn=KQvXZ_Mg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuHMdX5gG+fD5NfyfQsrLDyOQA+6pCx7MPK592qn=KQvXZ_Mg@mail.gmail.com>
Sender: linux-renesas-soc-owner@vger.kernel.org
List-ID: <linux-renesas-soc.vger.kernel.org>

On Wed, May 10, 2017 at 02:13:00PM +0200, Geert Uytterhoeven wrote:
> On Wed, May 10, 2017 at 1:52 PM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> > On Wednesday 10 May 2017 10:28:11 Geert Uytterhoeven wrote:
> >> On Wed, May 10, 2017 at 9:04 AM, Laurent Pinchart wrote:
> >> > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> >> >
> >> > Instantiate the HDMI connectors and enable the encoders.
> >> >
> >> > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> >> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> >> > Signed-off-by: Laurent Pinchart
> >> > <laurent.pinchart+renesas@ideasonboard.com>
> >> > ---
> >> >
> >> >  arch/arm64/boot/dts/renesas/salvator-x.dtsi | 50 ++++++++++++++++++++++++
> >> >  1 file changed, 50 insertions(+)
> >> >
> >> > diff --git a/arch/arm64/boot/dts/renesas/salvator-x.dtsi
> >> > b/arch/arm64/boot/dts/renesas/salvator-x.dtsi index
> >> > d5eb022d247c..2cd0cce818e7 100644
> >> > --- a/arch/arm64/boot/dts/renesas/salvator-x.dtsi
> >> > +++ b/arch/arm64/boot/dts/renesas/salvator-x.dtsi
> >> > @@ -151,6 +151,30 @@
> >> >                           1800000 0>;
> >> >         };
> >> >
> >> > +       hdmi0-out {
> >>
> >> Can you please respect sort order when inserting new nodes?
> >> Thanks!
> >
> > Doesn't it make more sense to keep all display outputs grouped together
> > instead of scattering them over the file ?
> 
> Simon, what do you think?

I tend to agree with Laurent here. I would, however, like the order to be
consistent in the case where similar nodes are in multiple files as it
makes it somewhat easier to make comparisons.