From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: Peter Rosin <peda@axentia.se>,
linux-renesas-soc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: [PATCH v2 2/2] i2c: mux: demux-pinctrl: add symlinks to the demux device in sysfs
Date: Mon, 21 May 2018 09:29:39 +0200 [thread overview]
Message-ID: <20180521072939.2836-3-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20180521072939.2836-1-wsa+renesas@sang-engineering.com>
Similar to mux devices, create special symlinks to connect the demuxed
bus with the demux device.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Changes since v1:
* check sysfs_create_link and print WARN if something fails
drivers/i2c/muxes/i2c-demux-pinctrl.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c
index 035032e20327..13d1461703f3 100644
--- a/drivers/i2c/muxes/i2c-demux-pinctrl.c
+++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c
@@ -116,6 +116,13 @@ static int i2c_demux_activate_master(struct i2c_demux_pinctrl_priv *priv, u32 ne
if (ret < 0)
goto err_with_put;
+ WARN(sysfs_create_link(&priv->cur_adap.dev.kobj, &priv->dev->kobj,
+ "demux_device"),
+ "can't create symlink to mux device\n");
+ WARN(sysfs_create_link(&priv->dev->kobj, &priv->cur_adap.dev.kobj,
+ "channel-0"),
+ "can't create symlink to channel 0\n");
+
return 0;
err_with_put:
@@ -135,6 +142,9 @@ static int i2c_demux_deactivate_master(struct i2c_demux_pinctrl_priv *priv)
if (cur < 0)
return 0;
+ sysfs_remove_link(&priv->dev->kobj, "channel-0");
+ sysfs_remove_link(&priv->cur_adap.dev.kobj, "demux_device");
+
i2c_del_adapter(&priv->cur_adap);
i2c_put_adapter(priv->chan[cur].parent_adap);
--
2.11.0
next prev parent reply other threads:[~2018-05-21 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 7:29 [PATCH v2 0/2] i2c: mux: demux-pinctrl: improve device relationships Wolfram Sang
2018-05-21 7:29 ` [PATCH v2 1/2] i2c: mux: demux-pinctrl: use proper parent device for demux adapter Wolfram Sang
2018-05-23 8:48 ` Simon Horman
2018-05-24 11:54 ` Peter Rosin
2018-05-21 7:29 ` Wolfram Sang [this message]
2018-05-22 7:13 ` [PATCH v2 2/2] i2c: mux: demux-pinctrl: add symlinks to the demux device in sysfs Peter Rosin
2018-05-22 19:13 ` Wolfram Sang
2018-05-24 11:55 ` Peter Rosin
2018-05-23 8:48 ` Simon Horman
2018-05-23 8:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521072939.2836-3-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).