From: Wolfram Sang <wsa@the-dreams.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
Subject: Re: [PATCH 2/2] i2c: rcar: implement STOP and REP_START according to docs
Date: Mon, 20 Aug 2018 14:50:53 +0200 [thread overview]
Message-ID: <20180820125053.tsgx2cuteewlcgm4@ninjato> (raw)
In-Reply-To: <20180808075928.31107-3-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On Wed, Aug 08, 2018 at 09:59:28AM +0200, Wolfram Sang wrote:
> When doing a REP_START after a read message, the driver used to trigger
> a STOP first which would then be overwritten by REP_START. This was the
> only stable method found when doing the last refactoring. However, this
> was not in accordance with the documentation.
>
> After research from our BSP team and myself, we now can implement a
> version which works and is according to the documentation. The new
> approach ensures the ICMCR register is only changed when really needed.
>
> Tested on a R-Car Gen2 (H2) and Gen3 with DMA (M3N).
>
> Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-08-20 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 7:59 [PATCH 0/2] i2c: rcar: implement STOP and REP_START according to docs Wolfram Sang
2018-08-08 7:59 ` [PATCH 1/2] i2c: rcar: refactor private flags Wolfram Sang
2018-08-16 17:15 ` Ulrich Hecht
2018-08-20 12:50 ` Wolfram Sang
2018-10-04 14:47 ` Eugeniu Rosca
2018-10-05 16:27 ` Wolfram Sang
2018-10-08 11:30 ` Eugeniu Rosca
2018-08-08 7:59 ` [PATCH 2/2] i2c: rcar: implement STOP and REP_START according to docs Wolfram Sang
2018-08-16 17:15 ` Ulrich Hecht
2018-08-20 8:58 ` Wolfram Sang
2018-08-20 12:50 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820125053.tsgx2cuteewlcgm4@ninjato \
--to=wsa@the-dreams.de \
--cc=hiromitsu.yamasaki.ym@renesas.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox